From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tak Kunihiro Newsgroups: gmane.emacs.bugs Subject: bug#35487: Make visiting function from help-mode more customizable Date: Fri, 17 May 2019 19:03:10 +0900 Message-ID: References: <20190429.213014.526232842075202623.tkk@misasa.okayama-u.ac.jp> <87sgu0wps5.fsf@mail.linkov.net> <8636lnp6lm.fsf@misasa.okayama-u.ac.jp> <86zhnmn5mc.fsf@misasa.okayama-u.ac.jp> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="130019"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (darwin) Cc: 35487@debbugs.gnu.org, Tak Kunihiro , tkk@misasa.okayama-u.ac.jp, Juri Linkov To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 17 12:08:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRZmj-000XfU-6K for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 May 2019 12:08:17 +0200 Original-Received: from localhost ([127.0.0.1]:45569 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRZmh-0005rr-NL for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 May 2019 06:08:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRZmX-0005l7-5s for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 06:08:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRZie-0008WO-No for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 06:04:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43789) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRZie-0008WE-KU for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 06:04:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hRZic-0003Rl-Sc for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 06:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tak Kunihiro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 May 2019 10:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35487 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35487-submit@debbugs.gnu.org id=B35487.155808740313197 (code B ref 35487); Fri, 17 May 2019 10:04:01 +0000 Original-Received: (at 35487) by debbugs.gnu.org; 17 May 2019 10:03:23 +0000 Original-Received: from localhost ([127.0.0.1]:57332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRZhz-0003Qm-28 for submit@debbugs.gnu.org; Fri, 17 May 2019 06:03:23 -0400 Original-Received: from mail-pg1-f175.google.com ([209.85.215.175]:46618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRZhw-0003QZ-QX for 35487@debbugs.gnu.org; Fri, 17 May 2019 06:03:21 -0400 Original-Received: by mail-pg1-f175.google.com with SMTP id t187so3061426pgb.13 for <35487@debbugs.gnu.org>; Fri, 17 May 2019 03:03:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YmPwdcDb7Cj2slgp8c0B/mucBWZtP3uMLWUmbCOdOxY=; b=dvoDvX2raSgmYBoZCSXCVtz+2CiBBFcahNUCuDRLrc6HEnLwkmNNvbvzsXQnqm5smj Iy5c60QOcxnPunA0KOzr9jhvCZagBcrYfmsfJYFWLJmUdKZZ+saH+swneothGlzTDL01 a+1GpkI3vjgGkGCqjr/wRkRVJ24+e3ti5MlmbtSiCYVS7qPUX6o/b98zi3dd7tnP6M24 GR8d2/A94g6btLAjLyGXUiWsgpVCRsvLvLVmLGUYjDwVU3W9LmcBGfZxz5E0VklNBOXq qSyg1L1xfNfXT07PAqdRESPqisbgRWZt9zanIcTqOjCAZB1dF/D8OEAIf8pNj/UjtvsU DSrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=YmPwdcDb7Cj2slgp8c0B/mucBWZtP3uMLWUmbCOdOxY=; b=Sxc9zlXVcNRXD0lyL1WFLL7/s8vlOnijbKekh7yz6pifvYWnmn7T7gi+47gso7yPss i4bH3dSdIymR5C9FG4eDvf4DTgUzKmkTOf2OaLEKkvwmtArXC0JT+F9IuFixwsg+xRWE z5NWV5BiyBARlTq4qNO5J77174o0CSnIYSfFYITPLdzOo9LDCvo5t0Ycbu4J87TC+xAS 9mitJ41pO//ly4LOwPR8cIUkErPOktSGre9t7AZX45B1puLNN8Xr+OyboAUCUuIod/0e /wqGzlO0jL02JomS7Dnn5gGoPL96CDztIqviRP1aoSx6fkvIWqzcBgQSbnJaQcMlYy6U +utA== X-Gm-Message-State: APjAAAWQ7X0BsHIrxwWzndcVf2N7cyJS4UDgnk2dVMCyDqr3zCAONnHQ p9tHHMQSsV7iCEmYE7hMatM= X-Google-Smtp-Source: APXvYqwjofeR4d8e9Kwwv4B4TrGMAxiEr6uYBKwoeSump05FUjgG5kIviD0z9aIRgtsBZGsHVS4FXQ== X-Received: by 2002:a63:5ec5:: with SMTP id s188mr39975145pgb.418.1558087394872; Fri, 17 May 2019 03:03:14 -0700 (PDT) Original-Received: from DreamMini2019.local (vesta.misasa.okayama-u.ac.jp. [150.46.48.154]) by smtp.gmail.com with ESMTPSA id l63sm12142871pfl.181.2019.05.17.03.03.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 May 2019 03:03:14 -0700 (PDT) X-Google-Original-From: Tak Kunihiro In-Reply-To: (Stefan Monnier's message of "Thu, 16 May 2019 16:25:11 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159438 Archived-At: >> (define-key help-mode-map (kbd "f") 'push-button-display-buffer) >> >> (defun push-button-display-buffer (&optional action) >> (interactive) >> (or action (setq action 'display-buffer-same-window)) >> (let ((display-buffer-alist >> `((display-buffer-condition-from-help ,action)))) >> (push-button))) >> >> (defun display-buffer-condition-from-help (_buffer-name _action) >> (with-current-buffer (window-buffer) >> (eq major-mode 'help-mode))) > > I think the display-buffer-condition-from-help (which likely should > have a final "-p" in its name) is only needed you you want to add it to > the global value of display-buffer-alist. > > In the above code, since you're using a specific binding in > help-mode-map, you presumably already know that (eq major-mode 'help-mode) > so you can just rebind display-buffer-overriding-action. Thank you Stefan for the help! I think that following will open the code in the same window. I wanted this for a long time... #+begin_src emacs-lisp (define-key help-mode-map (kbd "f") 'push-button-display-same-window) (define-key help-mode-map (kbd "o") 'push-button) (defun push-button-display-same-window () (interactive) (let ((display-buffer-overriding-action '(display-buffer-same-window))) (push-button))) #+end_src