From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62573: 29.0.60; Cursor color not being inverted in emacs-29 Date: Sun, 02 Apr 2023 13:01:07 +0200 Message-ID: References: <83edp420lx.fsf@gnu.org> <83bkk817rr.fsf@gnu.org> <83cz4myio7.fsf@gnu.org> Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16141"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) Cc: luangruo@yahoo.com, abdo.haji.ali@gmail.com, 62573@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 02 13:02:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pivU1-0003zi-F6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Apr 2023 13:02:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pivTY-0001o4-3Z; Sun, 02 Apr 2023 07:02:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pivTO-0001lO-Jo for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 07:02:15 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pivTG-0003Ef-J0 for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 07:02:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pivTG-0002UU-4z for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 07:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Apr 2023 11:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62573 X-GNU-PR-Package: emacs Original-Received: via spool by 62573-submit@debbugs.gnu.org id=B62573.16804332789508 (code B ref 62573); Sun, 02 Apr 2023 11:02:02 +0000 Original-Received: (at 62573) by debbugs.gnu.org; 2 Apr 2023 11:01:18 +0000 Original-Received: from localhost ([127.0.0.1]:39277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pivSY-0002TF-4F for submit@debbugs.gnu.org; Sun, 02 Apr 2023 07:01:18 -0400 Original-Received: from sonic313-20.consmr.mail.ir2.yahoo.com ([77.238.179.187]:41645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pivSV-0002T0-TL for 62573@debbugs.gnu.org; Sun, 02 Apr 2023 07:01:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1680433270; bh=+HpyADOOmDFAIoKx6JIse4h63EtHJDJjb6unyJO93p8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=k4J+H0cI5/sgWSm8Ejq2zN1ry925S6JgsJDTUs/3/MRUU9vDe6MBdf+bxPyfQ4ZqrB0biwdVO3M6q0tLWJevgmZTc2fWdCI1Bk7zL2xbYXCAcAJBZ9cHkNoprOlc54TWH+OiWUcB/Arimftjj7zGsX1hS6z+j4Sl4vBHOMmpohbYVOfETkEw50tEESaoYc/hmEa5gZP6TvvZr5qAO25zVEt3Xqs6VlRDDsf+UK9gPr9yhUAo31EMZoPRDphuV8yH0321ehaSXm44Xc9FXxT7PvalH8BD51W/UUKcH5FUR8a7knpocOtKugsbrC5XUQTBwLT7Wu7OeQ/kFcwCZZ/pCA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1680433270; bh=lzol4XeyeRrtHe5Pmv+KHiOyUJyjiViEmTQUco+Qib6=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=tEasrtflZKhV3iM4IEMz/K5Fw+zCZ9F4QQ9I2e6G8SAkdYjxlm8sCDwHA5fqCBg3HuJ9Fx4WVFFzVZrOJZ2hpy9OkOmyHbFGqZguseGw2pkb6PKxU4Q9eMUM+NWr1+7H6zegw7Bq2uDF4VSAuSS8DzwClTgcFZVtootvz6poG3oGJGp1HZOHDb44iwP717xMnLKXMClAfOQwc+ab6hG1hygyvrOIjAvUjgECLjtQ08z3m46XlUXF9eUEekh/fmSlalC3LyoAd/geWOcj+yYqqezf7BiMs8oCzyH4ez1oh084NP9C7eodM1xcriS2Vu47YgGAgfm+xPhaeKKI1SzqMA== X-YMail-OSG: PaUoVv0VM1kv3OWImK_Ok5YOixNrt_Z_FkMhDQtMzy4msfFxNayUkTbmoDSCpx8 4kVrO4R0T3kUPS6DAlUUlLUMu3.m26fIn.ri_PKY047GJrbb3Vcz978eCW6ZTmWBMo94t9wIJ_dd uBQqlUlqc0VyN6oLjTbSfHUHSnGOApcXDOdTKOcKhVFl9FQNOcJjXswBvT0h7seTY00br0lD0yzi _I5SaKU75FUzToll2cp8PjaVnI7fZtTvhDRtoZxCvlZNyHg5UnPSrLekCZiADRUQL305VN9EJ8TO PSDnGJ9x3z2LfaFvh8OsjBLGCJk9LecRdlt2NwUFrWtE_HJhpkCUJA6X3ZKXwjVHKr.za7rp5c_1 L5iRDGbGCs.PWE1vZqp2rEjhTg3WhhppbXAmcO_TOT4.NG7Cwxm0.HwIZnFk.z5zzjh9iWRRa7KA 4u1SNtA6rDPqND9p_YUNV9j0yhJ9D4t4LPkVaUwPcEYqIFOaTtmBEgpyFqbpCkZiLWkvPXXokxD3 UzIwZy1reUqfNqYJNzaKku8UqOk86k30sJTJ5CiYM.p4kzxADMVydTHgY.fHGulAAzSFtJO5kWGr kzoaqBPe0zNKhnQuu6naHMjLkDweqA0e2GiGZM.j9ux5yzgAt7PCjXSrB7dyg7IT_RBvHsa7k2zb oicjj2ZgUPJ4Gd_CX6OX0CjwgV3xmnzxD7jVzAXaSi1g.ayuLUBcVLK7RizccJGMWm1x8SAaaEAc kvzg0Gg47hDVPM3NlltR8lGQ.Whn6rsIBRkIq7ufuW8sMaDp802YtmKvKL7GXgqoPFcwMCdqDZNw O4JCbT84RzaKuEstjGiXvvI8d5WKKIfXmJ24Xx..v0 X-Sonic-MF: X-Sonic-ID: 2aa85966-fea2-4eec-8a3f-59add0ac120d Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Sun, 2 Apr 2023 11:01:10 +0000 Original-Received: by hermes--production-ir2-74cd8fc864-tk7pl (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 8ca87c5bb948152b4451d46bb509e689; Sun, 02 Apr 2023 11:01:08 +0000 (UTC) In-Reply-To: <83cz4myio7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 02 Apr 2023 08:09:12 +0300") X-Mailer: WebService/1.1.21284 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259104 Archived-At: Eli Zaretskii writes: >> From: Daniel Mart=C3=ADn >> Cc: Al Haji-Ali , 62573@debbugs.gnu.org, >> luangruo@yahoo.com >> Date: Sat, 01 Apr 2023 21:56:33 +0200 >>=20 >> This bug is a regression caused by >> 07715630ad9df9cb681cbadecbaf73fc9c698061. (Adding Po Lu to the CC.) >>=20 >> >From what I see, the font display refactor removed this code from >> src/nsterm.m: >>=20 >> - face =3D FACE_FROM_ID_OR_NULL (f, phys_cursor_glyph->face_id); >> - if (face && NS_FACE_BACKGROUND (face) >> - =3D=3D ns_index_color (FRAME_CURSOR_COLOR (f), f)) >> - { >> - [ns_lookup_indexed_color (NS_FACE_FOREGROUND (face), f) set]; >> - hollow_color =3D FRAME_CURSOR_COLOR (f); >> - } >> - else >>=20 >> which seems to be responsible for the cursor color change when the >> background face color is the same as the cursor color. I can't find >> that logic in the current code, so I think we miss it from the >> refactoring. >>=20 >> I've solved the bug by replicating that logic in the appropriate places, >> nsterm.m and macfont.m: > > This regression should be fixed on the release branch, but the patch > you propose is quite large. Can't we simply reinstate the removed > code, and apply the changes you propose only on master? > That's the first thing I tried, but it didn't fix the problem. More code changes would be needed because, since 07715630ad9df9cb681cbadecbaf73fc9c698061, the responsibility of drawing the cursor now resides in the macOS font driver (macfont.m).