From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69079: [PATCH] Add 'customize-toggle-option' command Date: Tue, 13 Feb 2024 13:46:28 +0100 Message-ID: References: <87frxx37wq.fsf@posteo.net> <86plx1r2uq.fsf@gnu.org> <87le7p1pg8.fsf@posteo.net> <86frxxqxzw.fsf@gnu.org> <87r0hh1aq9.fsf@posteo.net> <864jecr0z2.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5661"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic , 69079@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 13 13:47:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZsBl-0001HH-DD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Feb 2024 13:47:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZsBa-0003nV-R0; Tue, 13 Feb 2024 07:46:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZsBT-0003mz-RK for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 07:46:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZsBQ-0002fO-U7 for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 07:46:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZsBi-0004mV-9O for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 07:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Feb 2024 12:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69079 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69079-submit@debbugs.gnu.org id=B69079.170782841118362 (code B ref 69079); Tue, 13 Feb 2024 12:47:02 +0000 Original-Received: (at 69079) by debbugs.gnu.org; 13 Feb 2024 12:46:51 +0000 Original-Received: from localhost ([127.0.0.1]:42849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZsBX-0004m6-0b for submit@debbugs.gnu.org; Tue, 13 Feb 2024 07:46:51 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:46566 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZsBV-0004m0-6g for 69079@debbugs.gnu.org; Tue, 13 Feb 2024 07:46:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1707828391; bh=Hn5+7YqFzj2wfJO/b7JnwbcoPXkFHnSOQDsQidIovHQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=X2fYkA/0WopEuFvqUn0JXePHjejKYc2B9JEcZpaArBtkUU9x2YmypOsWEQlQ3bSjp J3z9QTqii8DO1AZY53lcUUpPCxFQ/kzWdKZlkF5UFyZCrZqFqDPtHUZSObKMrzLStZ JauPsBT/zTOHAO0k+egPk7DG+VZSQiCk0O2uNliW829qJ2nYUMNJpEZVpgNq5A2V2E it/BxalIZ5hZmnlhgiX3mGmGEQ1wKbXHS5SgIite6awAPSOp3tRD62skicH7Y5hDUa LfLpgOnekE1ac4R1SXSOVYYdLTvIBTpwJPmVGcev1B3HiW5YmGhxJIcJmyYeX5X+Dw wKAYJcQ0/p1Yg== In-Reply-To: <864jecr0z2.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 13 Feb 2024 14:40:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279962 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: 69079@debbugs.gnu.org >> Date: Tue, 13 Feb 2024 00:14:38 +0000 >> >> >> My assumption was that the command would only be invoked interactivly, >> >> so I can either make that explicit with an `interactive-only' or repeat >> >> the check. What do you think would be better? >> > >> > I think an explicit test is better, since then we get to display a >> > user-friendly error message, instead of relying on Lisp errors to >> > explain themselves. >> > >> > Btw, are you sure that the users can never succeed in inputting a >> > non-boolean option with the way you prompt them? >> >> No, that was not ensured, and I think it is better not to. I have >> adjusted the patch to check and prompt the user if the user option is >> non-boolean, in case they know what they are doing. WDYT? > > LGTM, although I haven't tried to actually use the code. > > Thanks. FWIW, I think it'd be nice to use the as the default minibuffer argument symbol at point, if applicable.