From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el Date: Sun, 03 Jun 2012 10:07:28 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1338689300 26075 80.91.229.3 (3 Jun 2012 02:08:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2012 02:08:20 +0000 (UTC) Cc: 11606@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 03 04:08:19 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sb0Es-0005Ng-KK for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2012 04:08:18 +0200 Original-Received: from localhost ([::1]:44343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sb0Es-0006AN-Ab for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jun 2012 22:08:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sb0Ep-0006AF-T0 for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2012 22:08:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sb0Eo-0002sX-27 for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2012 22:08:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sb0En-0002sS-S9 for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2012 22:08:13 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sb0GY-0005v0-7W for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2012 22:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jun 2012 02:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11606 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11606-submit@debbugs.gnu.org id=B11606.133868937922717 (code B ref 11606); Sun, 03 Jun 2012 02:10:02 +0000 Original-Received: (at 11606) by debbugs.gnu.org; 3 Jun 2012 02:09:39 +0000 Original-Received: from localhost ([127.0.0.1]:55123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sb0GB-0005uM-37 for submit@debbugs.gnu.org; Sat, 02 Jun 2012 22:09:39 -0400 Original-Received: from mail-pb0-f44.google.com ([209.85.160.44]:53449) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sb0G8-0005u9-Uz for 11606@debbugs.gnu.org; Sat, 02 Jun 2012 22:09:37 -0400 Original-Received: by pbcwy7 with SMTP id wy7so4188443pbc.3 for <11606@debbugs.gnu.org>; Sat, 02 Jun 2012 19:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=jT4KjjTyjpg8OsX6harwMH2dcD28KVDuYCggOpJLEl8=; b=ZcKHlApwlFI6Z8lscjzhGL/t3vx11iHiOCtoGAL40wmVi5sHiEtJGq7TZPEXwyndV5 JFldytPpVn4Qt7vwIKJ8TDcNTEJfdd5USXZXFRoU8rNHsD8yDCeZzcnyJHIHaWF6PKCe bUP1ehBGvU5Xi3Dak2Xq4MmmQWu3dGARUq+IGUj45XRo+o2lPIeBmu1RmMjb1di+J/in 4l0s/mkImJMqofItmewJw3erjc0YuQCU8iheOIRiVFgeO7mqiutfHNL+Gb+aRyfSKSu7 itD47etZlVTo3CAIT+ySxBPB3r1ErINH4XmkI6+2gasDKexLcZ2ydfem6QvLSxKzQSYz A0Lw== Original-Received: by 10.68.232.38 with SMTP id tl6mr23528366pbc.89.1338689262524; Sat, 02 Jun 2012 19:07:42 -0700 (PDT) Original-Received: from localhost ([221.219.113.118]) by mx.google.com with ESMTPS id wn3sm8071830pbc.74.2012.06.02.19.07.37 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 02 Jun 2012 19:07:41 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Sat, 02 Jun 2012 13:57:18 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (Mac OS X 10.6.8) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60649 Archived-At: On 2012-06-03 01:57 +0800, Stefan Monnier wrote: > I like removing things, but could you expand on why you think we should > remove these? Not removing the hooks themselves but the buffer-local bits, i.e. === modified file 'lisp/find-file.el' --- lisp/find-file.el 2012-05-04 05:14:14 +0000 +++ lisp/find-file.el 2012-06-03 02:06:57 +0000 @@ -284,11 +284,6 @@ ;; No user definable variables beyond this point! ;; ============================================== -(make-variable-buffer-local 'ff-pre-find-hook) -(make-variable-buffer-local 'ff-pre-load-hook) -(make-variable-buffer-local 'ff-post-load-hook) -(make-variable-buffer-local 'ff-not-found-hook) -(make-variable-buffer-local 'ff-file-created-hook) (make-variable-buffer-local 'ff-case-fold-search) (make-variable-buffer-local 'ff-always-in-other-window) (make-variable-buffer-local 'ff-ignore-include)