From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#15746: 24.3; [PATCH] bookmark should confirm when overwrite Date: Wed, 30 Oct 2013 10:56:34 +0800 Message-ID: References: <87iowg9bqw.fsf@floss.red-bean.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1383101838 21289 80.91.229.3 (30 Oct 2013 02:57:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Oct 2013 02:57:18 +0000 (UTC) Cc: Karl Fogel , 15746@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 30 03:57:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VbLyC-0004CJ-6H for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2013 03:57:20 +0100 Original-Received: from localhost ([::1]:50272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbLyB-00068g-QQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Oct 2013 22:57:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbLy1-00068V-Vv for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 22:57:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbLxu-0000av-HD for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 22:57:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbLxu-0000aq-Dh for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 22:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VbLxu-0005sn-1S for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 22:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Oct 2013 02:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15746-submit@debbugs.gnu.org id=B15746.138310181222596 (code B ref 15746); Wed, 30 Oct 2013 02:57:01 +0000 Original-Received: (at 15746) by debbugs.gnu.org; 30 Oct 2013 02:56:52 +0000 Original-Received: from localhost ([127.0.0.1]:51842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbLxj-0005sN-H3 for submit@debbugs.gnu.org; Tue, 29 Oct 2013 22:56:51 -0400 Original-Received: from mail-pb0-f44.google.com ([209.85.160.44]:61945) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbLxh-0005s7-H1 for 15746@debbugs.gnu.org; Tue, 29 Oct 2013 22:56:50 -0400 Original-Received: by mail-pb0-f44.google.com with SMTP id rp16so739358pbb.3 for <15746@debbugs.gnu.org>; Tue, 29 Oct 2013 19:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=UpvwEpgVVnWAtdgCBK0txg8uHIo2ovsbG5bi/qsfCBM=; b=TvgAm/xQ/ku3v9kThCy4Jmnot0GlEVJRnjStImC+EYI2cXR6vWbYPPaw5dTcQRpLvG qN17SRqoqaqkbRnoKCJEaBLc5+SBeJ1w/m2bxmwuUNPlR115In0dXAGjfpRm6WQttJ1a J1Jux9i1d6V2ADEjSwiDjHj6jTZeZXnEqzdLXRYxl36pM+EMxvDXhZLhm0XzUzwu/Wq5 7f1CVeAPIvwS4/FiTbdbKzmVXer0BegSot2Hy5itJppQ+2ntHDrCy11kUiYEj+YDTTRG DBlreRP9akJfA3S6vg9sZcKyZAlqan4rHiaAndiLkA7bwIoEcLPAZ2PI5bY15zJVtIY/ 5OiQ== X-Received: by 10.68.254.105 with SMTP id ah9mr2676491pbd.87.1383101803558; Tue, 29 Oct 2013 19:56:43 -0700 (PDT) Original-Received: from localhost ([222.130.176.76]) by mx.google.com with ESMTPSA id lm2sm1153912pab.2.2013.10.29.19.56.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Oct 2013 19:56:43 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Tue, 29 Oct 2013 22:11:49 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79772 Archived-At: On 2013-10-30 10:11 +0800, Stefan Monnier wrote: > How 'bout the following: > - change bookmark-set to emit a clear message when it updates an > existing message, as well as recording the previous value somewhere. > - provide a bookmark-undo command so the user can undo his > bookmark-set when he discovers that he has just changed an existing > bookmark by mistake. > This way, we avoid prompting Drew annoyingly when he knows full well > he's updating the bookmark. > Leo, would that be sufficient to avoid the regrets, or did you realize > too late for a bookmark-undo to be of any use? Undo in this case is less intuitive than when editing text. I think the right moment to decide overwriting is when creating the bookmark. So maybe we could provide a variable to control this confirmation behaviour? But I agree with Karl the default should provide confirmation. BTW, I use bookmark as some sort of persistent registers that I can make use another day another place. I rsync bookmarks to a few machines so bookmark-save-flag is 1 to make sure the db is always fully in disk. Leo