From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#31794: 26.1; dired-do-shell-command broken Date: Tue, 12 Jun 2018 12:24:09 +0800 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528777387 4552 195.159.176.226 (12 Jun 2018 04:23:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 12 Jun 2018 04:23:07 +0000 (UTC) Cc: Mark Oteiza To: 31794@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 12 06:23:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSapi-00013Q-Rt for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jun 2018 06:23:03 +0200 Original-Received: from localhost ([::1]:52643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSarp-0007i6-Pu for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jun 2018 00:25:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSari-0007gw-Kc for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 00:25:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSare-0002Z2-LI for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 00:25:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35997) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSare-0002Ys-Gl for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 00:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSare-0004CG-07; Tue, 12 Jun 2018 00:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: mvoteiza@udel.edu, bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jun 2018 04:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31794 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Mark Oteiza Original-Received: via spool by submit@debbugs.gnu.org id=B.152877747216090 (code B ref -1); Tue, 12 Jun 2018 04:25:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Jun 2018 04:24:32 +0000 Original-Received: from localhost ([127.0.0.1]:43893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSarA-0004BS-4D for submit@debbugs.gnu.org; Tue, 12 Jun 2018 00:24:32 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSar7-0004BE-H0 for submit@debbugs.gnu.org; Tue, 12 Jun 2018 00:24:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSar1-0002HI-9Z for submit@debbugs.gnu.org; Tue, 12 Jun 2018 00:24:24 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:51207) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSar1-0002HA-6Z for submit@debbugs.gnu.org; Tue, 12 Jun 2018 00:24:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSaqz-0007Y2-Vr for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 00:24:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSaqw-0002FN-0d for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 00:24:21 -0400 Original-Received: from mail-pf0-x22c.google.com ([2607:f8b0:400e:c00::22c]:43891) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSaqv-0002Ez-PP for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 00:24:17 -0400 Original-Received: by mail-pf0-x22c.google.com with SMTP id y8-v6so2327549pfm.10 for ; Mon, 11 Jun 2018 21:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=6eE+GSDzRm4spg2cvVWpwf8cqu6yzLHJkgkR43KnMQ8=; b=lOAT+/lIhJOIqGTuDtWqRyKAgc/RKStdwSDZ1YcMdv2aIgk+wq49XnA3v4ZX4pD8MP KEtljDvzeIGFgZ/Px+u86WoNZjQoDOR2RHdXsFWGMTM434QkX+nyUwUmnBECwIUqflOz 9OATJxnAUrlo+ckKVg2EFwKXxncky/n6mqCKm4IDt/UDmOy6ZYxwtUmq0h2UR2d7XsUw ErM/xcqer55O1qJb9i1smRNDRbmNuCj0SeccgKW4VkdHMmv+8SREJZfqi2pZMH2Vj0B1 JU+iNM7y6CJWwM94B2K1fkHyxT2Q8tGIerSv+Rb7mrBkKyGEV4xcNQhPuZ00qmdzsvGQ KPGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=6eE+GSDzRm4spg2cvVWpwf8cqu6yzLHJkgkR43KnMQ8=; b=EiA/Ce6pBr5itlPz94Rklr6RVtUCB1q8A0DTGcy5Yc9GaKLs+JukDPfaufy0iGu37s nfgu1tvxMszPrN02erINP2sq997TduO1go46cPDb+57dzxcQ+OKtfag0lLKgG8pfz7Hv y0EnZjvhVrMAgqiL2f9BPaeISCihEM+O9lcemSDpMLgvMvXg5UWQ44VtgFx2pEsS4Npi x+gvPHcBW8qQ/Wrm7VcgvLwmkhS4SAfIV0CWefomoGBgSL+p/1P+4698HUmvFdsq9+pR x3dDnuod3Sd7tGVBu8g6kUQPS6pwYWni9mZh6sFLua/H+VvRa57WEeAJr2fOhTUF4LWN mp+A== X-Gm-Message-State: APt69E3Q5A9iBPpZGInl6tXOMENbUUxbxfWkevu96hnFxqWFAl6igXty cV6uqpCOcjBYTpwQ+PVhYEvptg== X-Google-Smtp-Source: ADUXVKKOEGRC/3dXRSzLNxM8RQcFxERFx3OSyFsDUkoJAD+JARM++85rKNYT40ncGoYR5HGAZjfJEA== X-Received: by 2002:aa7:8298:: with SMTP id s24-v6mr2100380pfm.136.1528777456449; Mon, 11 Jun 2018 21:24:16 -0700 (PDT) Original-Received: from Zeuss-MacBook-Air.local ([119.94.238.191]) by smtp.gmail.com with ESMTPSA id d22-v6sm95346041pfk.126.2018.06.11.21.24.11 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jun 2018 21:24:15 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147315 Archived-At: 1. emacs -q 2. in dired mode press ! 3. C-h v Step 3 should give you no completion. Another issue is when icomplete-mode is on one constantly gets "No matches" for every input. This is due to the following change. commit c2a8cffe8044cc38c4cf1b5c3d1c9571ddeec623 Date: Sun Aug 6 10:15:17 2017 -0400 ; Fix previous commit The mailcap minibuffer completion used dynamic binding. Locally set a dynamic variable. * lisp/dired-aux.el: Store list of files in `minibuffer-completion-table'. I intend to fix the issue on emacs-26 with the following patch. Comments? diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index c336103f..516cd2c5 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -614,14 +614,16 @@ with a prefix argument." (declare-function mailcap-file-default-commands "mailcap" (files)) +(defvar dired-aux-files) + (defun minibuffer-default-add-dired-shell-commands () "Return a list of all commands associated with current dired files. This function is used to add all related commands retrieved by `mailcap' to the end of the list of defaults just after the default value." (interactive) - (let* ((files minibuffer-completion-table) - (commands (and (require 'mailcap nil t) - (mailcap-file-default-commands files)))) + (let ((commands (and (boundp 'dired-aux-files) + (require 'mailcap nil t) + (mailcap-file-default-commands dired-aux-files)))) (if (listp minibuffer-default) (append minibuffer-default commands) (cons minibuffer-default commands)))) @@ -639,9 +641,9 @@ This normally reads using `read-shell-command', but if the offer a smarter default choice of shell command." (minibuffer-with-setup-hook (lambda () - (set (make-local-variable 'minibuffer-completion-table) files) - (set (make-local-variable 'minibuffer-default-add-function) - 'minibuffer-default-add-dired-shell-commands)) + (setq-local dired-aux-files files) + (setq-local minibuffer-default-add-function + #'minibuffer-default-add-dired-shell-commands)) (setq prompt (format prompt (dired-mark-prompt arg files))) (if (functionp 'dired-guess-shell-command) (dired-mark-pop-up nil 'shell files