From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50777: Dropping EIEIO from xref (for performance) Date: Sat, 25 Sep 2021 16:07:40 +0200 Message-ID: References: <6b5b14d5-b2ca-8add-f4bf-a3405270c07a@yandex.ru> Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29684"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (darwin) Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 50777@debbugs.gnu.org, Stefan Monnier To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 16:08:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mU8Lc-0007WK-Ie for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 16:08:12 +0200 Original-Received: from localhost ([::1]:40520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mU8La-00058a-Jm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 10:08:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mU8LS-00057W-MJ for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 10:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50960) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mU8LS-0002xP-EZ for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 10:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mU8LR-00081O-Ta for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 10:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 14:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50777 X-GNU-PR-Package: emacs Original-Received: via spool by 50777-submit@debbugs.gnu.org id=B50777.163257887330821 (code B ref 50777); Sat, 25 Sep 2021 14:08:01 +0000 Original-Received: (at 50777) by debbugs.gnu.org; 25 Sep 2021 14:07:53 +0000 Original-Received: from localhost ([127.0.0.1]:34273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU8LJ-000813-C9 for submit@debbugs.gnu.org; Sat, 25 Sep 2021 10:07:53 -0400 Original-Received: from sonic311-30.consmr.mail.ir2.yahoo.com ([77.238.176.162]:41260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU8LH-00080n-DU for 50777@debbugs.gnu.org; Sat, 25 Sep 2021 10:07:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1632578864; bh=AIsrWaQ7IPNiN9Y+aOCcaCWs7CzSiAzjx7hMUja8rsM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=mJiW2SQmInCQwoX7u/xIzhh8BvhhaOdEgBAq2HtDTDyjDpJWgLpa1RrcKbLljyccJkh6Jn7e4gkQIgS6Mcz/v/wXDiD7o8sWknDW05qW4eYkp4Di+XxJeYGyheYMRj9L1FQm5ZZaIu1ILs5UnqCMC/B8qUMaZDwHf/fYyKshdECB9aZv7VrRqLPE1W3PtYxchYeQi9BXGcXW5Gju+I55y1LRQFO+3uBEQQgo5to4qMT7NyU6VcQ4Bf+iNVQe9kxcnk0lHRBFPA0/MaCb4CUcB+yOI1v70kLoOS5Gy5JOl6Wtm5FQpqoDp69fEwGFk9malRGest1uOZh4Fp0C1n+YtA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1632578864; bh=XanE1o09QTei8p0Sv66z1ZPcgHga6xZINiatJJCsjHx=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=hIsdWdoc/8GgQpc3Ev9ta8LHObuBy6MYZuuZEXgd62bfc74fXrXDBtMPFicRBG8bIRjRDSPo8BmpoNytX8seavFjxX/8ohMJBi2ZLRV28X7nMTbKvU6b8QRALtOzBUQ73ajoIObcUuzyiPytP/AgIjMo0h2DQZX1okqMp1vFObKh12DPKBjVY1lBxygYLYi5AR8m3IFfymrETCCDNKWcv36uKwxNrJQhRX696pm4SaT71iSF4Y5Gav0BTlLsmKvDDuJcfGJlfXHZXjhsrFf+SMXrUzWbrNKzSpw8xRESbM1g6WllUDwrKUUVXlj1U84hA6QQ9NDvUuTWJnxAyfgs3Q== X-YMail-OSG: e7LlSCsVM1mrVuBZ0ClJNOOWSPSs_yPbcC8GBc2Rp4oD9B7rlepiX.CaM1uWIG9 DSqDPYKvrw95rCFFJXyFMdav3FGiWpn0YZ6yztPb2lOrDnGI9BDPHT6FFys.5fSx1VBwH965oO5Z lQI43RqFLYmNbyBNQn_jhyRF4Vdw5LMYOP1s.N28boIHR0w9wxUCUtpUzj3nvpcoJB0wNvKWVzGE .RlntEUCCFG7xbxvwLNJWDIkhTa6LR0dWiht2YX8RJUEnOguF_qNKJtuynx9VVAoj0Yd4RkKupqx Fwv0Lrn7wswxssqMG4cr_oMM8HZgREVw7b7Xx2CY3.029fJ4noN269QLPDJPTl6mXi3jwdkQaWRG yJsWxRZLRw7wZcB85yV2N36781wJe8kwe2j0b2rEEu7q4YURwG028P2ns7buNAEehQAp8QAYwMfl Ya3PceMOnnuDGLgP7jkK9o_8GyHMU.LQDhu0uE.FiWH2T.WSNUnSGC4F19R1oKx09oYbkRgsrJkh vuNQ1aMMbHyTt_xJKhdPJodzP0C9rCFcRiByf6uo57oDeVZYKMGaCLTt_.gfkK6hpfae349TkCJH VPtaL_IJIQPjYxCbHFZbuoqMw4hLGMGPDllbUgtLqVuEFhYgpF66hTnKCf6MWK_XRSQ8Ne1vVxrS LPYPVoBpHAEyzYsSr7pmrprDR2xzE18jrUS0yWpR4312l1wyC8D5S0XpYXmk.zLAhrsP03HJ9PmD r6dBZnJzM1mKezAIuLZG8W2cbiTWdNEdXqHG7sUYkucUeHJNcFVX1JyP5D0idv_04oboLrd3XhqR Oq4q3ANrlYW.ZFdhmsnzORP0GR6tHcYq0.vQIk..l0 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Sat, 25 Sep 2021 14:07:44 +0000 Original-Received: by kubenode505.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 4df65f0bc38d17a5ee8c2ef66255811f; Sat, 25 Sep 2021 14:07:41 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Fri, 24 Sep 2021 16:37:25 +0300") X-Mailer: WebService/1.1.19043 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215445 Archived-At: Dmitry Gutov writes: > Resending with the intended recipients (except for the maintainers who > are automatically subscribed anyway, to spare the inboxes). > > With the recent discussion about our Lisp overhead when the search > returns many matches, I went a couple more rounds to try to identify > the hotspots. > > My main benchmark for that is > > (benchmark 1 '(project-find-regexp "list")) > > in the Emacs repo. The 3 recent commits have reduced that time from 8s > to 6.5s on my machine (under best conditions: warm disk cache and > fresh Emacs session). The machine is pretty fast, so I figure we can > multiply that timing by 2x, to imagine the average user experience. Thanks for working on this. I checked the patch and I also see a similar speedup in my system, working with a large monorepo. > > I'd like to push it soon, so users of Emacs 28 can enjoy the speedup. > > What do people think? I agree with Lars, it's better not to rush this change. The change is invasive and I think I was the only person to report a performance problem so far in that part of the codebase. I guess it's better to merge this just after the Emacs 28 branch is cut, so that users in a stable version are not affected by any potential bug/interface incompatibility not caught during pretest. Thanks.