From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#4308: 23.1.50; patch: fix `eshell-history-file-name' Date: Tue, 01 Sep 2009 20:32:10 +0100 Message-ID: Reply-To: Leo , 4308@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1251834441 19377 80.91.229.12 (1 Sep 2009 19:47:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Sep 2009 19:47:21 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 01 21:47:14 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MiZJx-0004JB-5M for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Sep 2009 21:47:13 +0200 Original-Received: from localhost ([127.0.0.1]:47380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MiZJw-00057d-HN for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Sep 2009 15:47:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MiZJp-000552-F3 for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2009 15:47:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MiZJk-0004vX-Fg for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2009 15:47:04 -0400 Original-Received: from [199.232.76.173] (port=41342 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MiZJk-0004vO-7A for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2009 15:47:00 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42517) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MiZJi-0001wh-RB for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2009 15:46:59 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n81JktEL004136; Tue, 1 Sep 2009 12:46:56 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n81Je6CU002643; Tue, 1 Sep 2009 12:40:06 -0700 Resent-Date: Tue, 1 Sep 2009 12:40:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Tue, 01 Sep 2009 19:40:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 4308 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12518337461880 (code B ref -1); Tue, 01 Sep 2009 19:40:05 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 1 Sep 2009 19:35:46 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n81JZiYO001874 for ; Tue, 1 Sep 2009 12:35:46 -0700 Original-Received: from mail.gnu.org ([199.232.76.166]:39032 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MiZ8q-0003KD-3h for emacs-pretest-bug@gnu.org; Tue, 01 Sep 2009 15:35:44 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MiZ5U-0007ph-8Z for emacs-pretest-bug@gnu.org; Tue, 01 Sep 2009 15:32:19 -0400 Original-Received: from ppsw-1.csi.cam.ac.uk ([131.111.8.131]:42519) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MiZ5T-0007pP-Tx for emacs-pretest-bug@gnu.org; Tue, 01 Sep 2009 15:32:16 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Original-Received: from sl392.st-edmunds.cam.ac.uk ([131.111.223.202]:49463 helo=victoria.local) by ppsw-1.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.151]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MiZ5S-0002gX-3j (Exim 4.70) for emacs-pretest-bug@gnu.org (return-path ); Tue, 01 Sep 2009 20:32:14 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (darwin) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Tue, 01 Sep 2009 15:47:04 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30712 gmane.emacs.pretest.bugs:24995 Archived-At: Please describe exactly what actions triggered the bug and the precise symptoms of the bug: The attached small patch makes eshell-history-file-name more robust. For example, I accidentally set eshell-directory-name to ~/.emacs.d/shell without a trailing / and the history was written to ~/.emacs.d/shellhistory. diff -u -L a/em-hist.el.gz -L b/em-hist.el.gz --- a/em-hist.el.gz +++ b/em-hist.el.gz @@ -86,7 +86,7 @@ :group 'eshell-hist) (defcustom eshell-history-file-name - (concat eshell-directory-name "history") + (expand-file-name "history" eshell-directory-name) "*If non-nil, name of the file to read/write input history. See also `eshell-read-history' and `eshell-write-history'. If it is nil, Eshell will use the value of HISTFILE." Diff finished. Tue Sep 1 20:27:29 2009 Leo