From: Leo <sdl.web@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: bug#4308: 23.1.50; patch: fix `eshell-history-file-name'
Date: Tue, 01 Sep 2009 20:32:10 +0100 [thread overview]
Message-ID: <m0ws4iihqd.fsf@cam.ac.uk> (raw)
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:
The attached small patch makes eshell-history-file-name more robust. For
example, I accidentally set eshell-directory-name to ~/.emacs.d/shell
without a trailing / and the history was written to
~/.emacs.d/shellhistory.
diff -u -L a/em-hist.el.gz -L b/em-hist.el.gz
--- a/em-hist.el.gz
+++ b/em-hist.el.gz
@@ -86,7 +86,7 @@
:group 'eshell-hist)
(defcustom eshell-history-file-name
- (concat eshell-directory-name "history")
+ (expand-file-name "history" eshell-directory-name)
"*If non-nil, name of the file to read/write input history.
See also `eshell-read-history' and `eshell-write-history'.
If it is nil, Eshell will use the value of HISTFILE."
Diff finished. Tue Sep 1 20:27:29 2009
Leo
next reply other threads:[~2009-09-01 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87pr9vbnao.fsf@cyd.mit.edu>
2009-09-01 19:32 ` Leo [this message]
2009-09-01 19:49 ` bug#4308: 23.1.50; patch: fix `eshell-history-file-name' Leo
2009-09-13 2:25 ` bug#4308: marked as done (23.1.50; patch: fix `eshell-history-file-name') Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m0ws4iihqd.fsf@cam.ac.uk \
--to=sdl.web@gmail.com \
--cc=4308@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.