bug#9499: 24.0.50; M-x occur + M-x next-error window config problem

bug#9499: 24.0.50; M-x occur + M-x next-error window config problem

[Stefan Reichör]

This bug report will be sent to the Bug-GNU-Emacs mailing list
and the GNU bug tracker at debbugs.gnu.org.  Please check that
the From: line contains a valid email address.  After a delay of up
to one day, you should receive an acknowledgement at that address.

Please write in English if possible, as the Emacs maintainers
usually do not have translators for other languages.

Please describe exactly what actions triggered the bug, and
the precise symptoms of the bug.  If you can, give a recipe
starting from `emacs -Q':

Start emacs, switch to the *scratch* buffer
M-x occur RET
th RET
M-x next-error

The *Occur* buffer is replaced by another view of the *scratch* buffer
I expect the *Occur* buffer to stay


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
c:/emacs/etc/DEBUG.


In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-09-12 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: DEU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
f <up> <up> <up> <up> <up> C-x b <return> M-x o c c 
u r <return> t h <return> M-x n e x t - e r <tab> <return> 
M-x <up> <return> M-x r e p o r t <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
byte-code: Beginning of buffer
Searched 1 buffer; 3 matches for `th'
You can run the command `occur' with M-s o
You can run the command `next-error' with C-x ` [2 times]

Load-path shadows:
c:/emacs/site-lisp/htmlfontify hides c:/emacs/lisp/htmlfontify
c:/emacs/site-lisp/verilog-mode hides c:/emacs/lisp/progmodes/verilog-mode

Features:
(shadow sort gnus-util mail-extr message format-spec rfc822 mml easymenu
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader
emacsbug tex-site time-date tooltip ediff-hook vc-hooks lisp-float-type
mwheel dos-w32 disp-table ls-lisp w32-win w32-vars tool-bar dnd fontset
image fringe lisp-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev minibuffer button faces cus-face files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process multi-tty emacs)

bug#9499: 24.0.50; M-x occur + M-x next-error window config problem

[martin rudalics]

 > Start emacs, switch to the *scratch* buffer
 > M-x occur RET
 > th RET
 > M-x next-error
 >
 > The *Occur* buffer is replaced by another view of the *scratch* buffer
 > I expect the *Occur* buffer to stay

It's because

     (pop-to-buffer (marker-buffer pos) t)

in `occur-mode-goto-occurrence' has problems reusing the *scratch*
window.  More precisely, because the *scratch* window is selected and
the second argument t means to not use the selected window.

If Chong doesn't come up with an easy fix I'll look into it.

martin

bug#9499: 24.0.50; M-x occur + M-x next-error window config problem

[Chong Yidong]

martin rudalics <rudalics@gmx.at> writes:

>> Start emacs, switch to the *scratch* buffer
>> M-x occur RET
>> th RET
>> M-x next-error
>>
>> The *Occur* buffer is replaced by another view of the *scratch* buffer
>> I expect the *Occur* buffer to stay
>
> It's because
>
>     (pop-to-buffer (marker-buffer pos) t)
>
> in `occur-mode-goto-occurrence' has problems reusing the *scratch*
> window.  More precisely, because the *scratch* window is selected and
> the second argument t means to not use the selected window.

Sorry, this was my mistake.  The second arg should not be t in here.
Fixed in trunk.