git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Sam Steingold]

Hi,
With the fresh Emacs from yesterday, I get

Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil)

in the Echo Area and *Messages* on every move in an Org-mode buffer.

I don't know how to debug it (I tried stepping through
`flyspell-post-command-hook' and got nothing), so I wonder if someone
sees anything like that.

Thank you.

PS. The trivial sequence of

emacs -Q
C-x b foo RET
M-x org-mode RET
M-x winner-mode RET
M-x flyspell-mode RET
foo bar baz

does not, alas, produce the described behavior...

-- 
Sam Steingold (https://aphar.dreamwidth.org/) on darwin Ns 10.3.2113
https://lastingimpactpsychology.com https://steingoldpsychology.com
https://ffii.org https://memri.org https://iris.org.il
cogito cogito ergo cogito sum

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Eli Zaretskii]

> From: Sam Steingold <sds@gnu.org>
> Date: Tue, 06 Sep 2022 15:47:23 -0400
> 
> Hi,
> With the fresh Emacs from yesterday, I get
> 
> Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil)
> 
> in the Echo Area and *Messages* on every move in an Org-mode buffer.
> 
> I don't know how to debug it (I tried stepping through
> `flyspell-post-command-hook' and got nothing), so I wonder if someone
> sees anything like that.
> 
> Thank you.
> 
> PS. The trivial sequence of
> 
> emacs -Q
> C-x b foo RET
> M-x org-mode RET
> M-x winner-mode RET
> M-x flyspell-mode RET
> foo bar baz
> 
> does not, alas, produce the described behavior...

So what _is_ the recipe to reproduce it?

(And why didn't you report it using "M-x report-emacs-bug"?)

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Sam Steingold]

> * Eli Zaretskii <ryvm@tah.bet> [2022-09-07 05:27:15 +0300]:
>
>> From: Sam Steingold <sds@gnu.org>
>> Date: Tue, 06 Sep 2022 15:47:23 -0400
>> 
>> Hi,
>> With the fresh Emacs from yesterday, I get
>> 
>> Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil)
>> 
>> in the Echo Area and *Messages* on every move in an Org-mode buffer.
>> 
>> I don't know how to debug it (I tried stepping through
>> `flyspell-post-command-hook' and got nothing), so I wonder if someone
>> sees anything like that.
>> 
>> Thank you.
>> 
>> PS. The trivial sequence of
>> 
>> emacs -Q
>> C-x b foo RET
>> M-x org-mode RET
>> M-x winner-mode RET
>> M-x flyspell-mode RET
>> foo bar baz
>> 
>> does not, alas, produce the described behavior...
>
> So what _is_ the recipe to reproduce it?

I cannot reproduce it without my huge .emacs

> (And why didn't you report it using "M-x report-emacs-bug"?)

Because I do not have a "minimal reproducible example".
I hoped that someone has seen these symptoms and I don't have to worry.


-- 
Sam Steingold (https://aphar.dreamwidth.org/) on darwin Ns 10.3.2113
https://lastingimpactpsychology.com https://steingoldpsychology.com
https://jihadwatch.org https://fairforall.org https://iris.org.il
Lottery is a tax on statistics ignorants.  MS is a tax on computer-idiots.

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Eli Zaretskii]

> From: Sam Steingold <sds@gnu.org>
> Date: Wed, 07 Sep 2022 11:26:29 -0400
> 
> > * Eli Zaretskii <ryvm@tah.bet> [2022-09-07 05:27:15 +0300]:
> >
> >> From: Sam Steingold <sds@gnu.org>
> >> Date: Tue, 06 Sep 2022 15:47:23 -0400
> >> 
> >> Hi,
> >> With the fresh Emacs from yesterday, I get
> >> 
> >> Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil)
> >> 
> >> in the Echo Area and *Messages* on every move in an Org-mode buffer.
> >> 
> >> I don't know how to debug it (I tried stepping through
> >> `flyspell-post-command-hook' and got nothing), so I wonder if someone
> >> sees anything like that.
> >> 
> >> Thank you.
> >> 
> >> PS. The trivial sequence of
> >> 
> >> emacs -Q
> >> C-x b foo RET
> >> M-x org-mode RET
> >> M-x winner-mode RET
> >> M-x flyspell-mode RET
> >> foo bar baz
> >> 
> >> does not, alas, produce the described behavior...
> >
> > So what _is_ the recipe to reproduce it?
> 
> I cannot reproduce it without my huge .emacs

Then I guess you will have to debug this on your system.

One way of doing that is to attach a debugger and put a breakpoint in
wrong_type_argument.  When it breaks, collect both C and Lisp
backtraces, and post them.

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Stefan Monnier]

>> >> Error in winner-save-old-configurations (flyspell-post-command-hook):
>> >> (wrong-type-argument stringp nil)
[...]
> Then I guess you will have to debug this on your system.
>
> One way of doing that is to attach a debugger and put a breakpoint in
> wrong_type_argument.  When it breaks, collect both C and Lisp
> backtraces, and post them.

If you're lucky, the problem will also show up when you simply run
`winner-save-old-configurations` by hand, with

    M-: (winner-save-old-configurations) RET


-- Stefan

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Jose A Ortega Ruiz]

On Wed, Sep 07 2022, Stefan Monnier wrote:

>>> >> Error in winner-save-old-configurations (flyspell-post-command-hook):
>>> >> (wrong-type-argument stringp nil)
> [...]
>> Then I guess you will have to debug this on your system.
>>
>> One way of doing that is to attach a debugger and put a breakpoint in
>> wrong_type_argument.  When it breaks, collect both C and Lisp
>> backtraces, and post them.
>
> If you're lucky, the problem will also show up when you simply run
> `winner-save-old-configurations` by hand, with
>
>     M-: (winner-save-old-configurations) RET

it doesn't for me.  another clue might be that i see this error not for
nil, but for what looks like a key events sequence, e.g.

    Error in winner-save-old-configurations (transient--post-command-hook): (wrong-type-argument stringp [3 67108896])

and once i see it, if i keep pressing non-printable keys (like e.g. up
or down), the error keeps repeating.


jao
-- 
We live on an island surrounded by a sea of ignorance. As our island
of knowledge grows, so does the shore of our ignorance. - John Wheeler

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Jose A Ortega Ruiz]

On Wed, Sep 07 2022, Sam Steingold wrote:

[...]

> Because I do not have a "minimal reproducible example".
> I hoped that someone has seen these symptoms and I don't have to worry.

fwiw, since a week ago or so, it happens to me all the time, but with
transient--post-command-hook instead of flyspell-post-command-hook.
unfortunately, as in your case, i don't have a recipe from emacs -Q,
after a few hours trying to reproduce it unsuccessfully.

cheers,
jao
-- 
How many Zen Buddhist does it take to change a light bulb?
Two. One to change it and one not to change it.

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Juri Linkov]

> With the fresh Emacs from yesterday, I get
>
> Error in winner-save-old-configurations (flyspell-post-command-hook):
> (wrong-type-argument stringp nil)

Coincidentally, this is the same error as raised in
https://debbugs.gnu.org/56791#27

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Stefan Monnier]

Sam Steingold [2022-09-06 15:47:23] wrote:
> Error in winner-save-old-configurations (flyspell-post-command-hook):
> (wrong-type-argument stringp nil)

Hmm... actually, this is a good clue: in this error message the part
after "in" should be the hook's name.

So I suspect the problem comes from my
commit 5cae71834bd55e0bf90689b12b801206ee8c9da9.

More specifically, I suspect that the (hideous) patch below might fix
your problem.  Could you confirm (so I can find a better fix)?


        Stefan


diff --git a/src/keyboard.c b/src/keyboard.c
index 77280d08c5b..6b4253b7256 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -1887,6 +1887,7 @@ safe_run_hook_funcall (ptrdiff_t nargs, Lisp_Object *args)
   args[0] = hook, args[1] = fun;
   internal_condition_case_n (safe_run_hooks_1, nargs, args,
                              Qt, safe_run_hooks_error);
+  args[0] = fun, args[1] = hook;
   return Qnil;
 }
 

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Sam Steingold]

> * Stefan Monnier <zbaavre@veb.hzbagerny.pn> [2022-09-07 14:00:04 -0400]:
>
> Sam Steingold [2022-09-06 15:47:23] wrote:
>> Error in winner-save-old-configurations (flyspell-post-command-hook):
>> (wrong-type-argument stringp nil)
>
> Hmm... actually, this is a good clue: in this error message the part
> after "in" should be the hook's name.
>
> So I suspect the problem comes from my
> commit 5cae71834bd55e0bf90689b12b801206ee8c9da9.
>
> More specifically, I suspect that the (hideous) patch below might fix
> your problem.  Could you confirm (so I can find a better fix)?

It does appear to fix the problem, yes.
Thank you!


-- 
Sam Steingold (https://aphar.dreamwidth.org/) on darwin Ns 10.3.2113
https://lastingimpactpsychology.com https://steingoldpsychology.com
https://ffii.org http://think-israel.org https://fairforall.org https://jij.org
Why use Windows, when there are Doors?

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Jose A Ortega Ruiz]

On Wed, Sep 07 2022, Stefan Monnier wrote:

> Sam Steingold [2022-09-06 15:47:23] wrote:
>> Error in winner-save-old-configurations (flyspell-post-command-hook):
>> (wrong-type-argument stringp nil)
>
> Hmm... actually, this is a good clue: in this error message the part
> after "in" should be the hook's name.
>
> So I suspect the problem comes from my
> commit 5cae71834bd55e0bf90689b12b801206ee8c9da9.
>
> More specifically, I suspect that the (hideous) patch below might fix
> your problem.  Could you confirm (so I can find a better fix)?
>
>
>         Stefan
>
>
> diff --git a/src/keyboard.c b/src/keyboard.c
> index 77280d08c5b..6b4253b7256 100644
> --- a/src/keyboard.c
> +++ b/src/keyboard.c
> @@ -1887,6 +1887,7 @@ safe_run_hook_funcall (ptrdiff_t nargs, Lisp_Object *args)
>    args[0] = hook, args[1] = fun;
>    internal_condition_case_n (safe_run_hooks_1, nargs, args,
>                               Qt, safe_run_hooks_error);
> +  args[0] = fun, args[1] = hook;
>    return Qnil;
>  }

this also seems to be solving the problem for me, thanks!

jao
-- 
Nothing so soothes our vanity as a display of greater vanity in
others; it makes us vain, in fact, of our modesty.
  -Louis Kronenberger, writer (1904-1980)

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Jose A Ortega Ruiz]

On Wed, Sep 07 2022, Jose A Ortega Ruiz wrote:

> On Wed, Sep 07 2022, Stefan Monnier wrote:
>
>> Sam Steingold [2022-09-06 15:47:23] wrote:
>>> Error in winner-save-old-configurations (flyspell-post-command-hook):
>>> (wrong-type-argument stringp nil)
>>
>> Hmm... actually, this is a good clue: in this error message the part
>> after "in" should be the hook's name.
>>
>> So I suspect the problem comes from my
>> commit 5cae71834bd55e0bf90689b12b801206ee8c9da9.
>>
>> More specifically, I suspect that the (hideous) patch below might fix
>> your problem.  Could you confirm (so I can find a better fix)?
>>
>>
>>         Stefan
>>
>>
>> diff --git a/src/keyboard.c b/src/keyboard.c
>> index 77280d08c5b..6b4253b7256 100644
>> --- a/src/keyboard.c
>> +++ b/src/keyboard.c
>> @@ -1887,6 +1887,7 @@ safe_run_hook_funcall (ptrdiff_t nargs, Lisp_Object *args)
>>    args[0] = hook, args[1] = fun;
>>    internal_condition_case_n (safe_run_hooks_1, nargs, args,
>>                               Qt, safe_run_hooks_error);
>> +  args[0] = fun, args[1] = hook;
>>    return Qnil;
>>  }
>
> this also seems to be solving the problem for me, thanks!

sorry, i spoke too quickly.  i still see the problem with this patch
applied.  it often happens when i press C-SPC, which eventually switchs
to a different frame in a terminal window, and then, upon landing there,
i see messages like

  Error in winner-save-old-configurations (transient--post-command-hook): (wrong-type-argument stringp [3 67108896]) [3 times]

i can get the 3 times thing by keeping pressing C-SPC (which in my
binding just stays in the same frame and does nothing).  turning on
debug on error has no effect, and transient--post-command-hook happens
too often to put a break there.

hope this helps a bit,
jao
-- 
Inglish iz issenshali a langwidje dhat, wen rittun fonetkli, iz
ilejibul tu netiv spikerz.
 -Peter Bleackley

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Jose A Ortega Ruiz]

On Wed, Sep 07 2022, Jose A Ortega Ruiz wrote:


[...]

> sorry, i spoke too quickly.  i still see the problem with this patch
> applied.

please, ignore all i said in this email.  i was testing with the wrong
emacs... too many emacsen installed for my little brain to cope :(

i'll report back after checking with a good one.  sorry for the noise.

jao

Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]

[Stefan Monnier]

Stefan Monnier [2022-09-07 14:00:04] wrote:
> Sam Steingold [2022-09-06 15:47:23] wrote:
>> Error in winner-save-old-configurations (flyspell-post-command-hook):
>> (wrong-type-argument stringp nil)
>
> Hmm... actually, this is a good clue: in this error message the part
> after "in" should be the hook's name.
>
> So I suspect the problem comes from my
> commit 5cae71834bd55e0bf90689b12b801206ee8c9da9.
>
> More specifically, I suspect that the (hideous) patch below might fix
> your problem.  Could you confirm (so I can find a better fix)?

I pushed a fix to `main` which I hope is less brittle than my quick
hack, but somehow it seems that code is simply not run in the test suite
nor in my "simple interactive use test" (as evidenced by the fact that
it worked fine despite having swapped the args to `memcpy).

So if someone has a way to reproduce the problem it would be a great
addition to our test suite.


        Stefan