From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: master f52dcfd03a: New command `gnus-summary-browse-all-urls' bound to "v" Date: Tue, 15 Mar 2022 11:26:56 -0400 Organization: disorganization Message-ID: References: <164727172121.17436.14797611985358127835@vcs2.savannah.gnu.org> <20220314152841.8DC85C06305@vcs2.savannah.gnu.org> <87ilsfwiln.fsf@gnus.org> Reply-To: sds@gnu.org Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21353"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) To: emacs-devel@gnu.org Cancel-Lock: sha1:dgjxARr1Qeld5cLak3E7BAs3340= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 15 16:28:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nU96O-0005KU-8Z for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Mar 2022 16:28:48 +0100 Original-Received: from localhost ([::1]:34134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nU96M-0007Mf-Sg for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Mar 2022 11:28:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU94l-00064C-ME for emacs-devel@gnu.org; Tue, 15 Mar 2022 11:27:07 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:46112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU94j-0000Wt-Tb for emacs-devel@gnu.org; Tue, 15 Mar 2022 11:27:07 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nU94h-0002m8-Uq for emacs-devel@gnu.org; Tue, 15 Mar 2022 16:27:03 +0100 X-Injected-Via-Gmane: http://gmane.org/ X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287194 Archived-At: > * Lars Ingebrigtsen [2022-03-15 12:39:00 +0100]: > > Sam Steingold writes: > >> branch: master >> commit f52dcfd03ad542704d9a43faab0c33be09ab442e >> Author: Sam Steingold >> Commit: Sam Steingold >> >> New command `gnus-summary-browse-all-urls' bound to "v" >> >> * lisp/gnus-sum.el (gnus-collect-urls-from-article): New function, >> extracted from `gnus-summary-browse-url'. >> (gnus-summary-browse-url): Use it; also use `browse-url-button-open-url' >> to handle the prefix argument. >> (gnus-summary-browse-all-urls): New command. >> (gnus-summary-mode-map): Bind `gnus-summary-browse-all-urls' to "v". > > I've reverted this patch -- I did not agree that this command should be > added, so you should not have pushed it, Sam. Sorry about the misunderstanding. > To reiterate -- I don't think this command sounds generally useful, and > furthermore, if it is, it should not be bound to such a convenient key May I at least keep `gnus-collect-urls-from-article'? > like `v', and moreover, the funky calling conventions of > `browse-url-button-open-url' should be avoided. Well, I suppose you will add a deprecation decoration to the function. -- Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2113 http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com https://www.memritv.org https://memri.org https://jij.org Your mouse has moved - WinNT has to be restarted for this to take effect.