From: Sam Steingold <sds@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: Refactoring flymake.el
Date: Fri, 18 Aug 2017 13:59:26 -0400 [thread overview]
Message-ID: <lzfucoycxt.fsf@gnu.org> (raw)
In-Reply-To: 6b4255cf-76c8-c6f3-15e4-b8fc97d4d2d2@yandex.ru
> * Dmitry Gutov <qthgbi@lnaqrk.eh> [2017-08-18 19:25:16 +0300]:
>
>>> Only if such variable is not safe. If it's a boolean, for instance,
>>> adding ":safe 'booleanp" to its defcustom should be easy.
>>
>> Of course. However, this variable is defined by a local
>> `define-minor-mode', not `defcustom'.
>
> You can also mark it safe using `put' later. Like:
>
> (put 'abbrev-mode 'safe-local-variable 'booleanp)
Yes, but this _is_ a security issue.
flymake-mode actually _may_ run an OS command.
I think it would be safe to _disable_ the mode, e.g.,
(put 'flymake-mode 'safe-local-variable 'null)
Objections?
PS. Do people really hate the `flymake-disallowed-file-name-regexp' patch?
Why?
--
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1504
http://steingoldpsychology.com http://www.childpsy.net http://think-israel.org
http://americancensorship.org https://jihadwatch.org
Please express your antipathy in the suicidal form.
next prev parent reply other threads:[~2017-08-18 17:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 14:40 Refactoring flymake.el João Távora
2017-08-17 16:57 ` John Wiegley
2017-08-17 18:08 ` Sam Steingold
2017-08-17 22:32 ` Stefan Monnier
2017-08-18 14:51 ` Sam Steingold
2017-08-18 15:11 ` Dmitry Gutov
2017-08-18 16:13 ` Sam Steingold
2017-08-18 16:25 ` Dmitry Gutov
2017-08-18 17:59 ` Sam Steingold [this message]
2017-08-18 18:52 ` Noam Postavsky
2017-08-18 19:38 ` Sam Steingold
2017-08-18 16:26 ` Clément Pit-Claudel
2017-08-18 20:32 ` Stefan Monnier
2017-08-18 13:04 ` Dmitry Gutov
2017-08-18 19:20 ` João Távora
2017-08-19 1:59 ` Leo Liu
2017-08-21 12:50 ` Refactoring flymake.el - jumped the gun João Távora
2017-08-23 3:30 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lzfucoycxt.fsf@gnu.org \
--to=sds@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.