all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Sam Steingold <sds@gnu.org>
To: emacs-devel@gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: master 70341cab3e: string-equal-ignore-case: new function
Date: Tue, 26 Jul 2022 14:21:07 -0400	[thread overview]
Message-ID: <lzczdr20rw.fsf@3c22fb11fdab.ant.amazon.com> (raw)
In-Reply-To: <8735en21u9.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 26 Jul 2022 19:58:06 +0200")

> * Lars Ingebrigtsen <ynefv@tahf.bet> [2022-07-26 19:58:06 +0200]:
>
> Sam Steingold <sds@gnu.org> writes:
>
>> -;; case-insensitive case, but it has to cope with null args.
>> -;; (`string-equal' uses symbol print names.)
>> -(defun gnus-string-equal (x y)
>> -  "Like `string-equal', except it compares case-insensitively."
>> -  (and (= (length x) (length y))
>> -       (or (string-equal x y)
>> -	   (string-equal (downcase x) (downcase y)))))
>
> We don't remove non-internal functions like this (because they may be
> used by third parties).  Instead make it obsolete.

fixed, thanks.

>> -	      (when (gnus-string-equal
>> +	      (when (string-equal-ignore-case
>>  		     (message-fetch-field "followup-to")
>>  		     (message-fetch-field "newsgroups"))
>
> And the arguments here may be nil, which will signal an error.

I thought I checked all uses of `gnus-string-equal', sorry...

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2113
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://mideasttruth.com https://camera.org http://think-israel.org
char*a="char*a=%c%s%c;main(){printf(a,34,a,34);}";main(){printf(a,34,a,34);}



  reply	other threads:[~2022-07-26 18:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165885780615.5477.9618918327695992186@vcs2.savannah.gnu.org>
     [not found] ` <20220726175007.02EE9C00095@vcs2.savannah.gnu.org>
2022-07-26 17:58   ` master 70341cab3e: string-equal-ignore-case: new function Lars Ingebrigtsen
2022-07-26 18:21     ` Sam Steingold [this message]
2022-07-26 19:00   ` Roland Winkler
2022-07-26 19:44     ` Sam Steingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lzczdr20rw.fsf@3c22fb11fdab.ant.amazon.com \
    --to=sds@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.