From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: master 70341cab3e: string-equal-ignore-case: new function Date: Tue, 26 Jul 2022 15:44:48 -0400 Message-ID: References: <165885780615.5477.9618918327695992186@vcs2.savannah.gnu.org> <20220726175007.02EE9C00095@vcs2.savannah.gnu.org> <87wnbz1yxm.fsf@gnu.org> Reply-To: sds@gnu.org Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34446"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) To: emacs-devel@gnu.org, Roland Winkler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 26 21:52:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGQbP-0008mL-A4 for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Jul 2022 21:52:23 +0200 Original-Received: from localhost ([::1]:44866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGQbN-0003yK-Up for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Jul 2022 15:52:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGQUB-0004eu-0A for emacs-devel@gnu.org; Tue, 26 Jul 2022 15:44:55 -0400 Original-Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]:43763) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGQU7-0005R5-PL; Tue, 26 Jul 2022 15:44:53 -0400 Original-Received: by mail-qt1-x836.google.com with SMTP id a9so11229888qtw.10; Tue, 26 Jul 2022 12:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:subject:in-reply-to:references:user-agent :return-receipt-to:reply-to:mail-followup-to:date:message-id :mime-version; bh=56ghgBb846MQ0Qr7qY1a4F34oUiR9knKRjVqvwjiRxI=; b=Li19hJhWzrxC4HBmIQK2/QhP+9MDx57JxWKuIyZEecZj0AMgSAZHuKXEElXHVRxJtG yRTjXbnlBI55UQKBi0LyR0cwneVq5zPCEIBIJrIZAaT5dQXCODM1NotWd952F2LFZyuN 31taNdF+Z2N0U7sta4b3iGpGx097FfZLyyzeIcvQi89jvVqVuige/V27HQQOMhJVuzT8 ZRoFPn+zhjtK03hx42p9RMVYPSB3Xl23qay4Z+mer5loeM1V3TipXDy5Cl5bd8gaqHRA 77sVEhlJF16wovL//NJX3N7UuUtBDUktqUy0vm05BJcmUWDooJQUnmxN9F90AOeTmvQ4 KvlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:subject:in-reply-to:references :user-agent:return-receipt-to:reply-to:mail-followup-to:date :message-id:mime-version; bh=56ghgBb846MQ0Qr7qY1a4F34oUiR9knKRjVqvwjiRxI=; b=QSGV+lml/7E5wFHzSh7M0QUUaBqxqnrTM0YXA36qd1MsZ9SQgm+ZdxGy+CYXmvf4UT CjI1kqa32i+HUD69M2Lzv9Xd97Ky5ftBFr/VJh5rjmWaFoUtI7nI5Fpb7Ko++e25LxhM +m17eVzczwYeJWcle+PAJouGUpoMQZmZvZZAnF454p0U09uPEVGXGFZ4QeVqJoa11ORQ FBU/Y8GsGL+9yXrBlOBESX61ndPhC0+0StdNn2e4TXsw2dmdQFtIvR/OHBO/CW5wW2l8 gU57UNHA1ZI4kEuTlPrqFplBqZ73jt/0ujfp/f3g9n02pHNLsDUi7rOMscFxFMNAiItu n+AQ== X-Gm-Message-State: AJIora+/UMciZt7+tUIbIX95yOiTjbm6Ipvc7FMfOEEQvIEC+iJXVWEE jSxyqMN995wi2YJ7V0jGKCcGCxxXUg== X-Google-Smtp-Source: AGRyM1tfqx4KOEnyd3pdYCJMhDkBdGztm0Wkh2VTUdcRb9uIeM+ajD/5Ksw0F7I47b4n925ZCwYD6g== X-Received: by 2002:ac8:4e93:0:b0:31e:e203:83ae with SMTP id 19-20020ac84e93000000b0031ee20383aemr16194826qtp.85.1658864689694; Tue, 26 Jul 2022 12:44:49 -0700 (PDT) Original-Received: from 3c22fb11fdab.ant.amazon.com (pool-108-30-23-113.nycmny.fios.verizon.net. [108.30.23.113]) by smtp.gmail.com with ESMTPSA id d17-20020a05620a137100b006b5fe1c376fsm11312872qkl.131.2022.07.26.12.44.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Jul 2022 12:44:49 -0700 (PDT) In-Reply-To: <87wnbz1yxm.fsf@gnu.org> (Roland Winkler's message of "Tue, 26 Jul 2022 14:00:53 -0500") X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Mail-Followup-To: emacs-devel@gnu.org, Roland Winkler Received-SPF: pass client-ip=2607:f8b0:4864:20::836; envelope-from=sam.steingold@gmail.com; helo=mail-qt1-x836.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292716 Archived-At: > * Roland Winkler [2022-07-26 14:00:53 -0500]: > > On Tue, Jul 26 2022, Sam Steingold wrote: >> +(defun string-equal-ignore-case (string1 string2) >> + "Like `string-equal', but case-insensitive. >> +Upper-case and lower-case letters are treated as equal. >> +Unibyte strings are converted to multibyte for comparison." >> + (eq t (compare-strings string1 0 nil string2 0 nil t))) > > Isn't this a perfect candidate for an inline function, > i.e., defsubst instead of defun? Probably... I can probably add more declarations... -- Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2113 http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com https://www.peaceandtolerance.org/ https://camera.org Whether pronounced "leenooks" or "line-uks", it's better than Windows.