From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Howard Melman Newsgroups: gmane.emacs.bugs Subject: bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems Date: Wed, 18 Sep 2024 23:52:08 -0400 Message-ID: References: <87le083m1s.fsf@ledu-giraud.fr> <877cbqjt03.fsf@posteo.net> <87h6auw6sj.fsf@ledu-giraud.fr> <86y1462o7u.fsf@gnu.org> <875xraw4l3.fsf@posteo.net> <86mskmuk75.fsf@mail.linkov.net> <87ikv9usox.fsf@ledu-giraud.fr> <861q1miskk.fsf@gnu.org> <86ikusq508.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2802"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 73004@debbugs.gnu.org Cancel-Lock: sha1:0hvZvL415knCqqXgFJVALcqUgCE= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 19 05:52:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sr8Dv-0000ab-5Y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Sep 2024 05:52:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sr8Dn-0000bC-R4; Wed, 18 Sep 2024 23:52:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr8Dl-0000aa-JP for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2024 23:52:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sr8Dl-0001Vy-9m for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2024 23:52:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Mime-Version:References:Date:From:To:In-Reply-To:Subject; bh=gId2OsTW/3xtK9fIuCwJI6hJQwNNb9lhIsrBKBOFfrI=; b=BKrQ1b7FkN57LwItEbsxJfG2JpVfV6/dA1xbnJPF6R/ec7ZBwZqZmSnukoVvJuS12FLhlTNd6b0u6D63oCkAXsIm7vAdATr1yBQDAjptggPkb2JPqWZO6JWxjjciBfvAEiMg5aT/bCVsQCxtyb1IAOwzYj7DKSCbEQUmeYMFm0mijahODR0Umg235OORvYcFY8Xe2UEoZUAqQDWUCCFfwDhTUCoDjGUPI9OXVyTjlcpcdM14grVKH8kP8dl/vTraDG7YfgHYPWHRGy06dw37ObV28puPfNzVLSYVKVBWZ01WUnNIv4rthv+G0ouCfU/OmTdr/e9C56usKe1MYHvd/g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sr8E1-0000qu-Os for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2024 23:53:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87le083m1s.fsf@ledu-giraud.fr> Resent-From: Howard Melman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Sep 2024 03:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73004 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17267179583243 (code B ref -1); Thu, 19 Sep 2024 03:53:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Sep 2024 03:52:38 +0000 Original-Received: from localhost ([127.0.0.1]:59558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sr8Dd-0000qF-TK for submit@debbugs.gnu.org; Wed, 18 Sep 2024 23:52:38 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:35338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sr8Dc-0000q7-4F for submit@debbugs.gnu.org; Wed, 18 Sep 2024 23:52:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr8DK-0000Yq-Tj for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2024 23:52:18 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr8DJ-0001VS-MK for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2024 23:52:18 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1sr8DG-000AcK-LD for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2024 05:52:14 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 3 X-Spam_score: 0.3 X-Spam_bar: / X-Spam_report: (0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292023 Archived-At: Juri Linkov writes: >>> > The current implementation is based on long >>> > discussions including bug#18132. So everyone is >>> > welcome to improve it, it's not cast in stone. >>> >>> Thanks for the pointer. I'm proposing the following patch then. >> >> Juri, is this change okay with you? > > Yes, this looks right, so now pushed to master. > Thanks Manuel for the patch. Forgive the micro-optimization, but do you have to check the os for each and every file in files? -- Howard