bug#63563: 29.0.91; package.el should not install unselected packages

bug#63563: 29.0.91; package.el should not install unselected packages

[Jimmy Yuen Ho Wong]

Reproduction:

1. M-x list-packages
2. Press x on a line
3. Observer in the echo area package.el is now asking the user to
whether to install the package.

Expectation:

If the user has not pressed i to select the package for installation,
package.el should not ask the user to confirm anything. There's no
action to execute. This is unexpected dwim behavior.

bug#63563: 29.0.91; package.el should not install unselected packages

[Eli Zaretskii]

tags 63563 notabug
thanks

> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
> Date: Thu, 18 May 2023 03:10:23 +0100
> 
> 1. M-x list-packages
> 2. Press x on a line
> 3. Observer in the echo area package.el is now asking the user to
> whether to install the package.
> 
> Expectation:
> 
> If the user has not pressed i to select the package for installation,
> package.el should not ask the user to confirm anything. There's no
> action to execute. This is unexpected dwim behavior.

From the Emacs manual:

  ‘x’
       Download and install all packages marked with ‘i’, and their
       dependencies; also, delete all packages marked with ‘d’
       (‘package-menu-execute’).  This also removes the marks.  If no
       packages are marked, this command will install the package under
       point (if it isn’t installed already), or delete the package under
       point (if it’s already installed).

The doc string says similar stuff:

  If no packages are marked, the action taken depends on the state
  of the package under point.  If it’s not already installed, this
  command will install the package, and if it’s installed, it will
  delete the package.

So this is documented behavior.  This is not a bug, but a feature.

bug#63563: 29.0.91; package.el should not install unselected packages

[Philip Kaludercic]

Eli Zaretskii <eliz@gnu.org> writes:

> tags 63563 notabug
> thanks
>
>> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
>> Date: Thu, 18 May 2023 03:10:23 +0100
>> 
>> 1. M-x list-packages
>> 2. Press x on a line
>> 3. Observer in the echo area package.el is now asking the user to
>> whether to install the package.
>> 
>> Expectation:
>> 
>> If the user has not pressed i to select the package for installation,
>> package.el should not ask the user to confirm anything. There's no
>> action to execute. This is unexpected dwim behavior.
>
>>From the Emacs manual:
>
>   ‘x’
>        Download and install all packages marked with ‘i’, and their
>        dependencies; also, delete all packages marked with ‘d’
>        (‘package-menu-execute’).  This also removes the marks.  If no
>        packages are marked, this command will install the package under
>        point (if it isn’t installed already), or delete the package under
>        point (if it’s already installed).
>
> The doc string says similar stuff:
>
>   If no packages are marked, the action taken depends on the state
>   of the package under point.  If it’s not already installed, this
>   command will install the package, and if it’s installed, it will
>   delete the package.
>
> So this is documented behavior.  This is not a bug, but a feature.

That being said, I am not a fan of this DWIM-ish behaviour either.

bug#63563: 29.0.91; package.el should not install unselected packages

[Jimmy Yuen Ho Wong]

[-- Attachment #1: Type: text/plain, Size: 2069 bytes --]

Is this new behavior no one asked for configurable? Over the many years
I've been using package.el, I've built in muscle memory. After M-x
list-packages, when the packages buffer is done refreshing, I immediately
press U and x without looking. With the new behavior, when there's
no upgrades, I'd be installing the first package at point. Doing that a
couple of times will mean I'll have a couple of extra packages I don't want
installed.

Jimmy


On Thu, May 18, 2023 at 8:53 PM Philip Kaludercic <philipk@posteo.net>
wrote:

> Eli Zaretskii <eliz@gnu.org> writes:
>
> > tags 63563 notabug
> > thanks
> >
> >> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
> >> Date: Thu, 18 May 2023 03:10:23 +0100
> >>
> >> 1. M-x list-packages
> >> 2. Press x on a line
> >> 3. Observer in the echo area package.el is now asking the user to
> >> whether to install the package.
> >>
> >> Expectation:
> >>
> >> If the user has not pressed i to select the package for installation,
> >> package.el should not ask the user to confirm anything. There's no
> >> action to execute. This is unexpected dwim behavior.
> >
> >>From the Emacs manual:
> >
> >   ‘x’
> >        Download and install all packages marked with ‘i’, and their
> >        dependencies; also, delete all packages marked with ‘d’
> >        (‘package-menu-execute’).  This also removes the marks.  If no
> >        packages are marked, this command will install the package under
> >        point (if it isn’t installed already), or delete the package under
> >        point (if it’s already installed).
> >
> > The doc string says similar stuff:
> >
> >   If no packages are marked, the action taken depends on the state
> >   of the package under point.  If it’s not already installed, this
> >   command will install the package, and if it’s installed, it will
> >   delete the package.
> >
> > So this is documented behavior.  This is not a bug, but a feature.
>
> That being said, I am not a fan of this DWIM-ish behaviour either.
>

[-- Attachment #2: Type: text/html, Size: 2882 bytes --]

bug#63563: 29.0.91; package.el should not install unselected packages

[Eli Zaretskii]

> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
> Date: Mon, 29 May 2023 01:51:11 +0100
> Cc: Eli Zaretskii <eliz@gnu.org>, 63563@debbugs.gnu.org
> 
> Is this new behavior no one asked for configurable? Over the many years I've been using package.el,
> I've built in muscle memory. After M-x list-packages, when the packages buffer is done refreshing, I
> immediately press U and x without looking. With the new behavior, when there's no upgrades, I'd be
> installing the first package at point. Doing that a couple of times will mean I'll have a couple of extra
> packages I don't want installed.

It turns out this behavior is new in Emacs 29, see bug#40457 and NEWS.
Since the new behavior is incompatible with the old one, I have now
added a new user option, package-menu-use-current-if-no-marks, to get
back the old behavior, and mentioned it in NEWS.  You can now
customize that option to a nil value to get what you want.

bug#63563: 29.0.91; package.el should not install unselected packages

[Jimmy Wong]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

Thank you so much!
On 29 May 2023 at 2:47 PM +0100, Eli Zaretskii <eliz@gnu.org>, wrote:
> > From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
> > Date: Mon, 29 May 2023 01:51:11 +0100
> > Cc: Eli Zaretskii <eliz@gnu.org>, 63563@debbugs.gnu.org
> >
> > Is this new behavior no one asked for configurable? Over the many years I've been using package.el,
> > I've built in muscle memory. After M-x list-packages, when the packages buffer is done refreshing, I
> > immediately press U and x without looking. With the new behavior, when there's no upgrades, I'd be
> > installing the first package at point. Doing that a couple of times will mean I'll have a couple of extra
> > packages I don't want installed.
>
> It turns out this behavior is new in Emacs 29, see bug#40457 and NEWS.
> Since the new behavior is incompatible with the old one, I have now
> added a new user option, package-menu-use-current-if-no-marks, to get
> back the old behavior, and mentioned it in NEWS. You can now
> customize that option to a nil value to get what you want.

[-- Attachment #2: Type: text/html, Size: 1533 bytes --]

bug#63563: 29.0.91; package.el should not install unselected packages

[Eli Zaretskii]

> Date: Mon, 29 May 2023 14:57:45 +0100
> From: Jimmy Wong <wyuenho@gmail.com>
> Cc: philipk@posteo.net, 63563@debbugs.gnu.org
> 
> Thank you so much!

Thanks, I take it that you have tried using this new option, and you
are satisfied.  So I'm closing this bug.

bug#63563: 29.0.91; package.el should not install unselected packages

[Howard Melman]

Eli Zaretskii <eliz@gnu.org> writes:

> It turns out this behavior is new in Emacs 29, see bug#40457 and NEWS.
> Since the new behavior is incompatible with the old one, I have now
> added a new user option, package-menu-use-current-if-no-marks, to get
> back the old behavior, and mentioned it in NEWS.  You can now
> customize that option to a nil value to get what you want.

Should the default value of
package-menu-use-current-if-no-marks be nil?

That would follow the convention of old behavior being
unchanged unless the user does something to enable the new
behavior.

-- 

Howard

bug#63563: 29.0.91; package.el should not install unselected packages

[Eli Zaretskii]

> From: Howard Melman <hmelman@gmail.com>
> Date: Thu, 01 Jun 2023 12:36:28 -0400
> 
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > It turns out this behavior is new in Emacs 29, see bug#40457 and NEWS.
> > Since the new behavior is incompatible with the old one, I have now
> > added a new user option, package-menu-use-current-if-no-marks, to get
> > back the old behavior, and mentioned it in NEWS.  You can now
> > customize that option to a nil value to get what you want.
> 
> Should the default value of
> package-menu-use-current-if-no-marks be nil?
> 
> That would follow the convention of old behavior being
> unchanged unless the user does something to enable the new
> behavior.

The discussion about that should have happened a year ago, when this
change was made.  Since it haven't, we cannot just undo what's been
done a year ago and didn't receive any complaints until now.  Sorry,
we will have to make do with at least the possibility to go back to
the old behavior.