From: Pieter van Oostrum <pieter-l@vanoostrum.org>
To: Michael Welsh Duggan <mwd@md5i.com>
Cc: 39075@debbugs.gnu.org
Subject: bug#39075: 28.0.50; Emacs hangs on 100% CPU and grows beyond bounds in shell-mode
Date: Thu, 16 Jan 2020 20:21:37 +0100 [thread overview]
Message-ID: <lxblr3i4vy.fsf@cochabamba.vanoostrum.org> (raw)
In-Reply-To: <lxzheoilag.fsf@cochabamba.vanoostrum.org> (Pieter van Oostrum's message of "Wed, 15 Jan 2020 20:15:03 +0100")
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
Pieter van Oostrum <pieter-l@vanoostrum.org> writes:
> Michael Welsh Duggan <mwd@md5i.com> writes:
>
>> This seems very similar to the bug I reported at bug#38549. Could you
>> see if this also fixes that recipe and, if so, merge the bugs?
>>
> Yes, the same fix solves that bug also. It is the same bug.
I propose to amend the test also, so that it would have caught this error (by hanging). I add both patches here now. I have tested that all other things worked the same and found no problems.
Is there an official procedure for requesting the change, or is posting it here sufficient?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: shell.patch --]
[-- Type: text/x-patch, Size: 867 bytes --]
diff --git a/lisp/shell.el b/lisp/shell.el
index 98e830ee49..ecebf937e2 100644
--- a/lisp/shell.el
+++ b/lisp/shell.el
@@ -428,7 +428,7 @@ shell--parse-pcomplete-arguments
(save-excursion
(goto-char begin)
(while (< (point) end)
- (skip-chars-forward " \t\n")
+ (skip-chars-forward " \t\n;")
(push (point) begins)
(let ((arg ()))
(while (looking-at
diff --git a/test/lisp/shell-tests.el b/test/lisp/shell-tests.el
index 6d262f8e7c..7113cb941c 100644
--- a/test/lisp/shell-tests.el
+++ b/test/lisp/shell-tests.el
@@ -34,8 +34,7 @@ shell-tests-completion-before-semi
(with-temp-buffer
(shell-mode)
(insert "cd ba;")
- (forward-char -1)
(should (equal (shell--parse-pcomplete-arguments)
- '(("cd" "ba") 1 4)))))
+ '(("cd" "ba" "") 1 4)))))
;;; shell-tests.el ends here
[-- Attachment #3: Type: text/plain, Size: 87 bytes --]
--
Pieter van Oostrum
www: http://pieter.vanoostrum.org/
PGP key: [8DAE142BE17999C4]
next prev parent reply other threads:[~2020-01-16 19:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 21:16 bug#39075: 28.0.50; Emacs hangs on 100% CPU and grows beyond bounds in shell-mode Pieter van Oostrum
2020-01-11 9:59 ` Eli Zaretskii
2020-01-12 17:11 ` Pieter van Oostrum
2020-01-12 17:43 ` Eli Zaretskii
2020-01-13 13:58 ` Pieter van Oostrum
2020-01-15 3:17 ` Michael Welsh Duggan
2020-01-15 19:15 ` Pieter van Oostrum
2020-01-16 19:21 ` Pieter van Oostrum [this message]
2020-01-18 9:57 ` Eli Zaretskii
2020-01-19 18:08 ` Glenn Morris
2020-01-20 0:29 ` Pieter van Oostrum
2020-01-17 10:57 ` Pieter van Oostrum
2020-01-19 18:11 ` Glenn Morris
2020-01-19 21:41 ` Pieter van Oostrum
2020-01-20 7:47 ` Michael Albinus
2020-01-20 13:12 ` Pieter van Oostrum
2020-01-20 13:33 ` Michael Albinus
2020-01-20 14:57 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lxblr3i4vy.fsf@cochabamba.vanoostrum.org \
--to=pieter-l@vanoostrum.org \
--cc=39075@debbugs.gnu.org \
--cc=mwd@md5i.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.