From: Glenn Morris <rgm@gnu.org>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 8586@debbugs.gnu.org
Subject: bug#8586: 23.3.50; Directory-local variable ignored when file-local variables set mode
Date: Mon, 23 May 2011 13:04:34 -0400 [thread overview]
Message-ID: <lrr57p9wm5.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87vcxwzw47.fsf@sc3d.org>
Reuben Thomas wrote:
> While it would fix this bug, I'm not sure I approve: it looks as
> though it makes things more complicated, and when the "real fix"
> eventually arrives, would presumably have to remain in place for those
> who'd adopted this partial solution in the mean time...not great.
These comments don't apply. This isn't a partial solution, and no-one
needs to "adopt" anything.
I'm making set-auto-mode respect mode: cookies whether they be at the
start or end of the file. That's how it should work, IMO. It also
removes the "major mode must be specified first" restriction (bug#5239).
The only issue I see with it is that normal-mode will be less efficient
than it could be, because set-auto-mode and hack-local-variables may
parse similar regions of the file in similar ways.
Ideally, the file would be parsed only once to get coding:, mode: and
variables, which would then be applied (also allowing bug#7169 to be
fixed). But this is not straightforward to do, because these features
are currently spread over at least 4 functions, so I don't see it
happening any time soon.
next prev parent reply other threads:[~2011-05-23 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 19:38 bug#8586: 23.3.50; Directory-local variable ignored when file-local variables set mode Reuben Thomas
2011-05-03 0:45 ` Glenn Morris
2011-05-22 1:35 ` Glenn Morris
2011-05-22 16:53 ` Reuben Thomas
2011-05-23 17:04 ` Glenn Morris [this message]
2011-05-23 18:11 ` Reuben Thomas
2011-05-27 1:01 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lrr57p9wm5.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=8586@debbugs.gnu.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.