all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Viper face support on ttys? (Re: viper-color-defined-p)
       [not found] <87hdt7ale1.fsf@t.email.ne.jp>
@ 2004-07-10 22:50 ` Lőrentey Károly
  2004-07-11  4:37   ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Lőrentey Károly @ 2004-07-10 22:50 UTC (permalink / raw)
  Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

Sorry for the long response time!

IRIE Tetsuya <irie@t.email.ne.jp> writes:
> I have problem if using viper.
>
> 1. emacs -q -nw
> 2. M-x server-start
> 3. M-x viper-mode
> 4. emacsclient -d :0.0&
> 5. some action on X frame (e.g. C-xC-f, M-x foo...)
> 6. viper-save-cursor-color: Symbol's function definition is void: viper-color-defined-p

The error appeared because Viper thinks that Emacs still does not have
support for faces on tty devices.  I committed the following patch as
patch-214, but I think it should also be included in CVS. (The bug is
not triggered in CVS, but the patch enables face support there, too.)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 557 bytes --]

*** orig/lisp/emulation/viper-init.el
--- mod/lisp/emulation/viper-init.el
***************
*** 97,103 ****
  (defun viper-has-face-support-p ()
    (cond ((viper-window-display-p))
  	(viper-force-faces)
! 	(viper-emacs-p (memq (viper-device-type) '(pc)))
  	(viper-xemacs-p (memq (viper-device-type) '(tty pc)))))
  
  \f
--- 97,103 ----
  (defun viper-has-face-support-p ()
    (cond ((viper-window-display-p))
  	(viper-force-faces)
! 	(viper-emacs-p (memq (viper-device-type) '(nil pc)))
  	(viper-xemacs-p (memq (viper-device-type) '(tty pc)))))
  
  \f

[-- Attachment #3: Type: text/plain, Size: 196 bytes --]


2004-07-11  Károly Lőrentey  <lorentey@elte.hu>

        * lisp/emulation/viper-init.el (viper-has-face-support-p):
          Acknowledge that Emacs has face support on ttys.

-- 
Károly

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Viper face support on ttys? (Re: viper-color-defined-p)
  2004-07-10 22:50 ` Viper face support on ttys? (Re: viper-color-defined-p) Lőrentey Károly
@ 2004-07-11  4:37   ` Eli Zaretskii
  2004-07-11 23:23     ` Richard Stallman
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2004-07-11  4:37 UTC (permalink / raw)
  Cc: multi-tty, emacs-devel

> From: lorentey@elte.hu (=?iso-8859-2?Q?L=F5rentey_K=E1roly?=)
> Date: Sun, 11 Jul 2004 00:50:22 +0200
> 
> ! 	(viper-emacs-p (memq (viper-device-type) '(nil pc)))

Actually, this should look at the result of display-color-p.  The
device type alone doesn't cut it, as some tty displays don't support
colors.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Viper face support on ttys? (Re: viper-color-defined-p)
  2004-07-11  4:37   ` Eli Zaretskii
@ 2004-07-11 23:23     ` Richard Stallman
  2004-07-12  5:08       ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Stallman @ 2004-07-11 23:23 UTC (permalink / raw)
  Cc: multi-tty, emacs-devel

    > ! 	(viper-emacs-p (memq (viper-device-type) '(nil pc)))

    Actually, this should look at the result of display-color-p.  The
    device type alone doesn't cut it, as some tty displays don't support
    colors.

Would you like to fix it properly?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Viper face support on ttys? (Re: viper-color-defined-p)
  2004-07-11 23:23     ` Richard Stallman
@ 2004-07-12  5:08       ` Eli Zaretskii
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2004-07-12  5:08 UTC (permalink / raw)
  Cc: multi-tty, lorentey, emacs-devel

> From: Richard Stallman <rms@gnu.org>
> Date: Sun, 11 Jul 2004 19:23:43 -0400
> 
>     > ! 	(viper-emacs-p (memq (viper-device-type) '(nil pc)))
> 
>     Actually, this should look at the result of display-color-p.  The
>     device type alone doesn't cut it, as some tty displays don't support
>     colors.
> 
> Would you like to fix it properly?

I will look into this in a few days.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2004-07-12  5:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <87hdt7ale1.fsf@t.email.ne.jp>
2004-07-10 22:50 ` Viper face support on ttys? (Re: viper-color-defined-p) Lőrentey Károly
2004-07-11  4:37   ` Eli Zaretskii
2004-07-11 23:23     ` Richard Stallman
2004-07-12  5:08       ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.