all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: lorentey@elte.hu (Lőrentey Károly)
Cc: teirllm@dms.auburn.edu, emacs-devel@gnu.org
Subject: Re: [PATCH] Fix `window-at' and `coordinates-in-window-p'
Date: Sun, 25 Jul 2004 22:52:49 +0200	[thread overview]
Message-ID: <lorentey.g.e.devel.87vfgb95cu.elte@eris.elte.hu> (raw)
In-Reply-To: <E1Bon50-00007E-K7@fencepost.gnu.org> (Richard Stallman's message of "Sun, 25 Jul 2004 13:46:34 -0400")


[-- Attachment #1.1: Type: text/plain, Size: 737 bytes --]

Richard Stallman <rms@gnu.org> writes:
>     I think it's easier to adjust the pixel coordinates right inside
>     coordinates_in_window_p, which both functions use:
>
> This is not clean, because it gives the arguments of
> coordinates_in_window_p a peculiar meaning (and doesn't document it,
> by the way).  It is much better to keep their meanings consistent
> with the rest of Emacs.

OK.

> I will fix the other call.

If you mean the one in window-vscroll, I don't think there are
problems with that in CVS.  (It uses the macros for converting
relative lengths, as intended.  My patch would have broken that.)

> Meanwhile, I fixed the other reported bug in coordinates-in-window-p.

Great! :-)

-- 
Károly

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

  reply	other threads:[~2004-07-25 20:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-23 22:29 [PATCH] Fix `window-at' and `coordinates-in-window-p' Lőrentey Károly
2004-07-24  1:44 ` Luc Teirlinck
2004-07-24  8:51 ` Eli Zaretskii
2004-07-24 21:06   ` Lőrentey Károly
2004-07-24 14:30 ` Luc Teirlinck
2004-07-24 21:00   ` Lőrentey Károly
2004-07-25  0:12     ` Luc Teirlinck
2004-07-25 20:38       ` Lőrentey Károly
2004-07-25 17:46     ` Richard Stallman
2004-07-25 20:52       ` Lőrentey Károly [this message]
2004-07-24 19:44 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lorentey.g.e.devel.87vfgb95cu.elte@eris.elte.hu \
    --to=lorentey@elte.hu \
    --cc=emacs-devel@gnu.org \
    --cc=teirllm@dms.auburn.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.