Recursive load? master build fail

Recursive load? master build fail

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

Hi all,

Is anyone else seeing this master build failure? I ran with make bootstrap

make[2]: Entering directory `/home/kmodi/downloads/git/emacs/lisp'
  ELC      progmodes/js.elc
>>Error occurred processing progmodes/js.el: error (("Recursive load"
"/home/kmodi/downloads/git/emacs/lisp/net/tramp.elc"
"/home/kmodi/downloads/git/emacs/lisp/net/tramp.elc"
"/home/kmodi/downloads/git/emacs/lisp/net/tramp.elc"
"/home/kmodi/downloads/git/emacs/lisp/net/tramp.elc"
"/home/kmodi/downloads/git/emacs/lisp/net/tramp.elc"
"/home/kmodi/downloads/git/emacs/lisp/emacs-lisp/warnings.elc"))
make[2]: *** [progmodes/js.elc] Error 1
make[2]: Leaving directory `/home/kmodi/downloads/git/emacs/lisp'
make[1]: *** [compile-main] Error 2
make[1]: Leaving directory `/home/kmodi/downloads/git/emacs/lisp'
make: *** [lisp] Error 2
-- 

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1133 bytes --]

Re: Recursive load? master build fail

[Dmitry Gutov]

On 05/08/2016 12:58 AM, Kaushal Modi wrote:

> Is anyone else seeing this master build failure? I ran with make bootstrap

I see it too. Only not during the build (maybe because I did a partial 
one) but when launching it with my full configuration.

Re: Recursive load? master build fail

[Paul Eggert]

Dmitry Gutov wrote:

>> Is anyone else seeing this master build failure? I ran with make bootstrap
> 
> I see it too. Only not during the build (maybe because I did a partial one) but
> when launching it with my full configuration.

I am not seeing it (master commit 4c175a6af5f7935582208e197105cf67aa1b12bd,
Date: Sun May 8 02:01:22 2016 +0300). I did a 'make -j5 bootstrap' on Fedora 23
x86-64.

Re: Recursive load? master build fail

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

On Sat, May 7, 2016, 8:08 PM Paul Eggert

> I am not seeing it (master commit 4c175a6af5f7935582208e197105cf67aa1b12bd,
> Date: Sun May 8 02:01:22 2016 +0300). I did a 'make -j5 bootstrap' on
> Fedora 23
> x86-64.
>

I'm not at my machine right now. What does -j5 do? I am on RHEL 6.6.

I also saw those recursive load errors when launching emacs after a quick
make and make install. So I tried doing a clean build using make bootstrap.
But then the build itself failed with the same recursive load errors.

-- 

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 974 bytes --]

Re: Recursive load? master build fail

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

On Sat, May 7, 2016, 9:22 PM Kaushal Modi <kaushal.modi@gmail.com> wrote:

> I also saw those recursive load errors when launching emacs after a quick
> make and make install. So I tried doing a clean build using make bootstrap.
> But then the build itself failed with the same recursive load errors.
>

@Michael I saw mentions of tramp.elc in the errors. Any idea if/how recent
tramp.el changes could have caused this?

> --

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 881 bytes --]

Re: Recursive load? master build fail

[Paul Eggert]

Kaushal Modi wrote:
> On Sat, May 7, 2016, 9:22 PM Kaushal Modi <kaushal.modi@gmail.com> wrote:
> 
>> I also saw those recursive load errors when launching emacs after a quick
>> make and make install. So I tried doing a clean build using make bootstrap.
>> But then the build itself failed with the same recursive load errors.
>>
> 
> @Michael I saw mentions of tramp.elc in the errors. Any idea if/how recent
> tramp.el changes could have caused this?


make -j5 bootstrap worked, if I recall correctly.

But I just now tried this in an already-built master on Ubuntu 16.04 x86-64:

cd lisp && make compile-always

and it failed:

ELC progmodes/js.elc
>>Error occurred processing progmodes/js.el: error (("Recursive load"
"/home/eggert/src/gnu/emacs/static-checking/lisp/net/tramp.elc"
"/home/eggert/src/gnu/emacs/static-checking/lisp/net/tramp.elc"
"/home/eggert/src/gnu/emacs/static-checking/lisp/net/tramp.elc"
"/home/eggert/src/gnu/emacs/static-checking/lisp/net/tramp.elc"
"/home/eggert/src/gnu/emacs/static-checking/lisp/net/tramp.elc"
"/home/eggert/src/gnu/emacs/static-checking/lisp/emacs-lisp/warnings.elc"))
Makefile:282: recipe for target 'progmodes/js.elc' failed


Then, when I did another 'make', it worked. So perhaps there's a race in there
somehow?

Re: Recursive load? master build fail

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 129 bytes --]

After some experimenting I narrowed it down to the attached patch: reverting
this change unbreaks the build on master. Michael?


[-- Attachment #2: 0001-Continue-to-fix-Bug-10085.patch --]
[-- Type: text/x-diff, Size: 6534 bytes --]

From 97776f295d652aff97be91431ad53db5618ad2a2 Mon Sep 17 00:00:00 2001
From: Michael Albinus <michael.albinus@gmx.de>
Date: Sat, 7 May 2016 22:52:30 +0200
Subject: [PATCH] Continue to fix Bug#10085

* lisp/net/tramp.el (tramp-completion-file-name-handler-alist)
<expand-file-name>: Add handler.
(tramp-completion-handle-expand-file-name): New defun.
(tramp-handle-file-name-as-directory): Handle completion mode case.

* test/lisp/net/tramp-tests.el (tramp-test06-directory-file-name):
Fix test.
(tramp-test24-file-name-completion): Extend test.
---
 lisp/net/tramp.el            | 31 +++++++++++++++++---
 test/lisp/net/tramp-tests.el | 67 +++++++++++++++++++++++++++++++-------------
 2 files changed, 75 insertions(+), 23 deletions(-)

diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index 3da60e9..87ccae1 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -1010,7 +1010,9 @@ tramp-current-connection
 
 ;;;###autoload
 (defconst tramp-completion-file-name-handler-alist
-  '((file-name-all-completions . tramp-completion-handle-file-name-all-completions)
+  '((expand-file-name . tramp-completion-handle-expand-file-name)
+    (file-name-all-completions
+     . tramp-completion-handle-file-name-all-completions)
     (file-name-completion . tramp-completion-handle-file-name-completion))
   "Alist of completion handler functions.
 Used for file names matching `tramp-file-name-regexp'. Operations
@@ -2261,6 +2263,23 @@ tramp-connectable-p
 		    (p (tramp-get-connection-process v)))
 	       (and p (processp p) (memq (process-status p) '(run open))))))))
 
+;;;###autoload
+(defun tramp-completion-handle-expand-file-name
+    (name &optional dir)
+  "Like `expand-file-name' for Tramp files."
+  (if (tramp-completion-mode-p)
+      (progn
+	;; If DIR is not given, use `default-directory' or "/".
+	(setq dir (or dir default-directory "/"))
+	;; Unless NAME is absolute, concat DIR and NAME.
+	(unless (file-name-absolute-p name)
+	  (setq name (concat (file-name-as-directory dir) name)))
+	;; Return NAME.
+	name)
+
+    (tramp-completion-run-real-handler
+     'expand-file-name (list name dir))))
+
 ;; Method, host name and user name completion.
 ;; `tramp-completion-dissect-file-name' returns a list of
 ;; tramp-file-name structures. For all of them we return possible completions.
@@ -2817,13 +2836,17 @@ tramp-handle-file-name-as-directory
   ;; `file-name-as-directory' would be sufficient except localname is
   ;; the empty string.
   (let ((v (tramp-dissect-file-name file t)))
-    ;; Run the command on the localname portion only.
+    ;; Run the command on the localname portion only unless we are in
+    ;; completion mode.
     (tramp-make-tramp-file-name
      (tramp-file-name-method v)
      (tramp-file-name-user v)
      (tramp-file-name-host v)
-     (tramp-run-real-handler
-      'file-name-as-directory (list (or (tramp-file-name-localname v) "")))
+     (if (and (tramp-completion-mode-p)
+	      (zerop (length (tramp-file-name-localname v))))
+	 ""
+       (tramp-run-real-handler
+	'file-name-as-directory (list (or (tramp-file-name-localname v) ""))))
      (tramp-file-name-hop v))))
 
 (defun tramp-handle-file-name-completion
diff --git a/test/lisp/net/tramp-tests.el b/test/lisp/net/tramp-tests.el
index efb19e9..a85eed0 100644
--- a/test/lisp/net/tramp-tests.el
+++ b/test/lisp/net/tramp-tests.el
@@ -649,7 +649,9 @@ tramp--instrument-test-case
 	  (setq file (format "/%s:" file))
 	  (should (string-equal (directory-file-name file) file))
 	  (should
-	   (string-equal (file-name-as-directory file) (concat file "./")))
+	   (string-equal
+	    (file-name-as-directory file)
+	    (if (tramp-completion-mode-p) file (concat file "./"))))
 	  (should (string-equal (file-name-directory file) file))
 	  (should (string-equal (file-name-nondirectory file) "")))))))
 
@@ -1367,25 +1369,52 @@ tramp--instrument-test-case
   "Check `file-name-completion' and `file-name-all-completions'."
   (skip-unless (tramp--test-enabled))
 
-  (let ((tmp-name (tramp--test-make-temp-name)))
-    (unwind-protect
-	(progn
-	  (make-directory tmp-name)
-	  (should (file-directory-p tmp-name))
-	  (write-region "foo" nil (expand-file-name "foo" tmp-name))
-	  (write-region "bar" nil (expand-file-name "bold" tmp-name))
-	  (make-directory (expand-file-name "boz" tmp-name))
-	  (should (equal (file-name-completion "fo" tmp-name) "foo"))
-	  (should (equal (file-name-completion "b" tmp-name) "bo"))
-	  (should
-	   (equal (file-name-completion "b" tmp-name 'file-directory-p) "boz/"))
-	  (should (equal (file-name-all-completions "fo" tmp-name) '("foo")))
-	  (should
-	   (equal (sort (file-name-all-completions "b" tmp-name) 'string-lessp)
-		  '("bold" "boz/"))))
+  (dolist (n-e '(nil t))
+    (let ((non-essential n-e)
+	  (tmp-name (tramp--test-make-temp-name))
+	  (method (file-remote-p tramp-test-temporary-file-directory 'method))
+	  (host (file-remote-p tramp-test-temporary-file-directory 'host)))
+
+      (unwind-protect
+	  (progn
+	    ;; Method and host name in completion mode.
+	    (when (tramp-completion-mode-p)
+	      (unless (zerop (length method))
+		(should
+		 (member
+		  (format "%s:" method)
+		  (file-name-all-completions (substring method 0 1) "/"))))
+	      (unless (zerop (length host))
+		(should
+		 (member
+		  (format "%s:" host)
+		  (file-name-all-completions (substring host 0 1) "/"))))
+	      (unless (or (zerop (length method)) (zerop (length host)))
+		(should
+		 (member
+		  (format "%s:" host)
+		  (file-name-all-completions
+		   (substring host 0 1) (format "/%s:" method))))))
+
+	    ;; Local files.
+	    (make-directory tmp-name)
+	    (should (file-directory-p tmp-name))
+	    (write-region "foo" nil (expand-file-name "foo" tmp-name))
+	    (write-region "bar" nil (expand-file-name "bold" tmp-name))
+	    (make-directory (expand-file-name "boz" tmp-name))
+	    (should (equal (file-name-completion "fo" tmp-name) "foo"))
+	    (should (equal (file-name-completion "b" tmp-name) "bo"))
+	    (should
+	     (equal
+	      (file-name-completion "b" tmp-name 'file-directory-p) "boz/"))
+	    (should (equal (file-name-all-completions "fo" tmp-name) '("foo")))
+	    (should
+	     (equal
+	      (sort (file-name-all-completions "b" tmp-name) 'string-lessp)
+	      '("bold" "boz/"))))
 
-      ;; Cleanup.
-      (ignore-errors (delete-directory tmp-name 'recursive)))))
+	;; Cleanup.
+	(ignore-errors (delete-directory tmp-name 'recursive))))))
 
 (ert-deftest tramp-test25-load ()
   "Check `load'."
-- 
2.7.4

Re: Recursive load? master build fail

[Michael Albinus]

Paul Eggert <eggert@cs.ucla.edu> writes:

> After some experimenting I narrowed it down to the attached patch: reverting
> this change unbreaks the build on master. Michael?

Yes, this commit has changed some autoloads of Tramp which are causing
the problem. Last night, I've checked the patch prior committing with
"make -C test tramp-tests", which worked. Will see how to fix it.

Sorry for the inconveniene.

Best regards, Michael.

Re: Recursive load? master build fail

[Michael Albinus]

Michael Albinus <michael.albinus@gmx.de> writes:

> Yes, this commit has changed some autoloads of Tramp which are causing
> the problem. Last night, I've checked the patch prior committing with
> "make -C test tramp-tests", which worked. Will see how to fix it.

Should be fixed now.

> Sorry for the inconveniene.

Best regards, Michael.

Re: Recursive load? master build fail

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

On Sun, May 8, 2016 at 5:50 AM Michael Albinus <michael.albinus@gmx.de>
wrote:

> Michael Albinus <michael.albinus@gmx.de> writes:
> Should be fixed now.
>

Thanks! It's fixed now.
-- 

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 585 bytes --]

Re: Recursive load? master build fail

[Colin Baxter]

Kaushal Modi <kaushal.modi <at> gmail.com> writes:

> 
> 
> 
> On Sun, May 8, 2016 at 5:50 AM Michael Albinus <michael.albinus <at>
gmx.de> wrote:
> 
> Michael Albinus <michael.albinus <at> gmx.de> writes:Should be fixed now.
> 
> 
> Thanks! It's fixed now. 

Not so sure. The recursive load re-appears with an org-mode table when
navigating columns via TAB: 

"Recursive load: /home/redknight/git/emacs/lisp/net/tramp.elc",
"/home/redknight/git/emacs/lisp/net/tramp.elc",
"/home/redknight/git/emacs/lisp/net/tramp.elc",
"/home/redknight/git/emacs/lisp/net/tramp.elc",
"/home/redknight/git/emacs/lisp/net/tramp.elc",
"/home/redknight/git/org-mode/lisp/org-table.elc"

Re: Recursive load? master build fail

[Colin Baxter]

> > 
> > On Sun, May 8, 2016 at 5:50 AM Michael Albinus <michael.albinus <at>
> gmx.de> wrote:
> > 
> > Michael Albinus <michael.albinus <at> gmx.de> writes:Should be fixed now.
> > 
> > 
> > Thanks! It's fixed now. 
> 
> Not so sure. The recursive load re-appears with an org-mode table when
> navigating columns via TAB: 
> 

Recursive load, in a table using TAB, appears fixed in
emacs-24.5-rc3-fixed-9284-g62d7aca and org-mode release_8.3.4-783-g779222e.
Thanks.

Re: Recursive load? master build fail

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

Michael Albinus wrote:
> Should be fixed now.

I'm getting failures like the attached when I run "make check" on master. I am
using commit 2eb6817ba971184cc109f8530f4b3b38f65650ea dated Sun May 8 13:24:20
2016 +0000.

[-- Attachment #2: testfail.txt --]
[-- Type: text/plain, Size: 1454 bytes --]

   passed  24/30  tramp-test23-visited-file-modtime
Test tramp-test24-file-name-completion backtrace:
  #[nil "\306\307\x18\x19\310\x1a\307^[\3111\x19\0\312\216\313\"\211\x12)0\202^[\0\210\
  ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
  ert-run-test([cl-struct-ert-test tramp-test24-file-name-completion "
  ert-run-or-rerun-test([cl-struct-ert--stats (not (tag :expensive-tes
  ert-run-tests((not (tag :expensive-test)) #[385 "\306\x02\307\"\203G\0\2
  ert-run-tests-batch((not (tag :expensive-test)))
  ert-run-tests-batch-and-exit((not (tag :expensive-test)))
  eval((ert-run-tests-batch-and-exit (quote (not (tag :expensive-test)
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/tramp-tests.elc"
  command-line()
  normal-top-level()
Test tramp-test24-file-name-completion condition:
    (ert-test-failed
     ((should
       (member
	(format "%s:" host)
	(file-name-all-completions ... "/")))
      :form
      (member "day:"
	      ("dav:" "davs:" "doas:" "dev/"))
      :value nil))
   FAILED  25/30  tramp-test24-file-name-completion
   passed  26/30  tramp-test25-load
   passed  27/30  tramp-test30-make-auto-save-file-name
   passed  28/30  tramp-test31-special-characters
   passed  29/30  tramp-test32-utf8
   passed  30/30  tramp-test34-recursive-load

Ran 30 tests, 29 results as expected, 1 unexpected (2016-05-08 12:07:03-0700)

1 unexpected results:
   FAILED  tramp-test24-file-name-completion

ERROR: lisp/net/tramp-tests.log

Re: Recursive load? master build fail

[Michael Albinus]

Paul Eggert <eggert@cs.ucla.edu> writes:

Hi Paul,

> I'm getting failures like the attached when I run "make check" on master. I am
> using commit 2eb6817ba971184cc109f8530f4b3b38f65650ea dated Sun May 8 13:24:20
> 2016 +0000.

Does not happen here.

> Test tramp-test24-file-name-completion condition:
>     (ert-test-failed
>      ((should
>        (member
> 	(format "%s:" host)
> 	(file-name-all-completions ... "/")))
>       :form
>       (member "day:"
> 	      ("dav:" "davs:" "doas:" "dev/"))
>       :value nil))

What is "day"? Is it your local computer? Do you use another remote
directory for testing but the default `/mock::/tmp/'?

Best regards, Michael.

Re: Recursive load? master build fail

[Paul Eggert]

Michael Albinus wrote:
>> > Test tramp-test24-file-name-completion condition:
>> >     (ert-test-failed
>> >      ((should
>> >        (member
>> > 	(format "%s:" host)
>> > 	(file-name-all-completions ... "/")))
>> >       :form
>> >       (member "day:"
>> > 	      ("dav:" "davs:" "doas:" "dev/"))
>> >       :value nil))
> What is "day"? Is it your local computer?

Yes.

> Do you use another remote
> directory for testing but the default `/mock::/tmp/'?

I just run "make check" without any special settings. I assume no remote
directories are involved.

Re: Recursive load? master build fail

[Michael Albinus]

Paul Eggert <eggert@cs.ucla.edu> writes:

>> Do you use another remote
>> directory for testing but the default `/mock::/tmp/'?
>
> I just run "make check" without any special settings. I assume no remote
> directories are involved.

Yes, only the mock default for tests.

I've committed a patch which ought to solve the problem for you. Since
it doesn't happen for me, could you, pls check?

Best regards, Michael.

Re: Recursive load? master build fail

[Paul Eggert]

Michael Albinus wrote:
> I've committed a patch which ought to solve the problem for you. Since
> it doesn't happen for me, could you, pls check?

It works for me now, and thanks.

Re: Recursive load? master build fail

[Michael Albinus]

Paul Eggert <eggert@cs.ucla.edu> writes:

>> I've committed a patch which ought to solve the problem for you. Since
>> it doesn't happen for me, could you, pls check?
>
> It works for me now, and thanks.

Thanks for confirmation.

There's still another error with tramp-tests on hydra (and only
there). I'll continue to debug.

Best regards, Michael.

Re: Recursive load? master build fail

[Stephen Berman]

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

On Wed, 11 May 2016 09:23:16 +0200 Michael Albinus <michael.albinus@gmx.de> wrote:

> Paul Eggert <eggert@cs.ucla.edu> writes:
>
>>> I've committed a patch which ought to solve the problem for you. Since
>>> it doesn't happen for me, could you, pls check?
>>
>> It works for me now, and thanks.
>
> Thanks for confirmation.
>
> There's still another error with tramp-tests on hydra (and only
> there). I'll continue to debug.

I updated my master branch to 62d7acae7405732268713006d839a5c3507b9482
and built with `make bootstrap', and when I try to open an article in
Gnus (by typing RET on the article's line in the Summary buffer), a
"Recursive load" error in Tramp is signalled and the article is not
displayed; full backtrace attached.  If I type `C-u g' to open the
article, then it is displayed.

Steve Berman


[-- Attachment #2: tramp-recursive-load.backtrace --]
[-- Type: application/octet-stream, Size: 17746 bytes --]

Debugger entered--Lisp error: (error "Recursive load" "/data/steve/git/emacs-master/lisp/net/tramp.elc" "/data/steve/git/emacs-master/lisp/net/tramp.elc" "/data/steve/git/emacs-master/lisp/net/tramp.elc" "/data/steve/git/emacs-master/lisp/net/tramp.elc" "/data/steve/git/emacs-master/lisp/net/tramp.elc" "/data/steve/git/emacs-master/lisp/gnus/gnus-bcklg.elc")
  tramp-completion-handle-expand-file-name("/data" nil)
  apply(tramp-completion-handle-expand-file-name ("/data" nil))
  (progn (apply (cdr fn) args))
  (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))
  (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate))))
  (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args))
  (let ((fn (assoc operation tramp-completion-file-name-handler-alist))) (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args)))
  tramp-completion-file-name-handler(expand-file-name "/data" nil)
  file-symlink-p("/data")
  file-truename("/data")
  apply(file-truename "/data")
  (let* ((inhibit-file-name-handlers (cons (quote tramp-completion-file-name-handler) (cons (quote cygwin-mount-name-hook-function) (cons (quote cygwin-mount-map-drive-hook-function) (and (eq inhibit-file-name-operation operation) inhibit-file-name-handlers))))) (inhibit-file-name-operation operation)) (apply operation args))
  tramp-completion-run-real-handler(file-truename ("/data"))
  (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args))
  (let ((fn (assoc operation tramp-completion-file-name-handler-alist))) (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args)))
  tramp-completion-file-name-handler(file-truename "/data")
  file-truename("/data" (93) (nil))
  file-truename("/data/steve" (93) (nil))
  file-truename("/data/steve/git" (93) (nil))
  file-truename("/data/steve/git/emacs-master" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp/net" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp/net/tramp.elc")
  tramp-completion-handle-expand-file-name("/data" nil)
  apply(tramp-completion-handle-expand-file-name ("/data" nil))
  (progn (apply (cdr fn) args))
  (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))
  (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate))))
  (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args))
  (let ((fn (assoc operation tramp-completion-file-name-handler-alist))) (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args)))
  tramp-completion-file-name-handler(expand-file-name "/data" nil)
  file-symlink-p("/data")
  file-truename("/data")
  apply(file-truename "/data")
  (let* ((inhibit-file-name-handlers (cons (quote tramp-completion-file-name-handler) (cons (quote cygwin-mount-name-hook-function) (cons (quote cygwin-mount-map-drive-hook-function) (and (eq inhibit-file-name-operation operation) inhibit-file-name-handlers))))) (inhibit-file-name-operation operation)) (apply operation args))
  tramp-completion-run-real-handler(file-truename ("/data"))
  (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args))
  (let ((fn (assoc operation tramp-completion-file-name-handler-alist))) (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args)))
  tramp-completion-file-name-handler(file-truename "/data")
  file-truename("/data" (93) (nil))
  file-truename("/data/steve" (93) (nil))
  file-truename("/data/steve/git" (93) (nil))
  file-truename("/data/steve/git/emacs-master" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp/net" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp/net/tramp.elc")
  tramp-completion-handle-expand-file-name("/data" nil)
  apply(tramp-completion-handle-expand-file-name ("/data" nil))
  (progn (apply (cdr fn) args))
  (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))
  (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate))))
  (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args))
  (let ((fn (assoc operation tramp-completion-file-name-handler-alist))) (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args)))
  tramp-completion-file-name-handler(expand-file-name "/data" nil)
  file-symlink-p("/data")
  file-truename("/data")
  apply(file-truename "/data")
  (let* ((inhibit-file-name-handlers (cons (quote tramp-completion-file-name-handler) (cons (quote cygwin-mount-name-hook-function) (cons (quote cygwin-mount-map-drive-hook-function) (and (eq inhibit-file-name-operation operation) inhibit-file-name-handlers))))) (inhibit-file-name-operation operation)) (apply operation args))
  tramp-completion-run-real-handler(file-truename ("/data"))
  (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args))
  (let ((fn (assoc operation tramp-completion-file-name-handler-alist))) (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args)))
  tramp-completion-file-name-handler(file-truename "/data")
  file-truename("/data" (93) (nil))
  file-truename("/data/steve" (93) (nil))
  file-truename("/data/steve/git" (93) (nil))
  file-truename("/data/steve/git/emacs-master" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp/net" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp/net/tramp.elc")
  tramp-completion-handle-expand-file-name("/data" nil)
  apply(tramp-completion-handle-expand-file-name ("/data" nil))
  (progn (apply (cdr fn) args))
  (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))
  (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate))))
  (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args))
  (let ((fn (assoc operation tramp-completion-file-name-handler-alist))) (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args)))
  tramp-completion-file-name-handler(expand-file-name "/data" nil)
  file-symlink-p("/data")
  file-truename("/data")
  apply(file-truename "/data")
  (let* ((inhibit-file-name-handlers (cons (quote tramp-completion-file-name-handler) (cons (quote cygwin-mount-name-hook-function) (cons (quote cygwin-mount-map-drive-hook-function) (and (eq inhibit-file-name-operation operation) inhibit-file-name-handlers))))) (inhibit-file-name-operation operation)) (apply operation args))
  tramp-completion-run-real-handler(file-truename ("/data"))
  (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args))
  (let ((fn (assoc operation tramp-completion-file-name-handler-alist))) (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args)))
  tramp-completion-file-name-handler(file-truename "/data")
  file-truename("/data" (93) (nil))
  file-truename("/data/steve" (93) (nil))
  file-truename("/data/steve/git" (93) (nil))
  file-truename("/data/steve/git/emacs-master" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp/net" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp/net/tramp.elc")
  tramp-completion-handle-expand-file-name("/data" nil)
  apply(tramp-completion-handle-expand-file-name ("/data" nil))
  (progn (apply (cdr fn) args))
  (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))
  (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate))))
  (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args))
  (let ((fn (assoc operation tramp-completion-file-name-handler-alist))) (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args)))
  tramp-completion-file-name-handler(expand-file-name "/data" nil)
  file-symlink-p("/data")
  file-truename("/data")
  apply(file-truename "/data")
  (let* ((inhibit-file-name-handlers (cons (quote tramp-completion-file-name-handler) (cons (quote cygwin-mount-name-hook-function) (cons (quote cygwin-mount-map-drive-hook-function) (and (eq inhibit-file-name-operation operation) inhibit-file-name-handlers))))) (inhibit-file-name-operation operation)) (apply operation args))
  tramp-completion-run-real-handler(file-truename ("/data"))
  (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args))
  (let ((fn (assoc operation tramp-completion-file-name-handler-alist))) (if (and fn tramp-mode (tramp-completion-mode-p) (or (eq tramp-syntax (quote sep)) (featurep (quote tramp)) (and (boundp (quote partial-completion-mode)) (symbol-value (quote partial-completion-mode))) (featurep (quote ido)) (featurep (quote icicles)))) (let ((save-match-data-internal (match-data))) (unwind-protect (progn (apply (cdr fn) args)) (set-match-data save-match-data-internal (quote evaporate)))) (tramp-completion-run-real-handler operation args)))
  tramp-completion-file-name-handler(file-truename "/data")
  file-truename("/data" (93) (nil))
  file-truename("/data/steve" (93) (nil))
  file-truename("/data/steve/git" (93) (nil))
  file-truename("/data/steve/git/emacs-master" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp/gnus" (93) (nil))
  file-truename("/data/steve/git/emacs-master/lisp/gnus/gnus-bcklg.elc")
  gnus-backlog-request-article("gmane.emacs.bugs" 118093 #<buffer *Article gmane.emacs.bugs*>)
  gnus-request-article-this-buffer(118093 "gmane.emacs.bugs")
  gnus-article-prepare(118093 nil)
  gnus-summary-display-article(118093)
  gnus-summary-next-page(nil)
  funcall-interactively(gnus-summary-next-page nil)
  call-interactively(gnus-summary-next-page nil nil)
  command-execute(gnus-summary-next-page)

Re: Recursive load? master build fail

[Michael Albinus]

Stephen Berman <stephen.berman@gmx.net> writes:

> I updated my master branch to 62d7acae7405732268713006d839a5c3507b9482
> and built with `make bootstrap', and when I try to open an article in
> Gnus (by typing RET on the article's line in the Summary buffer), a
> "Recursive load" error in Tramp is signalled and the article is not
> displayed; full backtrace attached.  If I type `C-u g' to open the
> article, then it is displayed.

I cannot reproduce it here. Does it also happen, when you call "emacs -Q",
and load only gnus specific settings?

It looks also a bit strange, that file-truename uses some
hidden arguments, which are not propagated to Tramp:

>   tramp-completion-file-name-handler(file-truename "/data")
>   file-truename("/data" (93) (nil))
>   file-truename("/data/steve" (93) (nil))
>   file-truename("/data/steve/git" (93) (nil))
>   file-truename("/data/steve/git/emacs-master" (93) (nil))
>   file-truename("/data/steve/git/emacs-master/lisp" (93) (nil))
>   file-truename("/data/steve/git/emacs-master/lisp/net" (93) (nil))
>   file-truename("/data/steve/git/emacs-master/lisp/net/tramp.elc")

> Steve Berman

Best regards, Michael.

Re: Recursive load? master build fail

[Stephen Berman]

On Wed, 11 May 2016 17:08:42 +0200 Michael Albinus <michael.albinus@gmx.de> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> I updated my master branch to 62d7acae7405732268713006d839a5c3507b9482
>> and built with `make bootstrap', and when I try to open an article in
>> Gnus (by typing RET on the article's line in the Summary buffer), a
>> "Recursive load" error in Tramp is signalled and the article is not
>> displayed; full backtrace attached.  If I type `C-u g' to open the
>> article, then it is displayed.
>
> I cannot reproduce it here. Does it also happen, when you call "emacs -Q",
> and load only gnus specific settings?

No, with -Q, `M-x gnus', `n', `B RET news.gmane.org RET', then entering
e.g. the group gmane.emacs.bugs and selecting an article with SPC (not
RET, as I mistakenly wrote above) works without error.  So it's only
with my setup that I get the "Recursive load" error; however, I now
discovered that when I quit the backtrace buffer that pops up (I have
debug-on-error set) and then type `g' on the article in the Summary
buffer, then the article is displayed as usual.  Trying to open further
articles then sometimes works immediately and sometimes errors,
sometimes as before but also like this (just displayed in the echo
area not in a backtrace buffer):

Error while decoding: (error Recursive load /data/steve/git/emacs-master/lisp/net/tramp.elc /data/steve/git/emacs-master/lisp/net/tramp.elc /data/steve/git/emacs-master/lisp/net/tramp.elc /data/steve/git/emacs-master/lisp/net/tramp.elc /data/steve/git/emacs-master/lisp/net/tramp.elc /data/steve/git/emacs-master/lisp/mail/qp.elc)

> It looks also a bit strange, that file-truename uses some
> hidden arguments, which are not propagated to Tramp:
>
>>   tramp-completion-file-name-handler(file-truename "/data")
>>   file-truename("/data" (93) (nil))
>>   file-truename("/data/steve" (93) (nil))
>>   file-truename("/data/steve/git" (93) (nil))
>>   file-truename("/data/steve/git/emacs-master" (93) (nil))
>>   file-truename("/data/steve/git/emacs-master/lisp" (93) (nil))
>>   file-truename("/data/steve/git/emacs-master/lisp/net" (93) (nil))
>>   file-truename("/data/steve/git/emacs-master/lisp/net/tramp.elc")

I have no idea what that means.  Do you have any suggestion how to try
to debug this?  I can try to bisect my initializations, but that will be
laborious; git bisect will probably be even more painful, since building
Emacs on this machine is quite slow.

Steve Berman

Re: Recursive load? master build fail

[Michael Albinus]

Stephen Berman <stephen.berman@gmx.net> writes:

>> I cannot reproduce it here. Does it also happen, when you call "emacs -Q",
>> and load only gnus specific settings?
>
> No, with -Q, `M-x gnus', `n', `B RET news.gmane.org RET', then entering
> e.g. the group gmane.emacs.bugs and selecting an article with SPC (not
> RET, as I mistakenly wrote above) works without error.

Ahh, that explains what I'm debugging for hours. Your backtrace tells me
that Tramp is in completion mode. This couldn't happen when you have
entered RET as last key. Entering SPC is another story, which makes more
sense with your backtrace.

At least now I have an idea what to look for. And maybe I could even
reproduce it locally, which would help much.

> I have no idea what that means.  Do you have any suggestion how to try
> to debug this?  I can try to bisect my initializations, but that will be
> laborious; git bisect will probably be even more painful, since building
> Emacs on this machine is quite slow.

I bet you use something like ido or icicles or so.

> Steve Berman

Best regards, Michael.

Re: Recursive load? master build fail

[Stephen Berman]

On Wed, 11 May 2016 21:11:57 +0200 Michael Albinus <michael.albinus@gmx.de> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
>>> I cannot reproduce it here. Does it also happen, when you call "emacs -Q",
>>> and load only gnus specific settings?
>>
>> No, with -Q, `M-x gnus', `n', `B RET news.gmane.org RET', then entering
>> e.g. the group gmane.emacs.bugs and selecting an article with SPC (not
>> RET, as I mistakenly wrote above) works without error.
>
> Ahh, that explains what I'm debugging for hours. Your backtrace tells me
> that Tramp is in completion mode. This couldn't happen when you have
> entered RET as last key. Entering SPC is another story, which makes more
> sense with your backtrace.

So sorry that my mistake sent you on a wild good chase.

> At least now I have an idea what to look for. And maybe I could even
> reproduce it locally, which would help much.

That would be good.  I'm now using Gnus from master and having gotten
the error on first trying to open an article, then using `g' to get the
correct display as I noted in my previous post, I'm now not getting the
error anymore at all.  Maybe a timing or initialization issue?

>> I have no idea what that means.  Do you have any suggestion how to try
>> to debug this?  I can try to bisect my initializations, but that will be
>> laborious; git bisect will probably be even more painful, since building
>> Emacs on this machine is quite slow.
>
> I bet you use something like ido or icicles or so.

I don't use either of these directly, but a command I wrote to access
recentf-list does call ido-completing-read; but I haven't invoked that
command prior to any of the "Recursive load" errors I've seen in Gnus.

Steve Berman

Re: Recursive load? master build fail

[Stephen Berman]

On Wed, 11 May 2016 21:31:12 +0200 Stephen Berman <stephen.berman@gmx.net> wrote:

> On Wed, 11 May 2016 21:11:57 +0200 Michael Albinus <michael.albinus@gmx.de> wrote:
>
>> Stephen Berman <stephen.berman@gmx.net> writes:
>>
>>>> I cannot reproduce it here. Does it also happen, when you call "emacs -Q",
>>>> and load only gnus specific settings?
>>>
>>> No, with -Q, `M-x gnus', `n', `B RET news.gmane.org RET', then entering
>>> e.g. the group gmane.emacs.bugs and selecting an article with SPC (not
>>> RET, as I mistakenly wrote above) works without error.
>>
>> Ahh, that explains what I'm debugging for hours. Your backtrace tells me
>> that Tramp is in completion mode. This couldn't happen when you have
>> entered RET as last key. Entering SPC is another story, which makes more
>> sense with your backtrace.
>
> So sorry that my mistake sent you on a wild good chase.

Oops:                                         goose

>> At least now I have an idea what to look for. And maybe I could even
>> reproduce it locally, which would help much.
>
> That would be good.  I'm now using Gnus from master and having gotten
> the error on first trying to open an article, then using `g' to get the
> correct display as I noted in my previous post, I'm now not getting the
> error anymore at all.  Maybe a timing or initialization issue?
>
>>> I have no idea what that means.  Do you have any suggestion how to try
>>> to debug this?  I can try to bisect my initializations, but that will be
>>> laborious; git bisect will probably be even more painful, since building
>>> Emacs on this machine is quite slow.
>>
>> I bet you use something like ido or icicles or so.
>
> I don't use either of these directly, but a command I wrote to access
> recentf-list does call ido-completing-read; but I haven't invoked that
> command prior to any of the "Recursive load" errors I've seen in Gnus.
>
> Steve Berman