From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Newsgroups: gmane.emacs.devel Subject: Re: Your commit 7409a79 Date: Sat, 6 Dec 2014 16:14:42 +0000 (UTC) Message-ID: References: <83h9x917il.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1417882525 30589 80.91.229.3 (6 Dec 2014 16:15:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Dec 2014 16:15:25 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 06 17:15:19 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XxI0q-0002S4-Hv for ged-emacs-devel@m.gmane.org; Sat, 06 Dec 2014 17:15:16 +0100 Original-Received: from localhost ([::1]:54845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxI0q-0003X6-31 for ged-emacs-devel@m.gmane.org; Sat, 06 Dec 2014 11:15:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxI0d-0003QU-Ah for emacs-devel@gnu.org; Sat, 06 Dec 2014 11:15:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XxI0U-0003Ug-Hj for emacs-devel@gnu.org; Sat, 06 Dec 2014 11:15:03 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:43369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxI0U-0003Uc-AC for emacs-devel@gnu.org; Sat, 06 Dec 2014 11:14:54 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XxI0S-0002HZ-8L for emacs-devel@gnu.org; Sat, 06 Dec 2014 17:14:52 +0100 Original-Received: from 84-236-108-149.pool.digikabel.hu ([84.236.108.149]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 06 Dec 2014 17:14:52 +0100 Original-Received: from adatgyujto by 84-236-108-149.pool.digikabel.hu with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 06 Dec 2014 17:14:52 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 31 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: sea.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 84.236.108.149 (Mozilla/5.0 (Windows NT 6.1; rv:33.0) Gecko/20100101 Firefox/33.0) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:179185 Archived-At: Eli Zaretskii gnu.org> writes: > > Please always start the commit log summary line with a capital letter, > and end the sentence with a period. (Actually, in the above > particular case the summary line is redundant and could be omitted -- > but this is a stylistic comment, not a requirement.) > > Also, renaming a file needs an entry in the target's ChangeLog, like > this: > > * CONTRIBUTE: Renamed from etc/CONTRIBUTE. > > and it also should end with a period, not a comma. > These are exactly the situations where a server side commit hook is really useful for the following reasons: 1. It prevent commits with incorrectly formatted commit messages. 2. It prints an error message describing the problem, thereby teaching the committer how to make a properly formatted commit. So there is no need for manually replying to incorrect commits on the list, because the script checks every commit and even tells the user the problem. So it would be a good idea to add such a precommit script to the server.