all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tom <adatgyujto@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Your commit 7409a79
Date: Sat, 6 Dec 2014 16:14:42 +0000 (UTC)	[thread overview]
Message-ID: <loom.20141206T171332-896@post.gmane.org> (raw)
In-Reply-To: 83h9x917il.fsf@gnu.org

Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> Please always start the commit log summary line with a capital letter,
> and end the sentence with a period.  (Actually, in the above
> particular case the summary line is redundant and could be omitted --
> but this is a stylistic comment, not a requirement.)
> 
> Also, renaming a file needs an entry in the target's ChangeLog, like
> this:
> 
>   * CONTRIBUTE: Renamed from etc/CONTRIBUTE.
> 
> and it also should end with a period, not a comma.
> 

These are exactly the situations where a server side commit hook
is really useful for the following reasons:

1. It prevent commits with incorrectly formatted commit messages.

2. It prints an error message describing the problem, thereby
teaching the committer how to make a properly formatted commit.

So there is no need for manually replying to incorrect commits
on the list, because the script checks every commit and even 
tells the user the problem.

So it would be a good idea to add such a precommit script to the
server.






  parent reply	other threads:[~2014-12-06 16:14 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-06  8:56 Your commit 7409a79 Eli Zaretskii
2014-12-06 10:22 ` Andreas Schwab
2014-12-06 10:29   ` Eli Zaretskii
2014-12-06 10:32   ` Paul Eggert
2014-12-06 15:29   ` Yuri Khan
2014-12-06 23:01   ` Stefan Monnier
2014-12-06 16:14 ` Tom [this message]
2014-12-06 18:54   ` Eli Zaretskii
2014-12-06 22:43   ` Stephen Leake
2014-12-06 22:33 ` Stephen Leake
2014-12-07  3:52   ` Eli Zaretskii
2014-12-07 22:39     ` Stephen Leake
2014-12-08  1:57       ` Paul Eggert
2014-12-08  2:28         ` Stephen J. Turnbull
2014-12-08 15:58           ` Eli Zaretskii
2014-12-08 23:38             ` Stephen Leake
2014-12-08 15:58         ` Eli Zaretskii
2014-12-08 18:24           ` Paul Eggert
2014-12-08 15:51       ` Eli Zaretskii
2014-12-08 17:32         ` John Yates
2014-12-08 17:57           ` Eli Zaretskii
2014-12-08 18:14             ` Paul Eggert
2014-12-08 18:28               ` Eli Zaretskii
2014-12-08 18:37               ` Eli Zaretskii
2014-12-08 18:54                 ` Paul Eggert
2014-12-08 19:00               ` Stefan Monnier
2014-12-08 18:54             ` John Yates
2014-12-08 23:27         ` Stephen Leake
2014-12-09  0:51           ` Thien-Thi Nguyen
2014-12-09  8:08             ` Stephen Leake
2014-12-09  9:36               ` Thien-Thi Nguyen
2014-12-09 16:57           ` Eli Zaretskii
2014-12-10  9:26             ` Stephen Leake
2014-12-10 16:17               ` Eli Zaretskii
2014-12-10 17:04                 ` Stephen Leake
2014-12-10 18:02                   ` Eli Zaretskii
2014-12-10 19:20                     ` Paul Eggert
2014-12-07  5:45   ` Stephen J. Turnbull
2014-12-06 22:59 ` Stefan Monnier
2014-12-07 22:44   ` Stephen Leake
2014-12-07 23:28     ` Stefan Monnier
2014-12-08  9:34       ` Stephen Leake
2014-12-08 10:22         ` Thien-Thi Nguyen
2014-12-08 14:58         ` Stefan Monnier
2014-12-08 23:32           ` Stephen Leake
2014-12-09 11:00           ` Richard Stallman
2014-12-09 11:09             ` David Kastrup
2014-12-10  8:24               ` Richard Stallman
2014-12-10 17:05                 ` Stephen Leake
2014-12-10 19:08                   ` Stefan Monnier
2014-12-08 15:54     ` Eli Zaretskii
2014-12-08 23:33       ` Stephen Leake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20141206T171332-896@post.gmane.org \
    --to=adatgyujto@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.