From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Fabrice Popineau Newsgroups: gmane.emacs.devel Subject: Re: Question about mmap buffers Date: Tue, 29 Apr 2014 16:24:09 +0000 (UTC) Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1398788690 27968 80.91.229.3 (29 Apr 2014 16:24:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Apr 2014 16:24:50 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 29 18:24:43 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WfApn-0004Zk-CB for ged-emacs-devel@m.gmane.org; Tue, 29 Apr 2014 18:24:43 +0200 Original-Received: from localhost ([::1]:51115 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfApm-0006n3-W0 for ged-emacs-devel@m.gmane.org; Tue, 29 Apr 2014 12:24:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfApd-0006i2-DU for emacs-devel@gnu.org; Tue, 29 Apr 2014 12:24:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WfApV-00088G-Tz for emacs-devel@gnu.org; Tue, 29 Apr 2014 12:24:33 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:33108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfApV-00087v-NV for emacs-devel@gnu.org; Tue, 29 Apr 2014 12:24:25 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WfApT-0004Et-D0 for emacs-devel@gnu.org; Tue, 29 Apr 2014 18:24:23 +0200 Original-Received: from 80.10.161.169 ([80.10.161.169]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Apr 2014 18:24:23 +0200 Original-Received: from fabrice.popineau by 80.10.161.169 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Apr 2014 18:24:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 37 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: sea.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 80.10.161.169 (Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.116 Safari/537.36) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171657 Archived-At: Nobody picked up my question. So more formally, can we apply a patch like the one below? I'm not sure if the mmap_set_vars() function is of any use at all under Unix. I don't see the point with it. Maybe it could be entirely removed. Thanks in advance for your comments. Fabrice === modified file 'src/buffer.c' --- src/buffer.c 2014-04-24 03:59:19 +0000 +++ src/buffer.c 2014-04-29 15:15:34 +0000 @@ -5336,14 +5341,15 @@ #ifdef USE_MMAP_FOR_BUFFERS { - /* When using the ralloc implementation based on mmap(2), buffer - text pointers will have been set to null in the dumped Emacs. - Map new memory. */ struct buffer *b; + /* No buffer can be dumped with a meaningful address. + We reallocate them here. */ FOR_EACH_BUFFER (b) - if (b->text->beg == NULL) - enlarge_buffer_text (b, 0); + { + b->text->beg = NULL; + enlarge_buffer_text (b, 0); + } } #endif /* USE_MMAP_FOR_BUFFERS */