all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* jit-lock tries to fontify killed buffer (sometimes)
@ 2013-04-05  6:56 Fabrice Popineau
  2013-04-05  8:33 ` Andreas Schwab
  2013-04-05 13:24 ` Stefan Monnier
  0 siblings, 2 replies; 6+ messages in thread
From: Fabrice Popineau @ 2013-04-05  6:56 UTC (permalink / raw)
  To: emacs-devel

Hi,

I'm using some post 24.3 version of Emacs (W32 natively compiled).
I start my session with debug-on-error being t.
I get a backtrace on jit-lock trying to fontify some killed-buffer 
while restoring my previous session (thanks to the desktop library).
The obvious patch is:

--- \mirror\emacs\lisp\jit-lock.el      2013-02-08 16:13:02.417999000 +0100
+++ \local\Emacs\lisp\jit-lock.el       2013-04-04 20:35:06.173203900 +0200
@@ -35,7 +35,8 @@
     (declare (debug t))
     `(let ((inhibit-point-motion-hooks t))
        (with-silent-modifications
-         ,@body))))
+         (if (buffer-live-p (current-buffer))
+         ,@body)))))
 ♀
 ;;; Customization.

But maybe this is just hiding something else.

Any idea of what is going on there?

Fabrice




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: jit-lock tries to fontify killed buffer (sometimes)
  2013-04-05  6:56 jit-lock tries to fontify killed buffer (sometimes) Fabrice Popineau
@ 2013-04-05  8:33 ` Andreas Schwab
  2013-04-05  9:11   ` Fabrice Popineau
  2013-04-05 13:24 ` Stefan Monnier
  1 sibling, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2013-04-05  8:33 UTC (permalink / raw)
  To: Fabrice Popineau; +Cc: emacs-devel

Fabrice Popineau <fabrice.popineau@supelec.fr> writes:

> --- \mirror\emacs\lisp\jit-lock.el      2013-02-08 16:13:02.417999000 +0100
> +++ \local\Emacs\lisp\jit-lock.el       2013-04-04 20:35:06.173203900 +0200
> @@ -35,7 +35,8 @@
>      (declare (debug t))
>      `(let ((inhibit-point-motion-hooks t))
>         (with-silent-modifications
> -         ,@body))))
> +         (if (buffer-live-p (current-buffer))
> +         ,@body)))))

That doesn't work if body contains more than one sexp (the first one
will be taken for the true condition, while the remaining are executed
iff it is false).  Use when instead of if.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: jit-lock tries to fontify killed buffer (sometimes)
  2013-04-05  8:33 ` Andreas Schwab
@ 2013-04-05  9:11   ` Fabrice Popineau
  0 siblings, 0 replies; 6+ messages in thread
From: Fabrice Popineau @ 2013-04-05  9:11 UTC (permalink / raw)
  To: emacs-devel

Andreas Schwab <schwab <at> linux-m68k.org> writes:

> That doesn't work if body contains more than one sexp (the first one
> will be taken for the true condition, while the remaining are executed
> iff it is false).  Use when instead of if.
> 
> Andreas.
> 

Ooops. You are so right.

Thanks,

Fabrice




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: jit-lock tries to fontify killed buffer (sometimes)
  2013-04-05  6:56 jit-lock tries to fontify killed buffer (sometimes) Fabrice Popineau
  2013-04-05  8:33 ` Andreas Schwab
@ 2013-04-05 13:24 ` Stefan Monnier
  2013-04-09 13:15   ` Fabrice Popineau
  1 sibling, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2013-04-05 13:24 UTC (permalink / raw)
  To: Fabrice Popineau; +Cc: emacs-devel

> I get a backtrace on jit-lock trying to fontify some killed-buffer 
> while restoring my previous session (thanks to the desktop library).

Can you show us the backtrace?


        Stefan



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: jit-lock tries to fontify killed buffer (sometimes)
  2013-04-05 13:24 ` Stefan Monnier
@ 2013-04-09 13:15   ` Fabrice Popineau
  2013-04-21 23:53     ` Fabrice Popineau
  0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Popineau @ 2013-04-09 13:15 UTC (permalink / raw)
  To: emacs-devel

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> 
> > I get a backtrace on jit-lock trying to fontify some killed-buffer 
> > while restoring my previous session (thanks to the desktop library).
> 
> Can you show us the backtrace?
> 
>         Stefan
> 
I wish I could. I had >100 buffer opened (C, org-mode, lisp)
Since it happened, I cleaned up my workplace.
I will do it if it happens again.
I commented out my fix for the time being.

Fabrice








^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: jit-lock tries to fontify killed buffer (sometimes)
  2013-04-09 13:15   ` Fabrice Popineau
@ 2013-04-21 23:53     ` Fabrice Popineau
  0 siblings, 0 replies; 6+ messages in thread
From: Fabrice Popineau @ 2013-04-21 23:53 UTC (permalink / raw)
  To: emacs-devel

Fabrice Popineau <fabrice.popineau <at> supelec.fr> writes:

> 
> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
> 
> > 
> > > I get a backtrace on jit-lock trying to fontify some killed-buffer 
> > > while restoring my previous session (thanks to the desktop library).
> > 
> > Can you show us the backtrace?
> > 
> >         Stefan
> > 
> I wish I could. I had >100 buffer opened (C, org-mode, lisp)
> Since it happened, I cleaned up my workplace.
> I will do it if it happens again.
> I commented out my fix for the time being.
> 
> Fabrice
> 
> 
Here is a backtrace:

  jit-lock-force-redisplay(#<killed buffer> 810 819)
  apply(jit-lock-force-redisplay (#<killed buffer> 810 819))
  byte-code("r\301\b\302H\b\303H\"\210)\301\207" [timer apply 5 6] 4)
  timer-event-handler([t 20852 31479 298000 nil jit-lock-force-redisplay (#
<killed buffer> 810 819) nil 0])
  input-pending-p()
  auto-revert-buffers()
  global-auto-revert-mode(1)
  desktop-create-buffer(206 "c:/Home/.emacs.d/personal/Fabrice.org" 
"Fabrice.org" org-mode (abbrev-mode flyspell-mode TeX-PDF-mode undo-tree-
mode yas-minor-mode page-break-lines-mode subword-mode linum-mode global-
auto-revert-mode org-indent-mode) 1117 (997 nil) nil nil ((indent-tabs-mode) 
(buffer-file-coding-system . utf-8-dos) (truncate-lines)))
  eval-buffer(#<buffer  *load*> nil 
"c:/Home/.emacs.d/savefile/.emacs.desktop" nil t)  ; Reading at buffer 
position 4435
  load-with-code-conversion("c:/Home/.emacs.d/savefile/.emacs.desktop" 
"c:/Home/.emacs.d/savefile/.emacs.desktop" t t)
  load("c:/Home/.emacs.d/savefile/.emacs.desktop" t t t)
  desktop-read("c:/Home/.emacs.d/savefile")
  (if (file-exists-p (desktop-full-file-name)) (desktop-read desktop-
dirname))
  (progn (desktop-save-mode 1) (setq desktop-save t) (setq desktop-load-
locked-desktop t) (setq desktop-dirname fp-config-savefile-dir) (add-hook 
(quote find-file-hook) (function (lambda nil (run-with-timer 5 nil (function 
(lambda nil (setq desktop-file-modtime ...) (desktop-save desktop-
dirname))))))) (if (file-exists-p (desktop-full-file-name)) (desktop-read 
desktop-dirname)) (add-hook (quote kill-emacs-hook) (function (lambda nil 
(setq desktop-file-modtime (nth 5 (file-attributes (desktop-full-file-
name))))))))
  (if (not (eq (emacs-pid) (desktop-owner))) (progn (desktop-save-mode 1) 
(setq desktop-save t) (setq desktop-load-locked-desktop t) (setq desktop-
dirname fp-config-savefile-dir) (add-hook (quote find-file-hook) (function 
(lambda nil (run-with-timer 5 nil (function (lambda nil ... ...)))))) (if 
(file-exists-p (desktop-full-file-name)) (desktop-read desktop-dirname)) 
(add-hook (quote kill-emacs-hook) (function (lambda nil (setq desktop-file-
modtime (nth 5 (file-attributes ...))))))))
  desktop-settings-setup()
  run-hooks(after-init-hook)
  command-line()
  normal-top-level()

Fabrice







^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-04-21 23:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-05  6:56 jit-lock tries to fontify killed buffer (sometimes) Fabrice Popineau
2013-04-05  8:33 ` Andreas Schwab
2013-04-05  9:11   ` Fabrice Popineau
2013-04-05 13:24 ` Stefan Monnier
2013-04-09 13:15   ` Fabrice Popineau
2013-04-21 23:53     ` Fabrice Popineau

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.