all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tom <adatgyujto@gmail.com>
To: help-gnu-emacs@gnu.org
Subject: Re: Diff could also show the changes within lines
Date: Sat, 10 Nov 2012 15:30:04 +0000 (UTC)	[thread overview]
Message-ID: <loom.20121110T162021-424@post.gmane.org> (raw)
In-Reply-To: 80d2zlvnos.fsf@somewhere.org

Sebastien Vauban <wxhgmqzgwmuf@...> writes:

> 
> I'd like to get that feature as well. However, the above code causes me
> 2 problems:
> 
> - only the last hunk is getting refined, both in VC dir's buffer, or when
>   reading (with Gnus) an email with a patch file in it;
>

Currently I use this code added to the diff mode hook:

(defun my-refine-all-diff-hunks ()
  (interactive)
  (condition-case nil      
      (save-excursion
        (goto-char (point-min))
        (while (not (eobp))
          (diff-hunk-next)))
    (error nil)))


It works well for me, it highlights the changes in all hunks
automatically. I use it only for diffing before checkin.

But. It works only because the VC mercurial implementation calls
the backend synchronously. In case of DVC it doesn't work for
me, because DVC calls the backend asynchronously, so when the diff
hook is run the output is not there yet and I did not find a hook
which is called when the async diff command is finished

You may want to check how the diff output is produced in your use
cases. If it is done asynchronously then the diff hook is not a 
suitable place to call the highlighting code from.




  reply	other threads:[~2012-11-10 15:30 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-05 14:37 Diff could also show the changes within lines Tom
2012-10-05 14:39 ` Drew Adams
2012-10-05 14:47   ` Tom
2012-10-05 16:32   ` Doug Lewan
2012-10-05 15:09 ` chandan r
2012-10-05 14:57   ` Tom
2012-10-05 16:26     ` Tom
2012-10-05 18:11       ` Tom
     [not found]       ` <mailman.10388.1349460693.855.help-gnu-emacs@gnu.org>
2012-11-10  8:58         ` Sebastien Vauban
2012-11-10 15:30           ` Tom [this message]
2012-11-12 20:00             ` Oleksandr Gavenko
2012-11-13  8:45               ` Tom
     [not found]           ` <mailman.12687.1352561429.855.help-gnu-emacs@gnu.org>
2012-11-14 14:31             ` Sebastien Vauban
2012-11-14 18:03               ` Tom
     [not found]               ` <mailman.12981.1352916228.855.help-gnu-emacs@gnu.org>
2012-11-14 22:07                 ` Sebastien Vauban
2012-11-15  6:36                   ` Tom
     [not found]                   ` <mailman.13015.1352961428.855.help-gnu-emacs@gnu.org>
2012-11-15 10:04                     ` Sebastien Vauban
2012-11-15 10:15                       ` Tom
     [not found]                       ` <mailman.13023.1352974557.855.help-gnu-emacs@gnu.org>
2012-11-15 11:29                         ` Sebastien Vauban
2012-11-15 12:30                           ` Tom
     [not found]                           ` <mailman.13025.1352982671.855.help-gnu-emacs@gnu.org>
2012-11-15 15:20                             ` Sebastien Vauban
2012-11-15 16:32                               ` Tom
2012-11-16 15:30                                 ` Stefan Monnier
2012-11-16 16:40                                   ` Tom
     [not found]                                   ` <mailman.13097.1353084086.855.help-gnu-emacs@gnu.org>
2012-11-19 14:48                                     ` Stefan Monnier
     [not found]                               ` <mailman.13033.1352997200.855.help-gnu-emacs@gnu.org>
2012-11-15 18:17                                 ` Sebastien Vauban
2012-11-15 18:53                                   ` Tom
     [not found]                                   ` <mailman.13043.1353005666.855.help-gnu-emacs@gnu.org>
2012-11-15 21:34                                     ` Sebastien Vauban
2012-11-16 16:24                                       ` Tom
2012-11-19 12:51                                       ` Sebastien Vauban
2012-11-19 17:45                                         ` Tom
     [not found]     ` <mailman.10380.1349454390.855.help-gnu-emacs@gnu.org>
2012-10-06 13:10       ` Stefan Monnier
2012-10-07 14:10         ` Tom
  -- strict thread matches above, loose matches on Subject: below --
2014-02-07 16:50 Sebastien Vauban
2014-02-08  4:58 ` Michael Heerdegen
     [not found] ` <mailman.14135.1391835521.10748.help-gnu-emacs@gnu.org>
2014-02-08 12:53   ` Sebastien Vauban
2014-02-10 15:55   ` Sebastien Vauban
2014-02-12 11:35     ` Michael Heerdegen
     [not found]     ` <mailman.14857.1392204947.10748.help-gnu-emacs@gnu.org>
2014-02-18 10:09       ` Sebastien Vauban
2014-02-18 11:01         ` Sebastien Vauban
2014-02-18 11:02           ` Sebastien Vauban
2014-02-18 16:07             ` Michael Heerdegen
     [not found]             ` <mailman.15440.1392739818.10748.help-gnu-emacs@gnu.org>
2014-02-18 19:01               ` Sebastien Vauban
2014-02-18 22:12                 ` Michael Heerdegen
     [not found]                 ` <mailman.15497.1392761564.10748.help-gnu-emacs@gnu.org>
2014-02-19 11:08                   ` Sebastien Vauban
2014-02-19 17:54                     ` Michael Heerdegen
2014-02-18 13:40           ` Stefan Monnier
2014-02-18 16:08             ` Michael Heerdegen
2014-02-18 16:04         ` Michael Heerdegen
2014-02-18 16:04         ` Michael Heerdegen
2014-02-18 16:05         ` Michael Heerdegen
2014-03-20 13:31       ` Sebastien Vauban
2014-03-21 11:46         ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20121110T162021-424@post.gmane.org \
    --to=adatgyujto@gmail.com \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.