From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.devel Subject: Re: crash on MacOSX Date: Mon, 20 Aug 2012 16:37:12 +0000 (UTC) Message-ID: References: <83fw7kh1te.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1345480651 1731 80.91.229.3 (20 Aug 2012 16:37:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2012 16:37:31 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 18:37:31 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T3Uyp-0008O8-JU for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2012 18:37:31 +0200 Original-Received: from localhost ([::1]:40955 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Uyo-0000sI-6C for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2012 12:37:30 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Uyk-0000rs-KX for emacs-devel@gnu.org; Mon, 20 Aug 2012 12:37:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3Uyi-0003eM-OK for emacs-devel@gnu.org; Mon, 20 Aug 2012 12:37:26 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:36833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Uyi-0003db-HN for emacs-devel@gnu.org; Mon, 20 Aug 2012 12:37:24 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1T3Uyf-0008GD-UV for emacs-devel@gnu.org; Mon, 20 Aug 2012 18:37:22 +0200 Original-Received: from killzone.appliedtheory.com ([207.127.103.2]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 20 Aug 2012 18:37:21 +0200 Original-Received: from Adrian.B.Robert by killzone.appliedtheory.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 20 Aug 2012 18:37:21 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 16 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: sea.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 207.127.103.2 (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_8; en-us) AppleWebKit/533.21.1 (KHTML, like Gecko) Version/5.0.5 Safari/533.21.1) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152698 Archived-At: Alp Aker gmail.com> writes: > >; e.g., the #ifdef NS_IMPL_COCOA portion of > ns_ascii_average_width is, I'm fairly sure, incorrect, but I haven't > sorted out yet what the correct thing for it to do is). I would just remove that portion, or make it a loop that checks the advancement for each character individually. Still, you would need to be sure that all 95 glyphs are found named as their ascii characters for that to work. This is why the ns_char_width impl used advancementForGlyph only as a potential shortcut and not the sole approach. -Adrian