all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jérémy Compostella" <jeremy.compostella@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: other-buffer advice on kill-buffer
Date: Tue, 2 Aug 2011 11:58:33 +0000 (UTC)	[thread overview]
Message-ID: <loom.20110802T134602-561@post.gmane.org> (raw)
In-Reply-To: CACxch4qqiipnBRaunAqf5hrG=5ddbOUpNx73vDwsMThUehdwww@mail.gmail.com

Alp Aker <alptekin.aker <at> gmail.com> writes:

> 
> Tim Cross wrote:
> 
> > From memory, you cannot advise functions implemented in C, only those
> > implemented in elisp.
> 
> That's not correct.  You can advise a primitive function, but the advice will
> only affect calls to that function made from Lisp, not calls from other
> primitives.
Reading emacs source code let met think that way. Thanks you for confirming my
understanding.

> Jérémy Compostella wrote:
> 
> >> I have tried to advice the other-buffer function which seems called
> >> (Cf. buffer.c) but my advice is never called in this case. Indeed, my
> >> other-buffer advice is correctly called on switch-to-buffer call but
> >> never on kill-buffer call.
> 
> Are you sure your advice on other-buffer is being called when
> switch-to-buffer is called?  That shouldn't be possible, as switch-to-buffer
> is a primitive, like kill-buffer; neither should see your advice.
Indeed, I did not understand why it was possible in that case. I finally figure
out that actually my switch-to-buffer was bound to iswitchb-buffer which lisp
implemented. My mistake.

Thanks.




  reply	other threads:[~2011-08-02 11:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01 23:03 other-buffer advice on kill-buffer Jérémy Compostella
2011-08-01 23:19 ` Antoine Levitt
2011-08-02  0:06   ` Jérémy Compostella
2011-08-02  0:40     ` Antoine Levitt
2011-08-02 12:20       ` Jérémy Compostella
2011-08-02 18:04     ` Dimitri Fontaine
2011-08-03  7:41   ` Stephen J. Turnbull
2011-08-02  0:55 ` Tim Cross
2011-08-02  1:00   ` Tim Cross
2011-08-02 12:29     ` Jérémy Compostella
2011-08-02  1:52   ` Alp Aker
2011-08-02 11:58     ` Jérémy Compostella [this message]
2011-08-02 21:55     ` Richard Stallman
2011-08-03  6:18       ` David Kastrup
2011-08-03 15:14         ` Jérémy Compostella
2011-08-04  2:24           ` Stephen J. Turnbull
2011-08-03 19:18         ` Richard Stallman
2011-08-04  6:42         ` Tim Cross
2011-08-04 14:03           ` Stefan Monnier
2011-08-04 19:56             ` Jérémy Compostella
2011-08-19  7:10       ` Leo
2011-08-14 17:16 ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20110802T134602-561@post.gmane.org \
    --to=jeremy.compostella@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.