From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc. Date: Mon, 25 Oct 2010 13:25:53 +0000 (UTC) Message-ID: References: <19651.37838.815906.240014@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1288015170 13838 80.91.229.12 (25 Oct 2010 13:59:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 25 Oct 2010 13:59:30 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 25 15:59:29 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PANaC-00070x-6I for ged-emacs-devel@m.gmane.org; Mon, 25 Oct 2010 15:59:29 +0200 Original-Received: from localhost ([127.0.0.1]:52259 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PANTE-0001ut-2q for ged-emacs-devel@m.gmane.org; Mon, 25 Oct 2010 09:52:16 -0400 Original-Received: from [140.186.70.92] (port=54381 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PANHO-0003qu-4j for emacs-devel@gnu.org; Mon, 25 Oct 2010 09:40:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PAN40-0003Gg-Py for emacs-devel@gnu.org; Mon, 25 Oct 2010 09:26:13 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:38957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PAN40-0003GT-KU for emacs-devel@gnu.org; Mon, 25 Oct 2010 09:26:12 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PAN3w-00076B-Jr for emacs-devel@gnu.org; Mon, 25 Oct 2010 15:26:08 +0200 Original-Received: from dsl-hkibrasgw2-fe25de00-221.dhcp.inet.fi ([80.222.37.221]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 25 Oct 2010 15:26:08 +0200 Original-Received: from Adrian.B.Robert by dsl-hkibrasgw2-fe25de00-221.dhcp.inet.fi with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 25 Oct 2010 15:26:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 31 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: sea.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 80.222.37.221 (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en; rv:1.9.0.19) Gecko/2010081818 Camino/2.0.4 (like Firefox/3.0.19)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132089 Archived-At: Glenn Morris gnu.org> writes: > > Dan Nicolaescu wrote: > > > Last I looked ns-win doesn't have any good reason not to use common-win. > > > > It duplicates functions (under new names), the only change is using > > ns-invocation-args instead of x-invocation-args. > > I saw that too. It is all very messy. ns-win was merged before common-win existed, but when the latter was created, only x-win and w32-win were modified to use it. I think, Dan, this was because ns-win was still being cleaned up (partly by me) to better match the other terms, is that correct? So it was just bad timing. Or was the creation of common-win actually prompted by issues raised during the NS port merge? (That's, e.g., where menu.c came from.) I haven't looked at the ns-win code in a while so I'm a little hesitant to attempt the cleanup now, but if someone wants to try I'm happy to answer questions about "why the heck is this thing in there?" etc. and test the resulting changes. thanks, Adrian