From: Adrian Robert <Adrian.B.Robert@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.
Date: Mon, 25 Oct 2010 13:25:53 +0000 (UTC) [thread overview]
Message-ID: <loom.20101025T151345-578@post.gmane.org> (raw)
In-Reply-To: s9r5ff4bo7.fsf@fencepost.gnu.org
Glenn Morris <rgm <at> gnu.org> writes:
>
> Dan Nicolaescu wrote:
>
> > Last I looked ns-win doesn't have any good reason not to use common-win.
> >
> > It duplicates functions (under new names), the only change is using
> > ns-invocation-args instead of x-invocation-args.
>
> I saw that too. It is all very messy.
ns-win was merged before common-win existed, but when the latter was created,
only x-win and w32-win were modified to use it. I think, Dan, this was because
ns-win was still being cleaned up (partly by me) to better match the other
terms, is that correct? So it was just bad timing. Or was the creation of
common-win actually prompted by issues raised during the NS port merge?
(That's, e.g., where menu.c came from.)
I haven't looked at the ns-win code in a while so I'm a little hesitant to
attempt the cleanup now, but if someone wants to try I'm happy to answer
questions about "why the heck is this thing in there?" etc. and test the
resulting changes.
thanks,
Adrian
next prev parent reply other threads:[~2010-10-25 13:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1P9lT2-0005WD-37@internal.in.savannah.gnu.org>
[not found] ` <jwvmxq4pez1.fsf-monnier+emacs@gnu.org>
2010-10-24 2:02 ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Glenn Morris
2010-10-24 5:08 ` Dan Nicolaescu
2010-10-24 19:45 ` Glenn Morris
2010-10-25 13:25 ` Adrian Robert [this message]
2010-10-25 14:51 ` Dan Nicolaescu
2010-10-26 2:59 ` ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-26 4:25 ` ns-win.el Glenn Morris
2010-10-26 4:54 ` ns-win.el CHENG Gao
2010-10-26 5:10 ` ns-win.el Adrian Robert
2010-10-26 15:18 ` ns-win.el Stefan Monnier
2010-10-26 5:07 ` ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Adrian Robert
2010-10-26 6:45 ` ns-win.el Glenn Morris
2010-10-26 7:47 ` ns-win.el Eli Zaretskii
2010-10-26 10:49 ` ns-win.el Adrian Robert
2010-10-26 15:27 ` ns-win.el Stefan Monnier
2010-10-26 19:25 ` ns-win.el Glenn Morris
2010-10-26 19:57 ` ns-win.el Adrian Robert
2010-10-26 6:50 ` ns-win.el Glenn Morris
2010-10-26 7:49 ` ns-win.el Eli Zaretskii
2010-10-26 13:08 ` ns-win.el Ted Zlatanov
2010-10-26 14:42 ` ns-win.el Eli Zaretskii
2010-10-26 17:35 ` ns-win.el Ted Zlatanov
2010-10-26 7:32 ` ns-win.el Daniel Pittman
2010-10-24 7:55 ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Eli Zaretskii
2010-10-24 19:47 ` Glenn Morris
2010-10-25 0:54 ` Stefan Monnier
2010-10-25 4:56 ` Glenn Morris
2010-10-25 8:03 ` Stephen J. Turnbull
2010-10-25 9:28 ` Eli Zaretskii
2010-10-25 8:20 ` Eli Zaretskii
2010-10-28 3:54 ` moving x-select* [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-28 4:06 ` Eli Zaretskii
2010-10-28 5:32 ` Jason Rumney
2010-10-28 6:40 ` Chad Brown
2010-10-28 13:54 ` moving x-select* Jason Rumney
2010-10-28 15:28 ` Chad Brown
2010-10-28 14:23 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20101025T151345-578@post.gmane.org \
--to=adrian.b.robert@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.