From: Paul Sexton <psexton@xnet.co.nz>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org-depend only blocks null->TODO state change
Date: Tue, 27 Jul 2010 01:52:54 +0000 (UTC) [thread overview]
Message-ID: <loom.20100727T034424-868@post.gmane.org> (raw)
In agenda view, tasks which are supposed to be blocked using org-depend's
:BLOCKER: property, are not actually blocked and do not show up dimmed.
This is because of a logic error in 'org-depend-block-undo', hopefully
fixed below.
index eb38aa0..84fa1a7 100644
--- a/d:/paul/dotemacs/site-lisp/org/contrib/lisp/org-depend.el
+++ b/d:/paul/dotemacs/site-lisp/org/contrib/lisp/org-depend-new.el
@@ -224,12 +224,13 @@ this ID property, that entry is also checked."
blocker blockers bl p1
(proceed-p
(catch 'return
- (unless (eq type 'todo-state-change)
- ;; We are not handling this kind of change
- (throw 'return t))
- (unless (and (not from) (member to org-not-done-keywords))
- ;; This is not a change from nothing to TODO, ignore it
- (throw 'return t))
+ ;; If this is not a todo state change, or if this entry is
+ ;; DONE, do not block
+ (when (or (not (eq type 'todo-state-change))
+ (member from (cons 'done org-done-keywords))
+ (member to (cons 'todo org-not-done-keywords))
+ (not to))
+ (throw 'return t))
;; OK, the plan is to switch from nothing to TODO
;; Lets see if we will allow it. Find the BLOCKER property
next reply other threads:[~2010-07-27 1:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 1:52 Paul Sexton [this message]
2010-08-11 7:57 ` [PATCH] org-depend only blocks null->TODO state change Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20100727T034424-868@post.gmane.org \
--to=psexton@xnet.co.nz \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.