From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Seweryn Kokot Newsgroups: gmane.emacs.help Subject: Re: How modify numbers in a region by a multiplier? Date: Mon, 5 Jul 2010 09:49:08 +0000 (UTC) Message-ID: References: <87pqz53g34.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1278323413 26324 80.91.229.12 (5 Jul 2010 09:50:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 5 Jul 2010 09:50:13 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Jul 05 11:50:11 2010 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OViJV-0006mY-TN for geh-help-gnu-emacs@m.gmane.org; Mon, 05 Jul 2010 11:50:10 +0200 Original-Received: from localhost ([127.0.0.1]:33401 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OViJV-00068J-BR for geh-help-gnu-emacs@m.gmane.org; Mon, 05 Jul 2010 05:50:09 -0400 Original-Received: from [140.186.70.92] (port=34641 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OViIj-000672-BX for help-gnu-emacs@gnu.org; Mon, 05 Jul 2010 05:49:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OViIh-0007a4-KI for help-gnu-emacs@gnu.org; Mon, 05 Jul 2010 05:49:21 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:53621) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OViIh-0007Xp-70 for help-gnu-emacs@gnu.org; Mon, 05 Jul 2010 05:49:19 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OViId-0006Mj-M7 for help-gnu-emacs@gnu.org; Mon, 05 Jul 2010 11:49:15 +0200 Original-Received: from 139.191.131.39 ([139.191.131.39]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 05 Jul 2010 11:49:15 +0200 Original-Received: from sewkokot by 139.191.131.39 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 05 Jul 2010 11:49:15 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 67 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: sea.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 139.191.131.39 (Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; GTB6.5; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:74071 Archived-At: Juanma Barranquero gmail.com> writes: > > I see nothing in the docstrings that would suggest that (unless you use > > `narrow-to-region', obviously -- which the original function discussed > > in this thread did *not* use, although it would have been the right > > thing to do IIRC). > > Yes, of course you're right. I was talking about using narrow-to-region. During the weekend I rethought the function I wrote with your help, now I have two versions - one without narrow-to-region and markers and the other with narrow-to-region functions and without markers. Can we say that the second version is more elispy (more elegant and safer) than the first one? ;; first version (defun my-multiply-numbers-in-region-or-buffer (&optional multiplier float- points) (interactive (list (read-number "Specify a multiplier: " 0.001) (read-number "Specify the number of significant figures: " 3))) (let (beg end object end-mark) (if (use-region-p) (progn (setq object "region") (setq beg (region-beginning)) (setq end (region-end))) (setq object "buffer") (setq beg (point-min)) (setq end (point-max))) (setq end-mark (copy-marker end)) (goto-char beg) (while (re-search-forward "\\([0-9.]+\\)" end-mark t) (replace-match (format (concat "%." (number-to-string float- points) "f" ) (* (string-to-number (match-string 1)) multiplier)))) (message "Numbers in %s modified by multiplier %s." object multiplier))) ;; second version (defun my-multiply-numbers-in-region-or-buffer (&optional multiplier float- points) (interactive (list (read-number "Specify a multiplier: " 0.001) (read-number "Specify the number of significant figures: " 3))) (let (beg end object end-mark) (if (use-region-p) (progn (setq object "region") (setq beg (region-beginning)) (setq end (region-end))) (setq object "buffer") (setq beg (point-min)) (setq end (point-max))) (save-restriction (narrow-to-region beg end) ; (setq end-mark (point-max-marker)) (goto-char (point-min)) ; (while (re-search-forward "\\([0-9.]+\\)" end-mark t) (while (re-search-forward "\\([0-9.]+\\)" nil t) (replace-match (format (concat "%." (number-to-string float- points) "f" ) (* (string-to-number (match-string 1)) multiplier)))) (message "Numbers in %s modified by multiplier %s." object multiplier))))