From: Michael Mauger <mmaug@yahoo.com>
Subject: Re: delete-process bug
Date: Fri, 26 May 2006 17:27:36 +0000 (UTC) [thread overview]
Message-ID: <loom.20060526T191549-416@post.gmane.org> (raw)
In-Reply-To: jwvhd3dndh1.fsf-monnier+emacs@gnu.org
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
> > Thanks for working on this. I agree that `live_deleted_processes'
> > is a good name. ("Zombie process" has a different meaning.)
>
> > However, maybe there is still a race condition. Suppose the signal
> > comes in the middle of the line
>
> > + live_deleted_processes = Fcons (make_number (p->pid),
> > + /* GC previous elements. */
> > + Fdelq (Qnil,
live_deleted_processes));
>
> > Suppose it comes between there and the call to remove_process?
>
> I think it's OK: if the signal handler comes before the assignment to
> live_deleted_processes, then it'll all behave as if the signal came even
> before the call to delete-process. If it comes afterwards, the signal will
> be ignored (as if it came after the call to delete-process).
>
> > Does the right thing happen in all these cases?
>
> I believe so.
>
My instinct would be to add the pid to the list prior to causing the event that
the list is designed to detect. Treating the signal as though it happened
before the call to delete-process (if we don't add the pid to the list first)
when we know it was most likely caused by delete-process seems to be asking for
trouble.
Just sayin'...
next prev parent reply other threads:[~2006-05-26 17:27 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 19:36 Ispell loads dict twice Michaël Cadilhac
2006-04-26 10:14 ` Agustin Martin
2006-04-26 21:58 ` Michaël Cadilhac
2006-05-23 18:26 ` Michaël Cadilhac
2006-05-24 11:28 ` Agustin Martin
2006-05-25 10:57 ` delete-process bug (was: Ispell loads dict twice.) Michaël Cadilhac
2006-05-25 12:19 ` Agustin Martin
2006-05-25 14:55 ` delete-process bug Stefan Monnier
2006-05-25 14:59 ` David Kastrup
2006-05-25 15:17 ` Michaël Cadilhac
2006-05-25 15:26 ` David Kastrup
2006-05-25 19:40 ` Stefan Monnier
2006-05-25 23:51 ` Kim F. Storm
2006-05-26 4:49 ` Richard Stallman
2006-05-26 13:03 ` Stefan Monnier
2006-05-26 2:22 ` Richard Stallman
2006-05-26 11:29 ` Michaël Cadilhac
2006-05-27 3:36 ` Richard Stallman
2006-05-26 13:10 ` Stefan Monnier
2006-05-26 17:27 ` Michael Mauger [this message]
2006-05-27 9:19 ` Michaël Cadilhac
2006-05-27 14:16 ` Stefan Monnier
2006-05-27 14:29 ` Michaël Cadilhac
2006-05-28 16:01 ` Michaël Cadilhac
2006-05-28 18:00 ` Stefan Monnier
2006-05-28 18:32 ` Michaël Cadilhac
2006-05-28 19:48 ` Stefan Monnier
2006-05-28 20:26 ` Michaël Cadilhac
2006-05-28 21:15 ` Kim F. Storm
2006-05-28 21:36 ` Michaël Cadilhac
2006-05-28 23:54 ` Stefan Monnier
2006-05-29 11:39 ` Michaël Cadilhac
2006-05-29 8:22 ` Kim F. Storm
2006-05-29 8:50 ` David Kastrup
2006-05-29 19:04 ` Eli Zaretskii
2006-05-29 19:27 ` Eli Zaretskii
2006-05-29 21:42 ` Kim F. Storm
2006-05-29 22:08 ` Eli Zaretskii
2006-05-29 3:32 ` Eli Zaretskii
2006-05-29 8:14 ` Kim F. Storm
2006-05-29 10:59 ` Michaël Cadilhac
2006-05-29 19:25 ` Eli Zaretskii
2006-05-29 20:04 ` Michaël Cadilhac
2006-05-29 21:24 ` Eli Zaretskii
2006-05-29 21:42 ` Michaël Cadilhac
2006-05-29 22:11 ` Eli Zaretskii
2006-05-29 22:32 ` Michaël Cadilhac
2006-05-30 12:11 ` Kim F. Storm
2006-05-30 12:42 ` Michaël Cadilhac
2006-05-30 14:26 ` Kim F. Storm
2006-05-30 15:13 ` Michaël Cadilhac
2006-06-01 14:06 ` Kim F. Storm
2006-06-01 14:20 ` Michaël Cadilhac
2006-06-01 14:29 ` Kim F. Storm
2006-06-01 16:05 ` Michaël Cadilhac
2006-06-02 7:46 ` Kim F. Storm
2006-06-01 16:41 ` Agustin Martin
2006-06-01 16:55 ` Michaël Cadilhac
2006-05-29 23:07 ` Agustin Martin
2006-05-25 23:52 ` delete-process bug (was: Ispell loads dict twice.) Kim F. Storm
2006-06-06 20:45 ` Ispell loads dict twice Michaël Cadilhac
2006-06-09 13:02 ` Kim F. Storm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20060526T191549-416@post.gmane.org \
--to=mmaug@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.