remember problem in 4.33?

remember problem in 4.33?

[Philip Rooke]

Carsten,

I was going to report a GC/lock-up issue in 4.32 which happened when saving a
template based remember item.  That is, at the end of:

M-x remember [edit a level 1 item] C-c C-c <ret><ret>

...but you all are far too quick for me!

I've just upgraded to 4.33.  I do not seem to get the GC "loop" but now the
temporary remember buffer is not killed.  Run under debug-on-error I get:

Debugger entered--Lisp error: (error "Kill ring is empty")
  signal(error ("Kill ring is empty"))
  error("Kill ring is empty")
  current-kill(0)
  (eq org-subtree-clip (current-kill 0))
  (and (eq org-subtree-clip (current-kill 0)) org-subtree-clip-folded)
  (if (and (eq org-subtree-clip ...) org-subtree-clip-folded) (hide-subtree))
[snip some very long lines]
  org-remember-handler()
  run-hook-with-args-until-success(org-remember-handler)
  remember-region(1 52)
  remember-buffer()
  funcall(remember-buffer)
[snip] 
  org-ctrl-c-ctrl-c(nil)
  call-interactively(org-ctrl-c-ctrl-c)

Phil

Re: remember problem in 4.33?

[Carsten Dominik]

Looks like you have been running remember early in an Emacs session, 
without killing anything yet.

Maybe the following patch does fix this problem?

- Carsten

--- org.el.orig	Wed May 24 11:39:48 2006
+++ org.el	Wed May 24 11:46:42 2006
@@ -3797,7 +3797,8 @@
  	(goto-char (point-min))
  	(message "Pasted at level %d, with shift by %d levels"
  		 new-level shift1)))
-    (if (and (eq org-subtree-clip (current-kill 0))
+    (if (and kill-ring
+	     (eq org-subtree-clip (current-kill 0))
  	     org-subtree-clip-folded)
  	;; The tree was folded before it was killed/copied
  	(hide-subtree))))







On May 24, 2006, at 10:49, Philip Rooke wrote:

> Carsten,
>
> I was going to report a GC/lock-up issue in 4.32 which happened when 
> saving a
> template based remember item.  That is, at the end of:
>
> M-x remember [edit a level 1 item] C-c C-c <ret><ret>
>
> ...but you all are far too quick for me!
>
> I've just upgraded to 4.33.  I do not seem to get the GC "loop" but 
> now the
> temporary remember buffer is not killed.  Run under debug-on-error I 
> get:
>
> Debugger entered--Lisp error: (error "Kill ring is empty")
>   signal(error ("Kill ring is empty"))
>   error("Kill ring is empty")
>   current-kill(0)
>   (eq org-subtree-clip (current-kill 0))
>   (and (eq org-subtree-clip (current-kill 0)) org-subtree-clip-folded)
>   (if (and (eq org-subtree-clip ...) org-subtree-clip-folded) 
> (hide-subtree))
> [snip some very long lines]
>   org-remember-handler()
>   run-hook-with-args-until-success(org-remember-handler)
>   remember-region(1 52)
>   remember-buffer()
>   funcall(remember-buffer)
> [snip]
>   org-ctrl-c-ctrl-c(nil)
>   call-interactively(org-ctrl-c-ctrl-c)
>
> Phil
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>

--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477

Re: remember problem in 4.33?

[Philip Rooke]

Carsten Dominik <dominik <at> science.uva.nl> writes:

> Looks like you have been running remember early in an Emacs session, 
> without killing anything yet.

Yes, thinking about it I believe you are right.

> Maybe the following patch does fix this problem?

Thanks, that seems to work nicely.

On a vaguely related point, I have just changed one of my remember templates to
insert a level one headline (previously they were all level two).  On saving
though this is converted to a level two heading.  Is there anything I can do
about that?

Regards,

Phil