Re: Crashes with latest font code

[YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>]

Richard Stallman <rms <at> gnu.org> writes:

> 
>     Richard's latest changes to the font handling code (which are not
>     documented in src/ChangeLog) cause very reliable crashes with my setup.
> 
> I am surprised the new code behaves differently from the old.  Can you
> figure out why?  It must be some tiny bug.
> 

I'm not sure if this is a right fix, but I could avoid similar
crashes on my side with the following change.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Index: src/xfaces.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xfaces.c,v
retrieving revision 1.347
diff -c -r1.347 xfaces.c
*** src/xfaces.c	17 May 2006 22:51:07 -0000	1.347
--- src/xfaces.c	20 May 2006 03:38:09 -0000
***************
*** 6636,6642 ****
    best = NULL;
  
    /* Find the best match among the non-scalable fonts.  */
!   for (i = 1; i < nfonts; ++i)
      if (!font_scalable_p (fonts + i)
  	&& better_font_p (specified, fonts + i, best, 1, avgwidth))
        {
--- 6636,6642 ----
    best = NULL;
  
    /* Find the best match among the non-scalable fonts.  */
!   for (i = 0; i < nfonts; ++i)
      if (!font_scalable_p (fonts + i)
  	&& better_font_p (specified, fonts + i, best, 1, avgwidth))
        {