From: Michael Mauger <mmaug@yahoo.com>
Subject: Re: list-colors-display: display all color names
Date: Wed, 29 Dec 2004 14:46:19 +0000 (UTC) [thread overview]
Message-ID: <loom.20041229T152936-153@post.gmane.org> (raw)
In-Reply-To: 87d5wwsuly.fsf@jurta.org
Juri Linkov <juri <at> jurta.org> writes:
>
> It's too bad that `list-colors-display' currently doesn't contain
> all variants of color names with alternative spellings and spaces.
> When I put a color name into the search ring in one buffer and then
> isearch it with C-s C-s in the *Colors* buffer to see how the color
> looks, often the search fails. I need to edit the search string
> to add spaces or change the spelling of color names and to try again.
> This is very inconvenient. The *Colors* buffer should contain all
> color names, even duplicates with the same color values.
>
> ...
>
> This eliminates the need to identify duplicate colors by the name.
>
I like this idea except for this last bit.
We changed `list-colors-display' to match by name rather than color value so
that if "System" colors were added to the list they wouldn't be merged
together. The examples in the original post are all aliases for the same
color. They can be used interchangably on any platform with reasonable results.
The System colors are designed to make window manager theme colors available
within Emacs so that faces can follow the corresponding colors in the rest of
the GUI. If the colors "SystemMenuText" and "SystemText" happen to be mapped
to the same color it does not mean that they are aliases for the same color.
Under a different window manager theme they might be different colors. In this
case these color names are not interchangable and should not be presented as if
they were alaises.
The comment removed from the code was supposed to explain this clearly.
Obviously it did not.
Does matching on the name rather than the color value result in a different
output with your other changes? Should we match on color value unless the name
starts with the string "System"?
--
Michael Mauger
next prev parent reply other threads:[~2004-12-29 14:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-26 19:45 list-colors-display: display all color names Juri Linkov
2004-12-28 4:57 ` Richard Stallman
2005-01-04 9:07 ` Juri Linkov
2005-01-04 16:37 ` Drew Adams
2005-01-04 21:09 ` Eli Zaretskii
2005-01-04 21:57 ` Stefan Monnier
2005-01-05 5:38 ` Juri Linkov
2005-01-05 18:12 ` Drew Adams
2005-01-05 19:11 ` Eli Zaretskii
2005-01-05 19:21 ` Edward O'Connor
2005-01-06 4:35 ` Eli Zaretskii
2005-01-05 5:32 ` Juri Linkov
2005-01-05 18:12 ` Drew Adams
2005-01-05 19:13 ` Eli Zaretskii
2005-01-05 18:59 ` Eli Zaretskii
2005-01-05 19:46 ` Drew Adams
2005-01-06 4:50 ` Eli Zaretskii
2005-01-06 8:27 ` Juri Linkov
2005-01-06 9:05 ` Miles Bader
2005-01-06 10:44 ` Juri Linkov
2005-01-05 20:08 ` Richard Stallman
2005-01-05 3:30 ` Richard Stallman
2005-01-06 8:29 ` Juri Linkov
2004-12-29 14:46 ` Michael Mauger [this message]
2004-12-29 19:02 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20041229T152936-153@post.gmane.org \
--to=mmaug@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.