Revised lisp/progmodes/flymake.el

[CHENG Gao <chenggao@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

Reading FOR-RELEASE, I fuond it's desirable to revise flymake.el to
conform with Emacs Lisp Coding Conventions. Though my ELISP knowledge is
very limited, I think I can have a try for this too hard job.

Attached is a revised flymake.el. What I have done includes:
1. Removed XEmacs compatibility code. I think it does not make sense to
maintain XEmacs compatibility with Emacs bundled files.

2. Following Coding Conventions to remove close-parentheses on lines by
   themselves.

3. Restructure and rewrite document strings to tips for documentation
   strings.
But for some functions that I dont know their purposes, I just
capitalized the first letter and add period at the end.

4. Add eval-when-compile to one occurence or (require 'compile).

5. To accomodate documentation string, I changed function
flymake-get-common-path-prefix from 
flymake-get-common-path-prefix (string-one string-two)
to
flymake-get-common-path-prefix (path1 path2)
and change the code to use new arg names.

Though as an ELISP newbie, I think flymake.el is coded badly. Just wish
my work can be help to real gurus to make a clean file.
At least there is no compilation errors/warnings for my revised file.


[-- Attachment #2: flymake.el --]
[-- Type: application/emacs-lisp, Size: 82715 bytes --]

[-- Attachment #3: Type: text/plain, Size: 39 bytes --]


-- 
这去者，不能见他的脸，背影模糊。


[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel