From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: xristos Newsgroups: gmane.emacs.bugs Subject: bug#31704: 26.1; tramp-remote-path/shell: broken executable completion Date: Sun, 03 Jun 2018 21:32:09 -0400 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528096928 8902 195.159.176.226 (4 Jun 2018 07:22:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 4 Jun 2018 07:22:08 +0000 (UTC) To: 31704@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 04 09:22:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPjoY-0002AO-Mh for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jun 2018 09:22:02 +0200 Original-Received: from localhost ([::1]:38028 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPjqf-0001qA-Ew for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jun 2018 03:24:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPjqX-0001pu-Tz for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 03:24:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPjqU-0000d7-PM for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 03:24:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52913) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPjqU-0000d3-Ll for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 03:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fPjqU-0005We-CJ for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 03:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: xristos Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jun 2018 07:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31704 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152809701621199 (code B ref -1); Mon, 04 Jun 2018 07:24:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Jun 2018 07:23:36 +0000 Original-Received: from localhost ([127.0.0.1]:60808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPjq3-0005Vo-T4 for submit@debbugs.gnu.org; Mon, 04 Jun 2018 03:23:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPeM9-0005Yy-Bo for submit@debbugs.gnu.org; Sun, 03 Jun 2018 21:32:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPeM3-0003Eo-Dc for submit@debbugs.gnu.org; Sun, 03 Jun 2018 21:32:16 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fPeM3-0003Ek-9I for submit@debbugs.gnu.org; Sun, 03 Jun 2018 21:32:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPeM2-0002Sz-3p for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 21:32:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPeLy-0003DX-Vv for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 21:32:14 -0400 Original-Received: from mail.suspicious.org ([104.131.63.74]:34602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPeLy-0003DJ-SB for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 21:32:10 -0400 Original-Received: from samadhi.lan (unknown [204.11.85.76]) (Authenticated sender: night) by mail.suspicious.org (Postfix) with ESMTPSA id D46871400E3 for ; Sun, 3 Jun 2018 21:32:09 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Mon, 04 Jun 2018 03:23:35 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146938 Archived-At: The issue lies in shell--command-completion-data which is called by shell-command-completion, it only checks directories in exec-path (local) rather than tramp-remote-path. This bug also leaks the local exec-path to the remote server. To reproduce: emacs -Q Evaluate: (require 'tramp) ;; For debugging (setq tramp-persistency-file-name nil tramp-verbose 10) (add-to-list 'tramp-remote-path 'tramp-own-remote-path) ;; Assuming an account 'chris' exists at server 'remote', ;; to see the issue clearly make sure that there exists ;; a directory in the remote server PATH (e.g. ~/bin/) ;; but NOT in exec-path. (let ((default-directory "/ssh:chris@remote:")) (shell "*remote*")) ;; Assuming executable 'testbin' exists in remote server ~/bin/ ;; and not inside any directory in exec-path: remote$ testb ;; No completion M-: (add-to-list 'exec-path "~/bin/") remote$ testb ;; Completes fine If one checks the tramp debug buffer, one will see tramp checking (and leaking information to the remote server) all the directories that exist in the local exec-path.