From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#20063: 24.4: read-from-minibuffer improperly setting hist parameter Date: Sun, 08 Mar 2015 21:08:57 -0400 Message-ID: References: <54FCCC63.5080202@gmx.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1425863353 6133 80.91.229.3 (9 Mar 2015 01:09:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Mar 2015 01:09:13 +0000 (UTC) Cc: 20063@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 09 02:09:07 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YUmBu-0007ou-Lm for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Mar 2015 02:09:06 +0100 Original-Received: from localhost ([::1]:41027 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUmBu-0007Ww-1b for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Mar 2015 21:09:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUmBq-0007Wq-SH for bug-gnu-emacs@gnu.org; Sun, 08 Mar 2015 21:09:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUmBq-0003HK-5G for bug-gnu-emacs@gnu.org; Sun, 08 Mar 2015 21:09:02 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUmBq-0003HG-2R for bug-gnu-emacs@gnu.org; Sun, 08 Mar 2015 21:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YUmBp-0003mD-M9 for bug-gnu-emacs@gnu.org; Sun, 08 Mar 2015 21:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Mar 2015 01:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20063-submit@debbugs.gnu.org id=B20063.142586334014508 (code B ref 20063); Mon, 09 Mar 2015 01:09:01 +0000 Original-Received: (at 20063) by debbugs.gnu.org; 9 Mar 2015 01:09:00 +0000 Original-Received: from localhost ([127.0.0.1]:39897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUmBo-0003lw-1g for submit@debbugs.gnu.org; Sun, 08 Mar 2015 21:09:00 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:50787 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUmBm-0003lo-7H for 20063@debbugs.gnu.org; Sun, 08 Mar 2015 21:08:58 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YUmBl-0003SD-Is; Sun, 08 Mar 2015 21:08:57 -0400 X-Spook: smuggle Reno Fedayeen crypto anarchy colonel South Africa X-Ran: LJ-e`V3-';12"|]O|?lJWCqDp\{1>Hf&rnJ/ (Boruch Baum's message of "Sun, 08 Mar 2015 18:25:39 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100302 Archived-At: Boruch Baum wrote: > Function `toggle-option' calls `completing-read', without providing > parameters REQUIRE-MATCH or HIST. `completing-read' calls > `completing-read-default' in `minibuffer.el'. `completing-read-default' > calls `read-from-minibuffer' in `minibuf.c'. There, on line 974 of > `minibuf.c:' > > if (NILP (histvar)) > histvar = Qminibuffer_history; > > If I understand this correctly, this says that even if the caller > explicitly says that there should be no history used (condition nil), > the Qminibuffer_history should be used anyway. Nil means use the default history list. Eg see "Minibuffer History" in the elisp manual: If you don't specify HISTORY, then the default history list `minibuffer-history' is used. I don't see a bug here, other than perhaps the doc of completing-read could stand to be more explicit, like the elisp manual is.