From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#14967: 24.3.50; package-delete deletes by trashing? Date: Mon, 19 Jun 2017 14:47:52 -0400 Message-ID: References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> <83y3sx414w.fsf@gnu.org> <83shj53zo1.fsf@gnu.org> <87r2yp2dmw.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1497898156 4191 195.159.176.226 (19 Jun 2017 18:49:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Jun 2017 18:49:16 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: lunaryorn@gmail.com, Stefan Monnier , Alex , npostavs@users.sourceforge.net To: 14967@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 19 20:49:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dN1jX-0000XH-19 for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Jun 2017 20:49:07 +0200 Original-Received: from localhost ([::1]:43909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dN1jZ-0004XL-JA for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Jun 2017 14:49:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dN1jT-0004Sc-3X for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2017 14:49:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dN1jS-0002g8-9U for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2017 14:49:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53848) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dN1jS-0002g3-5Q for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2017 14:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dN1jR-0007iZ-VJ for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2017 14:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jun 2017 18:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14967 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 14967-submit@debbugs.gnu.org id=B14967.149789808329584 (code B ref 14967); Mon, 19 Jun 2017 18:49:01 +0000 Original-Received: (at 14967) by debbugs.gnu.org; 19 Jun 2017 18:48:03 +0000 Original-Received: from localhost ([127.0.0.1]:56522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dN1iU-0007h6-Se for submit@debbugs.gnu.org; Mon, 19 Jun 2017 14:48:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dN1iT-0007gb-5p for 14967@debbugs.gnu.org; Mon, 19 Jun 2017 14:48:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dN1iN-0002Ex-5C for 14967@debbugs.gnu.org; Mon, 19 Jun 2017 14:47:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dN1iN-0002Ep-19; Mon, 19 Jun 2017 14:47:55 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dN1iL-0001jd-2m; Mon, 19 Jun 2017 14:47:53 -0400 X-Spook: Fort Hancock rail gun Mena Hazmat investigation Indigo X-Ran: L}O+C'y}T8S|iW7=&>/{U~qMS+{]'Qx&!o7AeSM;qh9y=^T)h]v3ratE6?c7fn(0@I X-Hue: red X-Attribution: GM In-Reply-To: (Glenn Morris's message of "Mon, 12 Jun 2017 16:32:22 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133767 Archived-At: I've applied the following. IMO if Emacs wants to behave like system package managers (eg yum, apt), it should (optionally) cache the _source_ when it downloads a package. Then use that (if appropriate) if asked to (re)install. commit 65b323e (HEAD, master) Date: Mon Jun 19 14:39:25 2017 -0400 Don't put deleted packages in the trash (bug#14967) * lisp/emacs-lisp/package.el (package-delete): Don't pay attention to delete-by-moving-to-trash. ; * etc/NEWS: Mention this. diff --git a/etc/NEWS b/etc/NEWS index 85d1273..78d37484 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -755,6 +755,9 @@ header's value. where the GnuPG home directory (used for signature verification) is located and whether GnuPG's option "--homedir" is used or not. +--- +*** Deleting a package no longer respects 'delete-by-moving-to-trash'. + ** Tramp +++ diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index bebfd18..4245294 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2127,7 +2127,7 @@ If NOSAVE is non-nil, the package is not removed from (package-desc-name pkg-used-elsewhere-by))) (t (add-hook 'post-command-hook #'package-menu--post-refresh) - (delete-directory dir t t) + (delete-directory dir t) ;; Remove NAME-VERSION.signed and NAME-readme.txt files. (dolist (suffix '(".signed" "readme.txt")) (let* ((version (package-version-join (package-desc-version pkg-desc)))