bug#14823: file-notify-tests should be expected to fail when no file notificatio package

bug#14823: file-notify-tests should be expected to fail when no file notificatio package

[Glenn Morris]

Package: emacs
Version: 24.3.50

Current trunk for me on GNU/Linux:

cd test/automated
../../src/emacs -Q -batch -l ./file-notify-tests.el \
  -f ert-run-tests-batch-and-exit 

3 unexpected results:
   FAILED  file-notify-test00-availability
   FAILED  file-notify-test01-add-watch
   FAILED  file-notify-test02-events

Test file-notify-test02-events condition:
    (file-notify-error "No file notification package available")


These tests should have ":expected-result :failed" when no file
notification package is available. (Ideally, they would be skipped, but
ert does not have that feature so :expected-result is the best we can do
at present.)

bug#14823: file-notify-tests should be expected to fail when no file notificatio package

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

> These tests should have ":expected-result :failed" when no file
> notification package is available. (Ideally, they would be skipped, but
> ert does not have that feature so :expected-result is the best we can do
> at present.)

Should be fixed now, could you please check?

When ert has a real skip feature, we could handle also the case to run
the tests for remote file systems, even when no file notification
package has been linked with Emacs. For now, we don't run them in this
case.

Best regards, Michael.

bug#14823: file-notify-tests should be expected to fail when no file notificatio package

[Glenn Morris]

Michael Albinus wrote:

> Should be fixed now, could you please check?

Yes thanks.