From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#72228: 31.0.50; Wrong number fontification in cmake-ts-mode Date: Wed, 07 Aug 2024 01:00:01 +0000 Message-ID: References: <875xszm205.fsf.ref@aol.com> <875xszm205.fsf@aol.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_XUx89WsU4AnHVA70iDfj0ksuaeVh4XJR3xzPfHJFY" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16135"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72228@debbugs.gnu.org To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 07 03:03:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbV4w-00040c-ME for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Aug 2024 03:03:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbV4b-0006ur-57; Tue, 06 Aug 2024 21:02:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbV4X-0006uW-VL for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 21:02:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbV4X-0008Sh-Lz for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 21:02:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=EBhsqhIx00zFAjcGBAeFeqwQ/gjlN2OmfaEzq3xl7X0=; b=Vg+d9HdRvS2yV1lScNIESOAzsUMXEF2iCsYiGOkbxqZoYLNEawIrUyo9Tb3K13KIur1zsbNXzkCIs0TT7JbID35ztdeh7RvfP1KbysgvTiYhzi9asyDTgqrFDZ8o0bzXD82TDYgZNH+cgdusNbI7Mbx3KkPJPmvpuAuJPpuffVvKZMY+F2WAERG84oHX7CNZOU3noW+ey6o+tXuHyRiv2ATrHjLoKCQoKoZb1ou4qxx2d4ZiUhLYTd6GWnmL2qD89UC5Qvn/bGo1t62qOksXxGkGGcjyhlilJfMx8sFgxo539f20FuYP0BybXxKJM0xxlMijKN7cOPQx8L62ild7/Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbV4v-0008Dy-Qp for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 21:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Aug 2024 01:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72228 X-GNU-PR-Package: emacs Original-Received: via spool by 72228-submit@debbugs.gnu.org id=B72228.172299253331556 (code B ref 72228); Wed, 07 Aug 2024 01:03:01 +0000 Original-Received: (at 72228) by debbugs.gnu.org; 7 Aug 2024 01:02:13 +0000 Original-Received: from localhost ([127.0.0.1]:33379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbV48-0008Ct-Sc for submit@debbugs.gnu.org; Tue, 06 Aug 2024 21:02:13 -0400 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:13901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbV44-0008Ce-PO for 72228@debbugs.gnu.org; Tue, 06 Aug 2024 21:02:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1722992497; x=1723251697; bh=EBhsqhIx00zFAjcGBAeFeqwQ/gjlN2OmfaEzq3xl7X0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=CivzXKYPDiuh5+zeD55nm1u/dQS5sRh7t1Zuqc5Gr1f3JIfo29T2neCvmV+///spF Uo2FjkEExpxKMH41IBqpEQJAVeWY7LRFuPUf3WRTjMuPvb9uxLsU9asST62F9Mabke xnR/EjSrzy10s4hd6uBkwIGs9pzivQcZVwTGAZJy560FYLTWJfETZTtzMIH3P+d2qI 0k5GRs3g76v6Fi0/7MDIwHuo9bB5+gOW7pkBm7ZhggOLKl/pX7Y91xxBGGWQ8yWDUI o6qO5GRmN1guiPeuvMbOlsofRAF2CJfgs+w6zJ0y+AmL+Y2hn1yNxbCej3Hnnx3BEC yaKXRN47PQIZg== In-Reply-To: Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 8de12d3106e3025b1237d2ab8184b82c7b5ff4c9 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289862 Archived-At: This is a multi-part message in MIME format. --b1_XUx89WsU4AnHVA70iDfj0ksuaeVh4XJR3xzPfHJFY Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Monday, July 22nd, 2024 at 22:32, Randy Taylor wrote: >=20 >=20 > On Sunday, July 21st, 2024 at 07:13, Ergus via "Bug reports for GNU Emacs= , the Swiss army knife of text editors" bug-gnu-emacs@gnu.org wrote: >=20 > > When using cmake-ts-mode the numbers have 3 different faces: > >=20 > > 1, 2, 100: font-lock-number-face (OK) > >=20 > > 0 : font-lock-constant-face. The cmake-ts-mode--constants takes > > precedence over regex in font-lock-number-face. It is not clear that > > this one can be fixed. >=20 >=20 > 1 also gets font-lock-constant-face. >=20 > I think we should just remove "1" and "0" from cmake-ts-mode--constants. >=20 > > -1, -2 : Not fontified. This seems simpler to fix, the regex in > > font-lock-number-face is missing a `-?' before the first [[:digit:]]) >=20 >=20 > Indeed. Would you like to submit a patch for that and the above? I haven't heard anything back, so I've attached a patch doing so. --b1_XUx89WsU4AnHVA70iDfj0ksuaeVh4XJR3xzPfHJFY Content-Type: text/x-patch; name=0001-Fix-cmake-ts-mode-number-fontification-Bug-72228.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-cmake-ts-mode-number-fontification-Bug-72228.patch RnJvbSA0YTEwNGJkMTFmNTZkY2IwMTM2YjMyODUyZDE0NzU2ZTBmMTNjOWQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBUdWUs IDYgQXVnIDIwMjQgMjA6MTA6NTIgLTA0MDAKU3ViamVjdDogW1BBVENIXSBGaXggY21ha2UtdHMt bW9kZSBudW1iZXIgZm9udGlmaWNhdGlvbiAoQnVnIzcyMjI4KQoKKiBsaXNwL3Byb2dtb2Rlcy9j bWFrZS10cy1tb2RlLmVsIChjbWFrZS10cy1tb2RlLS1jb25zdGFudHMpOgpSZW1vdmUgIjEiIGFu ZCAiMCIuCihjbWFrZS10cy1tb2RlLS1mb250LWxvY2stc2V0dGluZ3MpOiBNYXRjaCBuZWdhdGl2 ZSBudW1iZXJzLgotLS0KIGxpc3AvcHJvZ21vZGVzL2NtYWtlLXRzLW1vZGUuZWwgfCA1ICsrLS0t CiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2xpc3AvcHJvZ21vZGVzL2NtYWtlLXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy9j bWFrZS10cy1tb2RlLmVsCmluZGV4IGI3MDgwNmY0YzMwLi44NTRhZGY0YWRlNyAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvY21ha2UtdHMtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9j bWFrZS10cy1tb2RlLmVsCkBAIC03Myw4ICs3Myw3IEBAIGNtYWtlLXRzLW1vZGUtLWluZGVudC1y dWxlcwogICAiVHJlZS1zaXR0ZXIgaW5kZW50IHJ1bGVzIGZvciBgY21ha2UtdHMtbW9kZScuIikK IAogKGRlZnZhciBjbWFrZS10cy1tb2RlLS1jb25zdGFudHMKLSAgJygiMSIgIk9OIiAiVFJVRSIg IllFUyIgIlkiICIwIiAiT0ZGIiAiRkFMU0UiICJOTyIgIk4iICJJR05PUkUiCi0gICAgIk5PVEZP VU5EIikKKyAgJygiT04iICJUUlVFIiAiWUVTIiAiWSIgIk9GRiIgIkZBTFNFIiAiTk8iICJOIiAi SUdOT1JFIiAiTk9URk9VTkQiKQogICAiQ01ha2UgY29uc3RhbnRzIGZvciB0cmVlLXNpdHRlciBm b250LWxvY2tpbmcuIikKIAogKGRlZnZhciBjbWFrZS10cy1tb2RlLS1rZXl3b3JkcwpAQCAtMTY0 LDcgKzE2Myw3IEBAIGNtYWtlLXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncwogICAgOmxhbmd1 YWdlICdjbWFrZQogICAgOmZlYXR1cmUgJ251bWJlcgogICAgJygoKHVucXVvdGVkX2FyZ3VtZW50 KSBAZm9udC1sb2NrLW51bWJlci1mYWNlCi0gICAgICAoOm1hdGNoICJcXGBbWzpkaWdpdDpdXSpc XC4/W1s6ZGlnaXQ6XV0qXFwuP1tbOmRpZ2l0Ol1dK1xcJyIKKyAgICAgICg6bWF0Y2ggIlxcYC0/ W1s6ZGlnaXQ6XV0qXFwuP1tbOmRpZ2l0Ol1dKlxcLj9bWzpkaWdpdDpdXStcXCciCiAgICAgICAg ICAgICAgIEBmb250LWxvY2stbnVtYmVyLWZhY2UpKSkKIAogICAgOmxhbmd1YWdlICdjbWFrZQot LSAKMi40Ni4wCgo= --b1_XUx89WsU4AnHVA70iDfj0ksuaeVh4XJR3xzPfHJFY--