From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#59979: 30.0.50; dockerfile-ts-mode imenu issue Date: Mon, 12 Dec 2022 02:30:28 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_Qjx0tQRLpbbgPXWMP0wR8rri8c5YK44wTY7AdQmSMg" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21799"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59979@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 03:31:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4YbI-0005Sw-AB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 03:31:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4Yb5-0004K9-FW; Sun, 11 Dec 2022 21:31:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Yb0-0004It-Fy for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 21:31:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4Yas-0005WU-3C for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 21:31:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4Yar-0006It-V9 for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 21:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 02:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59979 X-GNU-PR-Package: emacs Original-Received: via spool by 59979-submit@debbugs.gnu.org id=B59979.167081224924220 (code B ref 59979); Mon, 12 Dec 2022 02:31:01 +0000 Original-Received: (at 59979) by debbugs.gnu.org; 12 Dec 2022 02:30:49 +0000 Original-Received: from localhost ([127.0.0.1]:49640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Yae-0006Ia-NG for submit@debbugs.gnu.org; Sun, 11 Dec 2022 21:30:49 -0500 Original-Received: from mail-4317.proton.ch ([185.70.43.17]:54459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Yac-0006II-JC for 59979@debbugs.gnu.org; Sun, 11 Dec 2022 21:30:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670812239; x=1671071439; bh=a8LJKsaRtBsaVJgbQAiJgfASbyWFt4VMHPyqNz9/70k=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ZNb+MSaLq6oRmrjh9VpVaLNAuKoBgqX3dRBkb70KM8xLb1cKLmewQeBY8opvPhTHl 0TIt+WC6akfcwcEFeHtxodZmkWSjg+8nLJRpU6j+WD3v5zo90wdFoJEZmghQKNQ/4e D6WX1dBd5dWDNt3Gr3J7obRsq96EsjElm+z1pQwRAxRyZp69ubW4QCy8Nbitkmcjqq yWnxejdkjQWWqo/rEXICnyrTlhLorHzwh2YP948yqAo7kvtN32kjudt1HVdwmz7JsO kxaEdcAfHh5VdmYyJB0IMbiy+4ueRRPNr78W+Wx3vPOPosGPA12PPLm51NTTmQ1C3h k6q/LH2Jv9gRg== In-Reply-To: Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250669 Archived-At: This is a multi-part message in MIME format. --b1_Qjx0tQRLpbbgPXWMP0wR8rri8c5YK44wTY7AdQmSMg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sunday, December 11th, 2022 at 18:57, Randy Taylor wrote: >=20 > On Sunday, December 11th, 2022 at 15:39, Eshel Yaron via "Bug reports for= GNU Emacs, the Swiss army knife of text editors" bug-gnu-emacs@gnu.org wro= te: >=20 > > I stumbled upon the following issue while checking out the new > > dockerfile-ts-mode. > >=20 > > 1. emacs -Q > > 2. C-x C-f /tmp/Dockerfile > > 3. Insert the following contents (taken from > > https://docs.docker.com/build/building/multi-stage/#use-a-previous-stag= e-as-a-new-stage): > >=20 > > FROM ubuntu AS base > > RUN echo "base" > >=20 > > FROM base AS stage1 > > RUN echo "stage1" > >=20 > > FROM base AS stage2 > > RUN echo "stage2" > >=20 > > 4. Try to use M-x imenu to navigate to the last build stage > > 4.a. We get the following imenu--index-alist: > >=20 > > (("Stage" > > ("ubuntu" . #) > >=20 > > ("base" . #) > >=20 > > ("base" . #))) > >=20 > > 4.b. Consequently, we can't choose and jump to the last stage, because > > dockerfile-ts-mode calls both of the last two stages by the same name > > ("base"). > >=20 > > The crux of the issue is that dockerfile-ts-mode uses a stage's base > > image as its name, which seems kinda wrong and leads to ambiguity since > > many stages can have a common base image. Instead, it would be > > preferable IMO to use the index of the stage or, when available, its > > unique name (such as "stage1" in the example above). > >=20 > > Thanks! >=20 >=20 > Thanks, I'll take a look and hopefully reply back with a patch in a bit. >=20 I didn't notice this because I use conult-imenu, which will add an index fo= r any duplicates. imenu doesn't do this, and for other modes like c-mode, c= ++-mode, org-mode, etc., only the first entry gets shown. I've attached a patch which will use the stage name if it's available, othe= rwise use the base image. --b1_Qjx0tQRLpbbgPXWMP0wR8rri8c5YK44wTY7AdQmSMg Content-Type: text/x-patch; name=0001-Improve-dockerfile-ts-mode-imenu-generation-Bug-5997.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Improve-dockerfile-ts-mode-imenu-generation-Bug-5997.patch RnJvbSAwOWZmYWRkOWY1ZGIxOTE3NGRjZWQ1NzJmM2YwYWM5OGY3ZDJhM2EzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBTdW4s IDExIERlYyAyMDIyIDIwOjUwOjU0IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gSW1wcm92ZSBkb2Nr ZXJmaWxlLXRzLW1vZGUgaW1lbnUgZ2VuZXJhdGlvbiAoQnVnIzU5OTc5KQoKKiBsaXNwL3Byb2dt b2Rlcy9kb2NrZXJmaWxlLXRzLW1vZGUuZWwgKHRyZWVzaXQtbm9kZS1jaGlsZC1ieS1maWVsZC1u YW1lKToKRGVjbGFyZS4KKGRvY2tlcmZpbGUtdHMtbW9kZS0taW1lbnUtMSk6IFVzZSBzdGFnZSBu YW1lIGlmIGF2YWlsYWJsZS4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9kb2NrZXJmaWxlLXRzLW1vZGUu ZWwgfCA3ICsrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvZG9ja2VyZmlsZS10cy1tb2RlLmVs IGIvbGlzcC9wcm9nbW9kZXMvZG9ja2VyZmlsZS10cy1tb2RlLmVsCmluZGV4IDU0NGUwZjgyZDYu LjQwZDkwY2MyZGYgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2RvY2tlcmZpbGUtdHMtbW9k ZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9kb2NrZXJmaWxlLXRzLW1vZGUuZWwKQEAgLTMzLDYg KzMzLDcgQEAKIChkZWNsYXJlLWZ1bmN0aW9uIHRyZWVzaXQtcGFyc2VyLWNyZWF0ZSAidHJlZXNp dC5jIikKIChkZWNsYXJlLWZ1bmN0aW9uIHRyZWVzaXQtaW5kdWNlLXNwYXJzZS10cmVlICJ0cmVl c2l0LmMiKQogKGRlY2xhcmUtZnVuY3Rpb24gdHJlZXNpdC1ub2RlLWNoaWxkICJ0cmVlc2l0LmMi KQorKGRlY2xhcmUtZnVuY3Rpb24gdHJlZXNpdC1ub2RlLWNoaWxkLWJ5LWZpZWxkLW5hbWUgInRy ZWVzaXQuYyIpCiAoZGVjbGFyZS1mdW5jdGlvbiB0cmVlc2l0LW5vZGUtc3RhcnQgInRyZWVzaXQu YyIpCiAoZGVjbGFyZS1mdW5jdGlvbiB0cmVlc2l0LW5vZGUtdHlwZSAidHJlZXNpdC5jIikKIApA QCAtMTE3LDggKzExOCwxMCBAQCBkb2NrZXJmaWxlLXRzLW1vZGUtLWltZW51LTEKICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGNoaWxkcmVuKSkKICAgICAgICAgIChuYW1lICh3aGVuIHRzLW5v ZGUKICAgICAgICAgICAgICAgICAgKHBjYXNlICh0cmVlc2l0LW5vZGUtdHlwZSB0cy1ub2RlKQot ICAgICAgICAgICAgICAgICAgICgiZnJvbV9pbnN0cnVjdGlvbiIgKHRyZWVzaXQtbm9kZS10ZXh0 Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHRyZWVzaXQtbm9kZS1j aGlsZCB0cy1ub2RlIDEpIHQpKSkpKQorICAgICAgICAgICAgICAgICAgICgiZnJvbV9pbnN0cnVj dGlvbiIKKyAgICAgICAgICAgICAgICAgICAgKHRyZWVzaXQtbm9kZS10ZXh0CisgICAgICAgICAg ICAgICAgICAgICAob3IgKHRyZWVzaXQtbm9kZS1jaGlsZC1ieS1maWVsZC1uYW1lIHRzLW5vZGUg ImFzIikKKyAgICAgICAgICAgICAgICAgICAgICAgICAodHJlZXNpdC1ub2RlLWNoaWxkIHRzLW5v ZGUgMSkpIHQpKSkpKQogICAgICAgICAgKG1hcmtlciAod2hlbiB0cy1ub2RlCiAgICAgICAgICAg ICAgICAgICAgKHNldC1tYXJrZXIgKG1ha2UtbWFya2VyKQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICh0cmVlc2l0LW5vZGUtc3RhcnQgdHMtbm9kZSkpKSkpCi0tIAoyLjM4LjEKCg== --b1_Qjx0tQRLpbbgPXWMP0wR8rri8c5YK44wTY7AdQmSMg--