bug#9936: kill-line problem

bug#9936: kill-line problem

[Andrew Kurn]

I'm getting a problem using kill-line in a buffer with much invisible text.
Instead of killing one line, it kills on and on til the end of the buffer.

Version is 21.2.1.
kill-whole-line = t
emacs -nw   (I have found other bugs persisting in this less popular use
      	    of emacs.)

I know you will ask me to reproduce the bug in the latest version of
emacs, but I don't want to get side-tracked right now, and I figure
that a preliminary bug-report is better than none at all.

Has anyone seen this one before?  Worked on it?

Thanks and keep up the good work.
Andrew

bug#9936: kill-line problem

[Glenn Morris]

Andrew Kurn wrote:

> I'm getting a problem using kill-line in a buffer with much invisible text.
> Instead of killing one line, it kills on and on til the end of the buffer.
>
> Version is 21.2.1.
> kill-whole-line = t

It sounds like the intended behaviour. With kill-whole-line non-nil,
kill-line kills up to wherever forward-visible-line ends up. Ie,
invisible newlines are ignored.

bug#9936: kill-line problem

[Andrew Kurn]

On Tue  1 Nov 2011 21:19 -0400, Glenn Morris wrote:


> Andrew Kurn wrote:
> 
> > I'm getting a problem using kill-line in a buffer with much invisible text.
> > Instead of killing one line, it kills on and on til the end of the buffer.
> >
> > Version is 21.2.1.
> > kill-whole-line = t
> 
> It sounds like the intended behaviour. With kill-whole-line non-nil,
> kill-line kills up to wherever forward-visible-line ends up. Ie,
> invisible newlines are ignored.


No, sorry, but there are several visible newlines in the way.  It eats
them all up.

A

PS.  Thanks for writing.  It's always a surprise to hear from a human.

bug#9936: kill-line problem

[Glenn Morris]

(Please keep 9936@debbugs cc'd)

Andrew Kurn wrote (on Wed, 2 Nov 2011 at 09:50 -0700):

> > It sounds like the intended behaviour. With kill-whole-line non-nil,
> > kill-line kills up to wherever forward-visible-line ends up. Ie,
> > invisible newlines are ignored.
> 
> No, sorry, but there are several visible newlines in the way.  It eats
> them all up.

Can you give a recipe showing how to reproduce the problem, starting
from emacs -q --no-site-file?

bug#9936: kill-line problem

[Andrew Kurn]

On Wed  2 Nov 2011 16:11 -0400, Glenn Morris wrote:
> 
> 
> (Please keep 9936@debbugs cc'd)
> 
> Andrew Kurn wrote (on Wed, 2 Nov 2011 at 09:50 -0700):
> 
> > > It sounds like the intended behaviour. With kill-whole-line non-nil,
> > > kill-line kills up to wherever forward-visible-line ends up. Ie,
> > > invisible newlines are ignored.
> > 
> > No, sorry, but there are several visible newlines in the way.  It eats
> > them all up.
> 
> Can you give a recipe showing how to reproduce the problem, starting
> from emacs -q --no-site-file?


This seems to work:

emacs -nw -q --no-site-file

(setq ss (concat (make-string 10 ?X) "," ))


(put-text-property 0 10 'invisible t ss)


(insert ss ss ss "\n" ss ss ss "\n" ss ss ss "\n" ss ss ss "\n" )


(setq kill-whole-line t)

---

Then use ^K to kill the first line.  They all disappear.


(let ((kill-whole-line t))
  (kill-line))


This seems to have the value "kill-region" . . . if that makes any
sense.

Andrew

bug#9936: kill-line problem

[Johan Bockgård]

Andrew Kurn <kurn@sfu.ca> writes:

> On Wed  2 Nov 2011 16:11 -0400, Glenn Morris wrote:
>> 
>> 
>> (Please keep 9936@debbugs cc'd)
>> 
>> Andrew Kurn wrote (on Wed, 2 Nov 2011 at 09:50 -0700):
>> 
>> > > It sounds like the intended behaviour. With kill-whole-line non-nil,
>> > > kill-line kills up to wherever forward-visible-line ends up. Ie,
>> > > invisible newlines are ignored.
>> > 
>> > No, sorry, but there are several visible newlines in the way.  It eats
>> > them all up.
>> 
>> Can you give a recipe showing how to reproduce the problem, starting
>> from emacs -q --no-site-file?
>
>
> This seems to work:
>
> emacs -nw -q --no-site-file
>
> (setq ss (concat (make-string 10 ?X) "," ))
>
>
> (put-text-property 0 10 'invisible t ss)
>
>
> (insert ss ss ss "\n" ss ss ss "\n" ss ss ss "\n" ss ss ss "\n" )
>
>
> (setq kill-whole-line t)

I can reproduce this bug in Emacs 21, but it appears to be fixed in
Emacs 22 and later. (The problem was in forward-visible-line.)

bug#9936: kill-line problem

[Glenn Morris]

Version: 22.1

>> emacs -nw -q --no-site-file
>>
>> (setq ss (concat (make-string 10 ?X) "," ))
>>
>>
>> (put-text-property 0 10 'invisible t ss)
>>
>>
>> (insert ss ss ss "\n" ss ss ss "\n" ss ss ss "\n" ss ss ss "\n" )
>>
>>
>> (setq kill-whole-line t)
>
> I can reproduce this bug in Emacs 21, but it appears to be fixed in
> Emacs 22 and later. (The problem was in forward-visible-line.)

Yes, I also see it in 21.4, but not in 22.1 or 23.3, so I'm closing
this as fixed in 22.1.

Thanks for the bug recipe. You are encouraged to upgrade to a more
recent Emacs! :)