* bug#23440: 25.1.50; xml.el parses default namespace incorrectly
@ 2016-05-04 0:27 Eric Abrahamsen
2016-05-04 6:06 ` David Engster
[not found] ` <handler.23440.B.146232172514754.ack@debbugs.gnu.org>
0 siblings, 2 replies; 9+ messages in thread
From: Eric Abrahamsen @ 2016-05-04 0:27 UTC (permalink / raw)
To: 23440
Apparently xml.el isn't doing quite the right thing when parsing xml
default namespaces. With the following text:
<multistatus xmlns="DAV:">
</multistatus>
M-: (xml-parse-region nil nil nil nil 'symbol-qnames)
Should return:
((DAV:multistatus ((... . "DAV:"))
But actually returns:
((multistatus ((http://www\.w3\.org/2000/xmlns/xmlns . "DAV:"))
A bit more background:
http://article.gmane.org/gmane.emacs.devel/203476/
In GNU Emacs 25.1.50.20 (i686-pc-linux-gnu, GTK+ Version 3.20.3)
of 2016-05-01 built on pellet
Windowing system distributor 'The X.Org Foundation', version 11.0.11803000
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 LIBSYSTEMD
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23440: 25.1.50; xml.el parses default namespace incorrectly
2016-05-04 0:27 bug#23440: 25.1.50; xml.el parses default namespace incorrectly Eric Abrahamsen
@ 2016-05-04 6:06 ` David Engster
2016-05-04 6:55 ` Eric Abrahamsen
[not found] ` <handler.23440.B.146232172514754.ack@debbugs.gnu.org>
1 sibling, 1 reply; 9+ messages in thread
From: David Engster @ 2016-05-04 6:06 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 23440
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
Eric Abrahamsen writes:
> Apparently xml.el isn't doing quite the right thing when parsing xml
> default namespaces. With the following text:
>
> <multistatus xmlns="DAV:">
> </multistatus>
>
> M-: (xml-parse-region nil nil nil nil 'symbol-qnames)
>
> Should return:
>
> ((DAV:multistatus ((... . "DAV:"))
>
> But actually returns:
>
> ((multistatus ((http://www\.w3\.org/2000/xmlns/xmlns . "DAV:"))
Should be fixed by the attached patch, but I need to test a bit more
before pushing it.
-David
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: xml-patch.diff --]
[-- Type: text/x-diff, Size: 604 bytes --]
diff --git a/lisp/xml.el b/lisp/xml.el
index 414300c..848a030 100644
--- a/lisp/xml.el
+++ b/lisp/xml.el
@@ -646,8 +646,10 @@ xml-parse-string
(defun xml-parse-attlist (&optional xml-ns)
"Return the attribute-list after point.
Leave point at the first non-blank character after the tag."
- (let ((attlist ())
- end-pos name)
+ (let* ((attlist ())
+ (symbol-qnames (eq (car-safe xml-ns) 'symbol-qnames))
+ (xml-ns (if symbol-qnames (cdr xml-ns) xml-ns))
+ end-pos name)
(skip-syntax-forward " ")
(while (looking-at (eval-when-compile
(concat "\\(" xml-name-re "\\)\\s-*=\\s-*")))
^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#23440: 25.1.50; xml.el parses default namespace incorrectly
2016-05-04 6:06 ` David Engster
@ 2016-05-04 6:55 ` Eric Abrahamsen
0 siblings, 0 replies; 9+ messages in thread
From: Eric Abrahamsen @ 2016-05-04 6:55 UTC (permalink / raw)
To: 23440
On 05/04/16 08:06 AM, David Engster wrote:
> Eric Abrahamsen writes:
>> Apparently xml.el isn't doing quite the right thing when parsing xml
>> default namespaces. With the following text:
>>
>> <multistatus xmlns="DAV:">
>> </multistatus>
>>
>> M-: (xml-parse-region nil nil nil nil 'symbol-qnames)
>>
>> Should return:
>>
>> ((DAV:multistatus ((... . "DAV:"))
>>
>> But actually returns:
>>
>> ((multistatus ((http://www\.w3\.org/2000/xmlns/xmlns . "DAV:"))
>
> Should be fixed by the attached patch, but I need to test a bit more
> before pushing it.
This solved my org-caldav <--> radicale server sync problem.
Thanks,
Eric
^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <handler.23440.B.146232172514754.ack@debbugs.gnu.org>]
* bug#23440: Acknowledgement (25.1.50; xml.el parses default namespace incorrectly)
[not found] ` <handler.23440.B.146232172514754.ack@debbugs.gnu.org>
@ 2017-01-23 18:56 ` Eric Abrahamsen
2017-01-23 21:15 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: Eric Abrahamsen @ 2017-01-23 18:56 UTC (permalink / raw)
To: 23440
I've been using this patch for months, with no ill effect. I hope
someone can push it soon!
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23440: Acknowledgement (25.1.50; xml.el parses default namespace incorrectly)
2017-01-23 18:56 ` bug#23440: Acknowledgement (25.1.50; xml.el parses default namespace incorrectly) Eric Abrahamsen
@ 2017-01-23 21:15 ` Glenn Morris
2017-01-23 22:32 ` Eric Abrahamsen
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2017-01-23 21:15 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 23440
Eric Abrahamsen wrote:
> I've been using this patch for months, with no ill effect. I hope
> someone can push it soon!
Why don't you want to commit it yourself?
(If you are waiting for David, then note that AFAICS you did not cc him
on any of your replies.)
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23440: Acknowledgement (25.1.50; xml.el parses default namespace incorrectly)
2017-01-23 21:15 ` Glenn Morris
@ 2017-01-23 22:32 ` Eric Abrahamsen
2017-01-24 21:58 ` David Engster
2017-01-25 22:44 ` Glenn Morris
0 siblings, 2 replies; 9+ messages in thread
From: Eric Abrahamsen @ 2017-01-23 22:32 UTC (permalink / raw)
To: Glenn Morris; +Cc: 23440, deng
On 01/23/17 16:15 PM, Glenn Morris wrote:
> Eric Abrahamsen wrote:
>
>> I've been using this patch for months, with no ill effect. I hope
>> someone can push it soon!
>
> Why don't you want to commit it yourself?
General hesitation! I was given Gnu access for ELPA, not Emacs. I don't
have much experience with XML. But I'll review CONTRIBUTE and do it.
> (If you are waiting for David, then note that AFAICS you did not cc him
> on any of your replies.)
I forgot a cc was necessary. I'll ping him on this and see if he has any
new opinions. If not I'll just push it.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23440: Acknowledgement (25.1.50; xml.el parses default namespace incorrectly)
2017-01-23 22:32 ` Eric Abrahamsen
@ 2017-01-24 21:58 ` David Engster
2017-01-25 22:44 ` Glenn Morris
1 sibling, 0 replies; 9+ messages in thread
From: David Engster @ 2017-01-24 21:58 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 23440-close
Eric Abrahamsen writes:
> I forgot a cc was necessary. I'll ping him on this and see if he has any
> new opinions. If not I'll just push it.
Thanks for the reminder, I completely forgot about that one. I just
pushed it with an accompanying test.
-David
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23440: Acknowledgement (25.1.50; xml.el parses default namespace incorrectly)
2017-01-23 22:32 ` Eric Abrahamsen
2017-01-24 21:58 ` David Engster
@ 2017-01-25 22:44 ` Glenn Morris
2017-01-26 7:04 ` Eric Abrahamsen
1 sibling, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2017-01-25 22:44 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 23440, deng
Eric Abrahamsen wrote:
> General hesitation! I was given Gnu access for ELPA, not Emacs.
Ah, ok! There's no way to tell that from the Savannah project membership page.
But in general I think you should feel free.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#23440: Acknowledgement (25.1.50; xml.el parses default namespace incorrectly)
2017-01-25 22:44 ` Glenn Morris
@ 2017-01-26 7:04 ` Eric Abrahamsen
0 siblings, 0 replies; 9+ messages in thread
From: Eric Abrahamsen @ 2017-01-26 7:04 UTC (permalink / raw)
To: Glenn Morris; +Cc: 23440
On 01/25/17 17:44 PM, Glenn Morris wrote:
> Eric Abrahamsen wrote:
>
>> General hesitation! I was given Gnu access for ELPA, not Emacs.
>
> Ah, ok! There's no way to tell that from the Savannah project membership page.
> But in general I think you should feel free.
In the future I will!
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-01-26 7:04 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-04 0:27 bug#23440: 25.1.50; xml.el parses default namespace incorrectly Eric Abrahamsen
2016-05-04 6:06 ` David Engster
2016-05-04 6:55 ` Eric Abrahamsen
[not found] ` <handler.23440.B.146232172514754.ack@debbugs.gnu.org>
2017-01-23 18:56 ` bug#23440: Acknowledgement (25.1.50; xml.el parses default namespace incorrectly) Eric Abrahamsen
2017-01-23 21:15 ` Glenn Morris
2017-01-23 22:32 ` Eric Abrahamsen
2017-01-24 21:58 ` David Engster
2017-01-25 22:44 ` Glenn Morris
2017-01-26 7:04 ` Eric Abrahamsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.