* bug#9841: 23.3; rmail-edit-current-message adds extra '>'s to Froms...
@ 2011-10-22 19:05 Mark Lillibridge
2012-12-07 9:03 ` Glenn Morris
[not found] ` <handler.9841.D9841.13548710619867.notifdone@debbugs.gnu.org>
0 siblings, 2 replies; 3+ messages in thread
From: Mark Lillibridge @ 2011-10-22 19:05 UTC (permalink / raw)
To: 9841
Start with a Rmail message (this one will do) not containing MIME that
contains lines like the following:
>From level 1
>>From level 2
>>>From level 3
Hit 'e' to edit the message. Notice that nothing changes. Now hit ^c^c
or ^c^] to stop editing (the later is supposed to abort, leaving the
message unchanged). Notice that your message now has one more > in
front of each of the from lines:
>>From level 1
>>>From level 2
>>>>From level 3
You can repeat this as many times as you like, adding more and more >'s.
Towards a patch, I notice that rmail-cease-edit has the following code:
rmailedit.el:135:
;; Disguise any "From " lines so they don't start a new message.
(goto-char (point-min))
(or rmail-old-pruned (forward-line 1))
(while (re-search-forward "^>*From " nil t)
(beginning-of-line)
(insert ">")
(forward-line))
There is no corresponding code in the rmail-edit-current-message or the
viewing code that I can find.
This probably needs more thought, but I think the decode code should
remove one >, and the incorporate new messages and done editting code
should add one > (as above). Note this is related to bug #6574: Rmail
23 uses a broken mailbox format (mboxo) instead of a sane one like
mboxrd.
I note that fetchmail to mbox loses information because it only adds
a > to From's without one already. This is arguably not Rmail's fault,
however.
- Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#9841: 23.3; rmail-edit-current-message adds extra '>'s to Froms...
2011-10-22 19:05 bug#9841: 23.3; rmail-edit-current-message adds extra '>'s to Froms Mark Lillibridge
@ 2012-12-07 9:03 ` Glenn Morris
[not found] ` <handler.9841.D9841.13548710619867.notifdone@debbugs.gnu.org>
1 sibling, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2012-12-07 9:03 UTC (permalink / raw)
To: 9841-done
Version: 24.4
Mark Lillibridge wrote:
> Start with a Rmail message (this one will do) not containing MIME that
> contains lines like the following:
Actually, I can only reproduce this with a message that _is_ MIME, ie
has a "MIME-version: 1.0" header (which almost everything does).
For non-MIME messages, rmail-show-message-1 _does_ add >, which is
why rmail-cease-edit tries to put them back. Anyway, I installed a
change to make it not do that for MIME messages, which have not been
unescaped during display.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#9841: closed (Re: bug#9841: 23.3; rmail-edit-current-message adds extra '>'s to Froms...)
[not found] ` <handler.9841.D9841.13548710619867.notifdone@debbugs.gnu.org>
@ 2013-01-01 21:53 ` Mark Lillibridge
0 siblings, 0 replies; 3+ messages in thread
From: Mark Lillibridge @ 2013-01-01 21:53 UTC (permalink / raw)
To: 9841, rgm
Glenn Morris <rgm@gnu.org> wrote:
> Mark Lillibridge wrote:
>
> > Start with a Rmail message (this one will do) not containing MIME that
> > contains lines like the following:
>
> Actually, I can only reproduce this with a message that _is_ MIME, ie
> has a "MIME-version: 1.0" header (which almost everything does).
> For non-MIME messages, rmail-show-message-1 _does_ add >, which is
> why rmail-cease-edit tries to put them back. Anyway, I installed a
> change to make it not do that for MIME messages, which have not been
> unescaped during display.
You're right; this problem does not occur with non-MIME messages
under 24.2 (my current test system).
I think your patch may not work correctly if the user adds a "From "
line to a MIME message. Seems like there are two choices: (1) give an
error in that case and refuse to exit editing (similar to the screwed up
headers case) or (2) unescape From lines when the edit starts and
re-escape them when the edit finishes. (2) seems friendlier to users as
it means users don't have to manually escape From lines when editing.
- Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-01 21:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-22 19:05 bug#9841: 23.3; rmail-edit-current-message adds extra '>'s to Froms Mark Lillibridge
2012-12-07 9:03 ` Glenn Morris
[not found] ` <handler.9841.D9841.13548710619867.notifdone@debbugs.gnu.org>
2013-01-01 21:53 ` bug#9841: closed (Re: bug#9841: 23.3; rmail-edit-current-message adds extra '>'s to Froms...) Mark Lillibridge
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.