From: Chunyu Wang <cymacs@gmail.com>
To: Lennart Borgman <lennart.borgman@gmail.com>
Cc: 6126@debbugs.gnu.org
Subject: bug#6126: 24.0.50; Segmentation fault when w32-shell-execute try to open an unassociated file
Date: Fri, 7 May 2010 09:52:42 +0800 [thread overview]
Message-ID: <l2sd4d843eb1005061852xc8eb51s1304a55517ab56b5@mail.gmail.com> (raw)
In-Reply-To: <z2xe01d8a51005061700h9f09bdcaja2038074acf3065e@mail.gmail.com>
2010/5/7 Lennart Borgman <lennart.borgman@gmail.com>:
> ...
> I do not understand C code but here are some small observations:
>
> - In w32_error the argument error_no has type int. It should be more
> easy to understand if it had the type DWORD which is what GetLastError
> returns. Will using int be correct on all w32 platforms?
Sorry, I have no idea completely.
> - The call to error in w32-shell-execute has only two arguments. Is
> that correct? error in eval.c takes four arguments.
(w32-shell-execute OPERATION DOCUMENT &optional PARAMETERS SHOW-FLAG)
The last two are optional, but emacs crashed even if called with them.
> - The parameter lpBuffer to FormatMessage has the type LPTSTR. Is it
> correct to call that with *char (ie buf)? It looks in the backtrace
> like even the argument a1 to error is incorrect.
no idea too.
--
Harbin Institute of Technology, China
Chunyu Wang
next prev parent reply other threads:[~2010-05-07 1:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 16:08 bug#6126: 24.0.50; Segmentation fault when w32-shell-execute try to open an unassociated file Chunyu Wang
2010-05-07 0:00 ` Lennart Borgman
2010-05-07 1:52 ` Chunyu Wang [this message]
2010-05-07 9:27 ` Eli Zaretskii
2010-05-07 10:52 ` Lennart Borgman
2010-05-07 9:03 ` Eli Zaretskii
2010-05-07 12:17 ` Chunyu Wang
2010-05-07 14:21 ` Chunyu Wang
2010-05-07 15:12 ` Eli Zaretskii
2010-05-07 16:29 ` Chunyu Wang
2010-05-07 17:16 ` Eli Zaretskii
2010-05-07 20:52 ` Lennart Borgman
2010-05-08 7:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=l2sd4d843eb1005061852xc8eb51s1304a55517ab56b5@mail.gmail.com \
--to=cymacs@gmail.com \
--cc=6126@debbugs.gnu.org \
--cc=lennart.borgman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.