* bug#10594: grep column counting is broken in Emacs 24
@ 2012-01-24 14:13 Le Wang
2012-01-25 2:02 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Le Wang @ 2012-01-24 14:13 UTC (permalink / raw)
To: 10594
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
Reproducible in very recent build as of this message.
The effect of this bug is when I click on a grep target the point moves to
one in front of the match. (assuming compilation-first-column==1, which is
the default)
Details:
`compilation-move-to-column' always references `compilation-first-column'
when calculating columns. It should not for "grep" output, because the
column # is calculated by `grep-regexp-alist'.
--
Le
[-- Attachment #2: Type: text/html, Size: 505 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#10594: grep column counting is broken in Emacs 24
2012-01-24 14:13 bug#10594: grep column counting is broken in Emacs 24 Le Wang
@ 2012-01-25 2:02 ` Glenn Morris
2012-01-27 1:28 ` Juri Linkov
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2012-01-25 2:02 UTC (permalink / raw)
To: 10594-done
Version: 24.0.93
Le Wang wrote:
> The effect of this bug is when I click on a grep target the point moves to
> one in front of the match.
Thanks; fixed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#10594: grep column counting is broken in Emacs 24
2012-01-25 2:02 ` Glenn Morris
@ 2012-01-27 1:28 ` Juri Linkov
2012-01-27 21:23 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Juri Linkov @ 2012-01-27 1:28 UTC (permalink / raw)
To: 10594
>> The effect of this bug is when I click on a grep target the point moves to
>> one in front of the match.
>
> Thanks; fixed.
Shouldn't exactly the same change be applied to
`compilation-internal-error-properties' as well?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#10594: grep column counting is broken in Emacs 24
2012-01-27 1:28 ` Juri Linkov
@ 2012-01-27 21:23 ` Glenn Morris
0 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2012-01-27 21:23 UTC (permalink / raw)
To: Juri Linkov; +Cc: 10594
Juri Linkov wrote:
> Shouldn't exactly the same change be applied to
> `compilation-internal-error-properties' as well?
Yes, I guess.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-27 21:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-24 14:13 bug#10594: grep column counting is broken in Emacs 24 Le Wang
2012-01-25 2:02 ` Glenn Morris
2012-01-27 1:28 ` Juri Linkov
2012-01-27 21:23 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.