all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Engster <deng@randomsample.de>
To: emacs-pretest-bug@gnu.org
Subject: bug#4548: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook
Date: Thu, 24 Sep 2009 15:35:14 +0200	[thread overview]
Message-ID: <kz7hvo4ga5.fsf@engster.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

In hideshow.el, there is a hook 'hs-show-hook' which should be run
whenever some text is shown again (i.e., unfolded).

However, the command hs-show-block does not run this hook; a (trivial)
patch which will fix this is attached.

Regards,
David


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: hideshow-patch.diff --]
[-- Type: text/x-diff, Size: 672 bytes --]

Index: hideshow.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/hideshow.el,v
retrieving revision 1.80
diff -u -r1.80 hideshow.el
--- hideshow.el	14 Aug 2009 23:02:41 -0000	1.80
+++ hideshow.el	24 Sep 2009 13:28:55 -0000
@@ -869,8 +869,8 @@
                    q (progn (hs-forward-sexp (match-data t) 1) (point)))))
       (when (and p q)
         (hs-discard-overlays p q)
-        (goto-char (if end q (1+ p)))))
-    (run-hooks 'hs-show-hook))))
+        (goto-char (if end q (1+ p))))))
+   (run-hooks 'hs-show-hook)))
 
 (defun hs-hide-level (arg)
   "Hide all blocks ARG levels below this block.

             reply	other threads:[~2009-09-24 13:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f7ccd24b0909241733h3f4848a1m5a77ba89c96ab0bf@mail.gmail.com>
2009-09-24 13:35 ` David Engster [this message]
2009-09-25  0:40   ` bug#4548: marked as done (23.1.50; hideshow.el - hs-show-block does not run hs-show-hook) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kz7hvo4ga5.fsf@engster.org \
    --to=deng@randomsample.de \
    --cc=4548@emacsbugs.donarmstrong.com \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.